From shipilev at amazon.de Mon Feb 10 16:37:20 2025 From: shipilev at amazon.de (Aleksey Shipilev) Date: Mon, 10 Feb 2025 17:37:20 +0100 Subject: Leyden PRs and repo-leyden bugs Message-ID: (cc'ing leyden-dev@) Hi Skara devs! I was wondering what kind of config Leyden repo is missing, so that PRs are not closed automatically? See for example this bug: https://bugs.openjdk.org/browse/JDK-8348960 ...and here is the integrated PR: https://github.com/openjdk/leyden/pull/30 I suspect the problem might be that PRs are targeting the "premain", not "master" branch? Is there a way to tell bots to treat "premain" branch as repo-leyden, maybe? Here is jcheck for premain branch: https://github.com/openjdk/leyden/blob/premain/.jcheck/conf -- Thanks, -Aleksey From erik.joelsson at oracle.com Mon Feb 10 18:51:54 2025 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 10 Feb 2025 10:51:54 -0800 Subject: Leyden PRs and repo-leyden bugs In-Reply-To: References: Message-ID: <127cd304-2911-41f4-a0bb-b82123daa90c@oracle.com> The leyden repository has not been configured for "issue notification", so Skara is making no attempt at notifying issues in JBS based on repository activity. This is a server/bot side configuration that's missing. You should not change .jcheck/conf. If you would like this to be configured, please get the project lead to confirm. /Erik On 2/10/25 8:37 AM, Aleksey Shipilev wrote: > (cc'ing leyden-dev@) > > Hi Skara devs! > > I was wondering what kind of config Leyden repo is missing, so that > PRs are not closed automatically? See for example this bug: > ? https://bugs.openjdk.org/browse/JDK-8348960 > > ...and here is the integrated PR: > ? https://github.com/openjdk/leyden/pull/30 > > I suspect the problem might be that PRs are targeting the "premain", > not "master" branch? Is there a way to tell bots to treat "premain" > branch as repo-leyden, maybe? > > Here is jcheck for premain branch: > ? https://github.com/openjdk/leyden/blob/premain/.jcheck/conf > From shipilev at amazon.de Tue Feb 11 11:56:39 2025 From: shipilev at amazon.de (Aleksey Shipilev) Date: Tue, 11 Feb 2025 12:56:39 +0100 Subject: Leyden PRs and repo-leyden bugs In-Reply-To: <127cd304-2911-41f4-a0bb-b82123daa90c@oracle.com> References: <127cd304-2911-41f4-a0bb-b82123daa90c@oracle.com> Message-ID: <8d3a1e62-ac04-4930-bd9b-602adad54712@amazon.de> Right, thanks! Mark / John / Ioi, if you could confirm our desire to make this work for Leyden PRs? Thanks, -Aleksey On 10.02.25 19:51, Erik Joelsson wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open > attachments unless you can confirm the sender and know the content is safe. > > > > The leyden repository has not been configured for "issue notification", > so Skara is making no attempt at notifying issues in JBS based on > repository activity. This is a server/bot side configuration that's > missing. You should not change .jcheck/conf. > > If you would like this to be configured, please get the project lead to > confirm. > > /Erik > > On 2/10/25 8:37 AM, Aleksey Shipilev wrote: >> (cc'ing leyden-dev@) >> >> Hi Skara devs! >> >> I was wondering what kind of config Leyden repo is missing, so that >> PRs are not closed automatically? See for example this bug: >> ? https://bugs.openjdk.org/browse/JDK-8348960 >> >> ...and here is the integrated PR: >> ? https://github.com/openjdk/leyden/pull/30 >> >> I suspect the problem might be that PRs are targeting the "premain", >> not "master" branch? Is there a way to tell bots to treat "premain" >> branch as repo-leyden, maybe? >> >> Here is jcheck for premain branch: >> ? https://github.com/openjdk/leyden/blob/premain/.jcheck/conf >> From alanb at openjdk.org Wed Feb 12 08:28:00 2025 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 12 Feb 2025 08:28:00 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: <-P9Yqo8gCrQKdOvh2H0ub4NHWx6LKhJZvMXP86xWENc=.f182a93e-2f9e-4b16-822d-a36c6f083e73@github.com> On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record Is there follow-up work to enable this in the "jdk" repo? ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2652973624 From erikj at openjdk.org Wed Feb 12 14:06:20 2025 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 12 Feb 2025 14:06:20 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-P9Yqo8gCrQKdOvh2H0ub4NHWx6LKhJZvMXP86xWENc=.f182a93e-2f9e-4b16-822d-a36c6f083e73@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> <-P9Yqo8gCrQKdOvh2H0ub4NHWx6LKhJZvMXP86xWENc=.f182a93e-2f9e-4b16-822d-a36c6f083e73@github.com> Message-ID: On Wed, 12 Feb 2025 08:25:50 GMT, Alan Bateman wrote: > Is there follow-up work to enable this in the "jdk" repo? There was: https://github.com/openjdk/jdk/pull/22721 ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2653805947 From alanb at openjdk.org Wed Feb 12 15:53:32 2025 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 12 Feb 2025 15:53:32 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record > > Is there follow-up work to enable this in the "jdk" repo? > > There was: [openjdk/jdk#22721](https://github.com/openjdk/jdk/pull/22721) I missed that, is it effective? ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654126577 From kcr at openjdk.org Wed Feb 12 16:09:40 2025 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 12 Feb 2025 16:09:40 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record It doesn't seem like it is working as expected. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654174368 From zsong at openjdk.org Wed Feb 12 18:04:18 2025 From: zsong at openjdk.org (Zhao Song) Date: Wed, 12 Feb 2025 18:04:18 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Wed, 12 Feb 2025 16:07:33 GMT, Kevin Rushforth wrote: > It doesn't seem like it is working as expected. Did you find any bug? ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654474463 From alanb at openjdk.org Wed Feb 12 18:08:14 2025 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 12 Feb 2025 18:08:14 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record [PR23577](https://github.com/openjdk/jdk/pull/23577) is one from yesterday. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654483118 From zsong at openjdk.org Wed Feb 12 18:12:19 2025 From: zsong at openjdk.org (Zhao Song) Date: Wed, 12 Feb 2025 18:12:19 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: <5J05qVDOTlF1K9dlTsfhdVqiw-9g2oC5wC8hRR9_hig=.91384347-8852-4f79-9d05-65e3b4eef0e7@github.com> On Wed, 12 Feb 2025 18:06:08 GMT, Alan Bateman wrote: > [PR23577](https://github.com/openjdk/jdk/pull/23577) is one from yesterday. Thank you, I will investigate what's the issue. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654492566 From kcr at openjdk.org Wed Feb 12 18:16:41 2025 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 12 Feb 2025 18:16:41 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <5J05qVDOTlF1K9dlTsfhdVqiw-9g2oC5wC8hRR9_hig=.91384347-8852-4f79-9d05-65e3b4eef0e7@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> <5J05qVDOTlF1K9dlTsfhdVqiw-9g2oC5wC8hRR9_hig=.91384347-8852-4f79-9d05-65e3b4eef0e7@github.com> Message-ID: On Wed, 12 Feb 2025 18:10:11 GMT, Zhao Song wrote: > > [PR23577](https://github.com/openjdk/jdk/pull/23577) is one from yesterday. > > Thank you, I will investigate what's the issue. To clarify, the above PR is the one that fixed the mistakenly introduced (missing comma) copyright line. The PR that introduced it was PR openjdk/jdk#23550 ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654500919 From zsong at openjdk.org Wed Feb 12 19:55:49 2025 From: zsong at openjdk.org (Zhao Song) Date: Wed, 12 Feb 2025 19:55:49 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record Opened https://github.com/openjdk/jdk/pull/23598 to fix the issue ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2654708982 From jsjolen at openjdk.org Tue Feb 25 10:07:44 2025 From: jsjolen at openjdk.org (Johan =?UTF-8?B?U2rDtmxlbg==?=) Date: Tue, 25 Feb 2025 10:07:44 GMT Subject: RFR: 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime Message-ID: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> Hi, We moved NMT's code to its own subdirectory a while ago, but we never fixed the association for Skara. I, hopefully, filed the ticket in JBS correctly. Thank you! Johan ------------- Commit messages: - NMT should be associated with the hotspot-runtime tag Changes: https://git.openjdk.org/skara/pull/1705/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1705&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2446 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1705.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1705/head:pull/1705 PR: https://git.openjdk.org/skara/pull/1705 From erikj at openjdk.org Tue Feb 25 15:42:58 2025 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 25 Feb 2025 15:42:58 GMT Subject: RFR: 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime In-Reply-To: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> References: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> Message-ID: On Tue, 25 Feb 2025 10:02:42 GMT, Johan Sj?len wrote: > Hi, > > We moved NMT's code to its own subdirectory a while ago, but we never fixed the association for Skara. I, hopefully, filed the ticket in JBS correctly. > > Thank you! > > Johan Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1705#pullrequestreview-2641552120 From jsjolen at openjdk.org Tue Feb 25 15:54:10 2025 From: jsjolen at openjdk.org (Johan =?UTF-8?B?U2rDtmxlbg==?=) Date: Tue, 25 Feb 2025 15:54:10 GMT Subject: RFR: 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime In-Reply-To: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> References: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> Message-ID: <9FYIVnIX7gW8yKmX1PDsLAy3EK6yByUFJmuvn-6-yVI=.416a8e7b-0d10-43ef-888c-fd6f88efa8b0@github.com> On Tue, 25 Feb 2025 10:02:42 GMT, Johan Sj?len wrote: > Hi, > > We moved NMT's code to its own subdirectory a while ago, but we never fixed the association for Skara. I, hopefully, filed the ticket in JBS correctly. > > Thank you! > > Johan Thanks Erik ------------- PR Comment: https://git.openjdk.org/skara/pull/1705#issuecomment-2682466630 From duke at openjdk.org Tue Feb 25 15:54:10 2025 From: duke at openjdk.org (duke) Date: Tue, 25 Feb 2025 15:54:10 GMT Subject: RFR: 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime In-Reply-To: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> References: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> Message-ID: On Tue, 25 Feb 2025 10:02:42 GMT, Johan Sj?len wrote: > Hi, > > We moved NMT's code to its own subdirectory a while ago, but we never fixed the association for Skara. I, hopefully, filed the ticket in JBS correctly. > > Thank you! > > Johan @jdksjolen Your change (at version 3d437eef973264b2f5d393a10072a6f5efb81d85) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/skara/pull/1705#issuecomment-2682467849 From jsjolen at openjdk.org Tue Feb 25 15:58:39 2025 From: jsjolen at openjdk.org (Johan =?UTF-8?B?U2rDtmxlbg==?=) Date: Tue, 25 Feb 2025 15:58:39 GMT Subject: Integrated: 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime In-Reply-To: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> References: <5CFzXnc-sP_rxDDYR0dmeb7yxvORoi5ZGhRGI8iD2_Q=.8c89825d-f5d4-46c4-b35d-f5cf96b60429@github.com> Message-ID: On Tue, 25 Feb 2025 10:02:42 GMT, Johan Sj?len wrote: > Hi, > > We moved NMT's code to its own subdirectory a while ago, but we never fixed the association for Skara. I, hopefully, filed the ticket in JBS correctly. > > Thank you! > > Johan This pull request has now been integrated. Changeset: b8a99e21 Author: Johan Sj?len Committer: Erik Joelsson URL: https://git.openjdk.org/skara/commit/b8a99e211aae1cec3ae5b6477e9c0c91c0761284 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 2446: src/hotspot/share/nmt/ should be associated with hotspot-runtime Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1705