From zsong at openjdk.org Thu Jul 3 20:56:48 2025 From: zsong at openjdk.org (Zhao Song) Date: Thu, 3 Jul 2025 20:56:48 GMT Subject: RFR: 2510: Bug closed due to inactivity even though there was "activity" Message-ID: <8ASTfNy1jJJjaRe8EfR_OzYDfYgDGy-2MyNFz9ZlBtU=.9e166f5c-4d10-44e8-8f80-461e326544b9@github.com> Currently, the PullRequestPrunerBot considers only comments, reviews, and review comments as activity. Therefore, it can sometimes mistakenly close a user's pull request. In this patch, I am trying to let PullRequestPrunerBot counts commits, pr state changes as valid activities. ------------- Commit messages: - update - update - update - update - 2510 Changes: https://git.openjdk.org/skara/pull/1723/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1723&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2510 Stats: 135 lines in 12 files changed: 123 ins; 0 del; 12 mod Patch: https://git.openjdk.org/skara/pull/1723.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1723/head:pull/1723 PR: https://git.openjdk.org/skara/pull/1723 From jlahoda at openjdk.org Fri Jul 4 08:43:28 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Fri, 4 Jul 2025 08:43:28 GMT Subject: RFR: Merging JShell's file locations mapping into the 'compiler' label, and deleting mapping for 'kulla'. Message-ID: There's a proposal to dissolve the Kulla project (the project that introduced JShell into JDK), and use the `compiler-dev` mailing list instead of `kulla-dev`: https://mail.openjdk.org/pipermail/kulla-dev/2025-June/005928.html The idea in this PR is to merge the file mappings used for JShell into the `compiler` label, so that changes touching JShell get the `compiler` label, and the e-mails are sent to `compiler-dev`. Please let me now if there's something better than can be done, or what more is needed to stop using the `kulla-dev` list. Thanks! ------------- Commit messages: - Merging JShell's file locations mapping into the 'compiler' label, and deleting mapping for 'kulla'. Changes: https://git.openjdk.org/skara/pull/1724/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1724&range=00 Stats: 14 lines in 1 file changed: 6 ins; 8 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1724.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1724/head:pull/1724 PR: https://git.openjdk.org/skara/pull/1724 From zsong at openjdk.org Mon Jul 7 16:44:58 2025 From: zsong at openjdk.org (Zhao Song) Date: Mon, 7 Jul 2025 16:44:58 GMT Subject: RFR: Merging JShell's file locations mapping into the 'compiler' label, and deleting mapping for 'kulla'. In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 08:40:32 GMT, Jan Lahoda wrote: > There's a proposal to dissolve the Kulla project (the project that introduced JShell into JDK), and use the `compiler-dev` mailing list instead of `kulla-dev`: > https://mail.openjdk.org/pipermail/kulla-dev/2025-June/005928.html > > The idea in this PR is to merge the file mappings used for JShell into the `compiler` label, so that changes touching JShell get the `compiler` label, and the e-mails are sent to `compiler-dev`. > > Please let me now if there's something better than can be done, or what more is needed to stop using the `kulla-dev` list. > > Thanks! The change looks good to me. But please file an issue for it in SKARA project for it. https://bugs.openjdk.org/projects/SKARA ------------- PR Comment: https://git.openjdk.org/skara/pull/1724#issuecomment-3045882521 From jlahoda at openjdk.org Mon Jul 7 16:51:09 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 7 Jul 2025 16:51:09 GMT Subject: RFR: 2535: Merge JShell's file locations mapping into the 'compiler' label, and deleting mapping for 'kulla' In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 08:40:32 GMT, Jan Lahoda wrote: > There's a proposal to dissolve the Kulla project (the project that introduced JShell into JDK), and use the `compiler-dev` mailing list instead of `kulla-dev`: > https://mail.openjdk.org/pipermail/kulla-dev/2025-June/005928.html > > The idea in this PR is to merge the file mappings used for JShell into the `compiler` label, so that changes touching JShell get the `compiler` label, and the e-mails are sent to `compiler-dev`. > > Please let me now if there's something better than can be done, or what more is needed to stop using the `kulla-dev` list. > > Thanks! Thanks. I opened: https://bugs.openjdk.org/browse/SKARA-2535 please let me know if something should be improved. ------------- PR Comment: https://git.openjdk.org/skara/pull/1724#issuecomment-3045906303 From zsong at openjdk.org Mon Jul 7 16:55:29 2025 From: zsong at openjdk.org (Zhao Song) Date: Mon, 7 Jul 2025 16:55:29 GMT Subject: RFR: 2535: Merge JShell's file locations mapping into the 'compiler' label, and deleting mapping for 'kulla' In-Reply-To: References: Message-ID: On Fri, 4 Jul 2025 08:40:32 GMT, Jan Lahoda wrote: > There's a proposal to dissolve the Kulla project (the project that introduced JShell into JDK), and use the `compiler-dev` mailing list instead of `kulla-dev`: > https://mail.openjdk.org/pipermail/kulla-dev/2025-June/005928.html > > The idea in this PR is to merge the file mappings used for JShell into the `compiler` label, so that changes touching JShell get the `compiler` label, and the e-mails are sent to `compiler-dev`. > > Please let me now if there's something better than can be done, or what more is needed to stop using the `kulla-dev` list. > > Thanks! Marked as reviewed by zsong (Reviewer). ------------- PR Review: https://git.openjdk.org/skara/pull/1724#pullrequestreview-2994692798