From zsong at openjdk.org  Mon Jun  2 16:10:09 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 16:10:09 GMT
Subject: RFR: 2508: IssueNotifier should handle inactive JBS users
Message-ID: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>

This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.

-------------

Commit messages:
 - SKARA-2508

Changes: https://git.openjdk.org/skara/pull/1720/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1720&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2508
  Stats: 21 lines in 1 file changed: 12 ins; 7 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1720.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1720/head:pull/1720

PR: https://git.openjdk.org/skara/pull/1720

From erikj at openjdk.org  Mon Jun  2 16:39:00 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 16:39:00 GMT
Subject: RFR: 2508: IssueNotifier should handle inactive JBS users
In-Reply-To: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
References: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
Message-ID: <ldTqHUaHA_WlOq39ZGWiHaIG6nyMbmxB-2y5iMqs05s=.7f691dee-e63b-49a7-981a-2a0eebf6089f@github.com>

On Mon, 2 Jun 2025 16:04:13 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1720#pullrequestreview-2889184120

From zsong at openjdk.org  Mon Jun  2 16:49:50 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 16:49:50 GMT
Subject: RFR: 2512: Update windows version in github runner
Message-ID: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>

Update windows-2019 to windows-2022 in .github/ci.yml

-------------

Commit messages:
 - SKARA-2512

Changes: https://git.openjdk.org/skara/pull/1721/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2512
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From erikj at openjdk.org  Mon Jun  2 16:57:01 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 16:57:01 GMT
Subject: RFR: 2512: Update windows version in github runner
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <tuDnS1fK2pBHsrjcVIvrQBR-lautDH4jxIRqZrTWSXY=.c8696297-8e3f-40c7-9db1-0f755b8d59e9@github.com>

On Mon, 2 Jun 2025 16:14:31 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Update windows-2019 to windows-2022 in .github/ci.yml

.github/workflows/ci.yml line 108:

> 106:   win:
> 107:     name: Windows x64
> 108:     runs-on: "windows-2022"

I think we should go straight to the latest 2025 if it works.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2121700570

From zsong at openjdk.org  Mon Jun  2 17:30:03 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:30:03 GMT
Subject: RFR: 2512: Update windows version in github runner [v2]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <KQulAjzDxmnyMiAVJIWu3K5rS10crRnxWJVL8zkviQU=.969ab003-e807-44f5-8b25-b380f0e8c1a2@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  udpate

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/009c9f64..3d4ac741

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From zsong at openjdk.org  Mon Jun  2 17:30:03 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:30:03 GMT
Subject: RFR: 2512: Update windows version in github runner [v2]
In-Reply-To: <tuDnS1fK2pBHsrjcVIvrQBR-lautDH4jxIRqZrTWSXY=.c8696297-8e3f-40c7-9db1-0f755b8d59e9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <tuDnS1fK2pBHsrjcVIvrQBR-lautDH4jxIRqZrTWSXY=.c8696297-8e3f-40c7-9db1-0f755b8d59e9@github.com>
Message-ID: <q7t2qMJOyYkotvxd9TFeqtl2AbJlIHnSzeAlb1Jt2bk=.6d6a5721-2261-4999-8b58-62a42b2cbab9@github.com>

On Mon, 2 Jun 2025 16:54:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   udpate
>
> .github/workflows/ci.yml line 108:
> 
>> 106:   win:
>> 107:     name: Windows x64
>> 108:     runs-on: "windows-2022"
> 
> I think we should go straight to the latest 2025 if it works.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2121754702

From zsong at openjdk.org  Mon Jun  2 17:34:35 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:34:35 GMT
Subject: RFR: 2508: IssueNotifier should handle inactive JBS users [v2]
In-Reply-To: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
References: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
Message-ID: <oho_UDUiXQnuvATw7MqXsO0VLynIHWR0sJrZIglWYRs=.105a988d-b0e1-479f-a5f5-6a52e918f58c@github.com>

> This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  update copyright

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1720/files
  - new: https://git.openjdk.org/skara/pull/1720/files/84106573..89a8f499

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1720&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1720&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1720.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1720/head:pull/1720

PR: https://git.openjdk.org/skara/pull/1720

From zsong at openjdk.org  Mon Jun  2 17:37:11 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:37:11 GMT
Subject: RFR: 2512: Update windows version in github runner [v2]
In-Reply-To: <q7t2qMJOyYkotvxd9TFeqtl2AbJlIHnSzeAlb1Jt2bk=.6d6a5721-2261-4999-8b58-62a42b2cbab9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <tuDnS1fK2pBHsrjcVIvrQBR-lautDH4jxIRqZrTWSXY=.c8696297-8e3f-40c7-9db1-0f755b8d59e9@github.com>
 <q7t2qMJOyYkotvxd9TFeqtl2AbJlIHnSzeAlb1Jt2bk=.6d6a5721-2261-4999-8b58-62a42b2cbab9@github.com>
Message-ID: <BSDVTD1kiwDPLJpIwkqiZAyLBezTJWt7EEhQIICO5_Q=.890a4772-747f-402f-94b0-1201f61d2c20@github.com>

On Mon, 2 Jun 2025 17:24:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> .github/workflows/ci.yml line 108:
>> 
>>> 106:   win:
>>> 107:     name: Windows x64
>>> 108:     runs-on: "windows-2022"
>> 
>> I think we should go straight to the latest 2025 if it works.
>
> Sure

oh, it failed on windows-2025... Will investigate it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2121777049

From erikj at openjdk.org  Mon Jun  2 17:45:50 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 17:45:50 GMT
Subject: RFR: 2512: Update windows version in github runner [v2]
In-Reply-To: <BSDVTD1kiwDPLJpIwkqiZAyLBezTJWt7EEhQIICO5_Q=.890a4772-747f-402f-94b0-1201f61d2c20@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <tuDnS1fK2pBHsrjcVIvrQBR-lautDH4jxIRqZrTWSXY=.c8696297-8e3f-40c7-9db1-0f755b8d59e9@github.com>
 <q7t2qMJOyYkotvxd9TFeqtl2AbJlIHnSzeAlb1Jt2bk=.6d6a5721-2261-4999-8b58-62a42b2cbab9@github.com>
 <BSDVTD1kiwDPLJpIwkqiZAyLBezTJWt7EEhQIICO5_Q=.890a4772-747f-402f-94b0-1201f61d2c20@github.com>
Message-ID: <9jfMbqdsjb3PPiz64OCL29QWd-Hsi8srQfYU_w_hF_o=.0e3e6528-bfd7-4ca5-ab7e-368597865d79@github.com>

On Mon, 2 Jun 2025 17:35:02 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Sure
>
> oh, it failed on windows-2025... Will investigate it

Looking at the documentation for these configurations, windows-2025 does not have Mercurial anymore. I think it's ok to not verify Mercurial dependent tests on Windows (or perhaps at all), so we could add assumes to those tests and check if Mercurial is available.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2121794462

From erikj at openjdk.org  Mon Jun  2 17:46:31 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 17:46:31 GMT
Subject: RFR: 2508: IssueNotifier should handle inactive JBS users [v2]
In-Reply-To: <oho_UDUiXQnuvATw7MqXsO0VLynIHWR0sJrZIglWYRs=.105a988d-b0e1-479f-a5f5-6a52e918f58c@github.com>
References: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
 <oho_UDUiXQnuvATw7MqXsO0VLynIHWR0sJrZIglWYRs=.105a988d-b0e1-479f-a5f5-6a52e918f58c@github.com>
Message-ID: <G_DARTD8gVebjDzhdYFA5Dertj--kceYK1Nc4PSehtk=.e7c4802f-122f-40ce-826f-8053e3f46485@github.com>

On Mon, 2 Jun 2025 17:34:35 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1720#pullrequestreview-2889396808

From zsong at openjdk.org  Mon Jun  2 17:59:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:59:52 GMT
Subject: RFR: 2508: IssueNotifier should handle inactive JBS users [v2]
In-Reply-To: <oho_UDUiXQnuvATw7MqXsO0VLynIHWR0sJrZIglWYRs=.105a988d-b0e1-479f-a5f5-6a52e918f58c@github.com>
References: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
 <oho_UDUiXQnuvATw7MqXsO0VLynIHWR0sJrZIglWYRs=.105a988d-b0e1-479f-a5f5-6a52e918f58c@github.com>
Message-ID: <lI7EEFwXMsnT-uzfKakPKRWtTuELsTxYQAFAvzhcq_Y=.683fc7bb-a651-421b-b89c-4111340f8262@github.com>

On Mon, 2 Jun 2025 17:34:35 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1720#issuecomment-2931835018

From zsong at openjdk.org  Mon Jun  2 17:59:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 17:59:52 GMT
Subject: Integrated: 2508: IssueNotifier should handle inactive JBS users
In-Reply-To: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
References: <nU-a_mzWLUQt9wfaHzUbGogJmf_jsYVkEr1-8K6p6fQ=.4fc66a8d-b11f-434c-a265-07fdbb1686c5@github.com>
Message-ID: <S4Q3h6GLIvnz1D4xd83uOINFlyDiTkPfSi9vz7DBq1M=.062d39c8-337f-468d-a44c-6bb184f4da87@github.com>

On Mon, 2 Jun 2025 16:04:13 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch is trying to let IssueNotifier skip setting the assignee to an inactive user, otherwise, the bot will be stuck.

This pull request has now been integrated.

Changeset: a3e7ad19
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/a3e7ad19cb7e3e6068f77942abb1d069dc5d3897
Stats:     22 lines in 1 file changed: 12 ins; 7 del; 3 mod

2508: IssueNotifier should handle inactive JBS users

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1720

From zsong at openjdk.org  Mon Jun  2 20:22:45 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 20:22:45 GMT
Subject: RFR: 2512: Update windows version in github runner [v3]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <07ZuOQxaqkYEE5D2Fu3pIFcyZ-HqVUDe2u92Qfrf38U=.628dde77-ce2d-4cf2-8064-23dd1b9c6187@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with five additional commits since the last revision:

 - Empty commit
 - update
 - update
 - update
 - update

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/3d4ac741..803061dc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=01-02

  Stats: 136 lines in 6 files changed: 128 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From zsong at openjdk.org  Mon Jun  2 20:31:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 20:31:52 GMT
Subject: RFR: 2512: Update windows version in github runner [v4]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <3i3b9lbPxujxaqwPTmtI5_76zHOArEKMDanu6A1JFnY=.fabd2a97-a9ee-44bd-9f9c-26282d61b6d2@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  update copyright

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/803061dc..de2a1e32

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=03
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From erikj at openjdk.org  Mon Jun  2 21:12:15 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 21:12:15 GMT
Subject: RFR: 2512: Update windows version in github runner [v4]
In-Reply-To: <3i3b9lbPxujxaqwPTmtI5_76zHOArEKMDanu6A1JFnY=.fabd2a97-a9ee-44bd-9f9c-26282d61b6d2@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <3i3b9lbPxujxaqwPTmtI5_76zHOArEKMDanu6A1JFnY=.fabd2a97-a9ee-44bd-9f9c-26282d61b6d2@github.com>
Message-ID: <yfwErY5-2lq3lnjNVzxlMdk9-5r_39G1ywKAgxIncns=.b60655f7-f3e6-4e9d-ab9f-38411bfc487a@github.com>

On Mon, 2 Jun 2025 20:31:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Update windows-2019 to windows-2022 in .github/ci.yml
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright

My idea was to try to execute `hg` once in `@BeforeClass` and if it failed, set a boolean to skip testcases with.

-------------

PR Review: https://git.openjdk.org/skara/pull/1721#pullrequestreview-2889948317

From zsong at openjdk.org  Mon Jun  2 21:17:59 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 21:17:59 GMT
Subject: RFR: 2512: Update windows version in github runner [v4]
In-Reply-To: <yfwErY5-2lq3lnjNVzxlMdk9-5r_39G1ywKAgxIncns=.b60655f7-f3e6-4e9d-ab9f-38411bfc487a@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <3i3b9lbPxujxaqwPTmtI5_76zHOArEKMDanu6A1JFnY=.fabd2a97-a9ee-44bd-9f9c-26282d61b6d2@github.com>
 <yfwErY5-2lq3lnjNVzxlMdk9-5r_39G1ywKAgxIncns=.b60655f7-f3e6-4e9d-ab9f-38411bfc487a@github.com>
Message-ID: <V9kq1laXwmXHdHY4emCP5QsHlEfi8HaC_2y0fnPgJ7Y=.137af865-25e4-47aa-8ae6-eef1a3292afc@github.com>

On Mon, 2 Jun 2025 21:10:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> My idea was to try to execute `hg` once in `@BeforeClass` and if it failed, set a boolean to skip testcases with.

Ah, got it. Will do

-------------

PR Comment: https://git.openjdk.org/skara/pull/1721#issuecomment-2932518713

From zsong at openjdk.org  Mon Jun  2 22:04:43 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 22:04:43 GMT
Subject: RFR: 2512: Update windows version in github runner [v5]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <32MJmybz8R1sU9NUV8l5rUbbG2wjs_e7jZ5iItWJm4w=.89b85682-77d1-496c-888a-ab14adefb434@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with two additional commits since the last revision:

 - update
 - update

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/de2a1e32..62f020af

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=04
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=03-04

  Stats: 201 lines in 6 files changed: 94 ins; 1 del; 106 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From erikj at openjdk.org  Mon Jun  2 22:48:50 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 22:48:50 GMT
Subject: RFR: 2512: Update windows version in github runner [v5]
In-Reply-To: <32MJmybz8R1sU9NUV8l5rUbbG2wjs_e7jZ5iItWJm4w=.89b85682-77d1-496c-888a-ab14adefb434@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <32MJmybz8R1sU9NUV8l5rUbbG2wjs_e7jZ5iItWJm4w=.89b85682-77d1-496c-888a-ab14adefb434@github.com>
Message-ID: <nn2hcv9qgclC3_yjUnW1yLCtYBlIAr6DNcYDY-6IUNE=.bb046ffd-800e-47f7-949e-52fe4ac5a7e6@github.com>

On Mon, 2 Jun 2025 22:04:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Update windows-2019 to windows-2022 in .github/ci.yml
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update
>  - update

Would be nice to have a test utils or something module to put this in to not have to repeat the same code 5 times, but that can wait for another time.

jcheck/src/test/java/org/openjdk/skara/jcheck/JCheckTests.java line 283:

> 281:     void checksForCommit(VCS vcs) throws Exception {
> 282:         try (var dir = new TemporaryDirectory()) {
> 283:             assumeTrue(!(vcs == VCS.HG && !hgAvailable));

Suggestion:

            assumeFalse(vcs == VCS.HG && !hgAvailable);

-------------

PR Review: https://git.openjdk.org/skara/pull/1721#pullrequestreview-2890130975
PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2122286936

From zsong at openjdk.org  Mon Jun  2 23:05:28 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 23:05:28 GMT
Subject: RFR: 2512: Update windows version in github runner [v6]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <ooiOxthW_QX2zs5zyJhTIATGAjJ9Fno5063Rytcc_hU=.373377a2-22b9-4e83-ad64-dd037050246e@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  update

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/62f020af..c8db4f16

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=05
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=04-05

  Stats: 110 lines in 4 files changed: 1 ins; 0 del; 109 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From zsong at openjdk.org  Mon Jun  2 23:13:42 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 23:13:42 GMT
Subject: RFR: 2512: Update windows version in github runner [v7]
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>

> Update windows-2019 to windows-2022 in .github/ci.yml

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  update

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1721/files
  - new: https://git.openjdk.org/skara/pull/1721/files/c8db4f16..65c25cd1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=06
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1721&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1721.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1721/head:pull/1721

PR: https://git.openjdk.org/skara/pull/1721

From erikj at openjdk.org  Mon Jun  2 23:13:42 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 2 Jun 2025 23:13:42 GMT
Subject: RFR: 2512: Update windows version in github runner [v7]
In-Reply-To: <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>
Message-ID: <5PjqzrljJZOsaUtGP1cbBrVdMXzjXMCWT9Mx_MKXwXc=.3e051688-7db0-41dd-9c86-fc4680db8af7@github.com>

On Mon, 2 Jun 2025 23:11:02 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Update windows-2019 to windows-2022 in .github/ci.yml
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

I think this looks good, but please wait for GHA to finish.

-------------

Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1721#pullrequestreview-2890166603

From zsong at openjdk.org  Mon Jun  2 23:13:42 2025
From: zsong at openjdk.org (Zhao Song)
Date: Mon, 2 Jun 2025 23:13:42 GMT
Subject: RFR: 2512: Update windows version in github runner [v7]
In-Reply-To: <5PjqzrljJZOsaUtGP1cbBrVdMXzjXMCWT9Mx_MKXwXc=.3e051688-7db0-41dd-9c86-fc4680db8af7@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>
 <5PjqzrljJZOsaUtGP1cbBrVdMXzjXMCWT9Mx_MKXwXc=.3e051688-7db0-41dd-9c86-fc4680db8af7@github.com>
Message-ID: <SOYHF1xrW0BrcwXi8uiBPUm7l7fimtBJhBXXWHrsDxk=.3b369c3e-d3cd-40c7-819b-33a0d042f1b2@github.com>

On Mon, 2 Jun 2025 23:09:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I think this looks good, but please wait for GHA to finish.

Sure, won't integrate it until GHA finished

-------------

PR Comment: https://git.openjdk.org/skara/pull/1721#issuecomment-2932824405

From zsong at openjdk.org  Tue Jun  3 00:02:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 3 Jun 2025 00:02:52 GMT
Subject: RFR: 2512: Update windows version in github runner [v7]
In-Reply-To: <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
 <rfPwTHoV29mySPAIqB3RR8lsQiPNNyEE-1ZKTIn0tOU=.a7be077e-d748-4583-8d0f-8e41dbe33e6b@github.com>
Message-ID: <Sa5IyPlNaW6wdBKJZ1jSluKUxGNenFuBlqqyEY1NGR4=.0b4c74b6-db8d-485b-aca9-ae2a9a57349a@github.com>

On Mon, 2 Jun 2025 23:13:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Update windows-2019 to windows-2022 in .github/ci.yml
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

Thank you for the suggestions and review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1721#issuecomment-2932938249

From zsong at openjdk.org  Tue Jun  3 00:02:52 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 3 Jun 2025 00:02:52 GMT
Subject: Integrated: 2512: Update windows version in github runner
In-Reply-To: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
References: <nuOhiPy27VGgpRCzc6yxtxrnTorzc8JAdxGilH9NWFA=.fe5fc23c-4823-4501-8f35-5def6a65c7d9@github.com>
Message-ID: <QHXvW37fqUZ0XpUWhMk8SxZuCXOSnQwHa6rijP6JPZk=.30b40840-e11e-488f-970d-7f7456c8dc25@github.com>

On Mon, 2 Jun 2025 16:14:31 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Update windows-2019 to windows-2022 in .github/ci.yml

This pull request has now been integrated.

Changeset: 3334f592
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/3334f5921633d2ed4acd6dc2883b08cfaaf82aec
Stats:     233 lines in 7 files changed: 222 ins; 0 del; 11 mod

2512: Update windows version in github runner

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1721

From erikj at openjdk.org  Wed Jun  4 13:07:55 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 4 Jun 2025 13:07:55 GMT
Subject: RFR: SKARA-2497-fail-mail
Message-ID: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>

The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.

I ran the manual test for this method to verify that it still works for normal operations.

-------------

Commit messages:
 - SKARA-2497-fail-mail

Changes: https://git.openjdk.org/skara/pull/1722/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1722&range=00
  Stats: 37 lines in 2 files changed: 20 ins; 15 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1722.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1722/head:pull/1722

PR: https://git.openjdk.org/skara/pull/1722

From zsong at openjdk.org  Wed Jun  4 17:00:02 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 4 Jun 2025 17:00:02 GMT
Subject: RFR: 2497: Mailing list bridge is still failing to send some
 emails
In-Reply-To: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
Message-ID: <CgyxFQ_gKsZzGkIu4pMM9IWuBMWYvX8f3DcFGj4O0FE=.a293f56c-3a35-4a40-bab2-1a4a86d751d7@github.com>

On Tue, 3 Jun 2025 22:44:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.
> 
> I ran the manual test for this method to verify that it still works for normal operations.

forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 357:

> 355:     }
> 356: 
> 357:     private RestRequest.ErrorTransform writeFilecontentsOnError(String filename, String content, Branch branch) {

writeFileContentsOnError?(with Capital 'C')

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1722#discussion_r2127052057

From erikj at openjdk.org  Wed Jun  4 17:40:50 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 4 Jun 2025 17:40:50 GMT
Subject: RFR: 2497: Mailing list bridge is still failing to send some
 emails [v2]
In-Reply-To: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
Message-ID: <16EmK_LSC98Sj4K3TKbdXbZmodQe4sICmjczvp8SMvc=.ea50eaed-f49d-4277-829e-11d7617f8227@github.com>

> The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.
> 
> I ran the manual test for this method to verify that it still works for normal operations.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Review comment

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1722/files
  - new: https://git.openjdk.org/skara/pull/1722/files/61f74b8e..4762f5d0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1722&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1722&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/skara/pull/1722.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1722/head:pull/1722

PR: https://git.openjdk.org/skara/pull/1722

From erikj at openjdk.org  Wed Jun  4 17:46:45 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 4 Jun 2025 17:46:45 GMT
Subject: RFR: 2497: Mailing list bridge is still failing to send some
 emails [v3]
In-Reply-To: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
Message-ID: <ZD-K3letcMJk_tgM0qrYJ0hlgVgn7boyGc0QJLXc8T4=.a0900488-5b32-4850-9262-c52eab615506@github.com>

> The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.
> 
> I ran the manual test for this method to verify that it still works for normal operations.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Cleaner solution

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1722/files
  - new: https://git.openjdk.org/skara/pull/1722/files/4762f5d0..21ed3db8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1722&range=02
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1722&range=01-02

  Stats: 31 lines in 1 file changed: 14 ins; 16 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1722.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1722/head:pull/1722

PR: https://git.openjdk.org/skara/pull/1722

From erikj at openjdk.org  Wed Jun  4 17:46:45 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 4 Jun 2025 17:46:45 GMT
Subject: RFR: 2497: Mailing list bridge is still failing to send some
 emails [v3]
In-Reply-To: <CgyxFQ_gKsZzGkIu4pMM9IWuBMWYvX8f3DcFGj4O0FE=.a293f56c-3a35-4a40-bab2-1a4a86d751d7@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
 <CgyxFQ_gKsZzGkIu4pMM9IWuBMWYvX8f3DcFGj4O0FE=.a293f56c-3a35-4a40-bab2-1a4a86d751d7@github.com>
Message-ID: <aVCWcF5pzkTINjSpUixJJ6_dmn7a2w5ZnT-WGIH0mKQ=.9fa37cd1-c5b2-4f7c-b828-81be3000fb5c@github.com>

On Wed, 4 Jun 2025 16:57:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleaner solution
>
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 357:
> 
>> 355:     }
>> 356: 
>> 357:     private RestRequest.ErrorTransform writeFilecontentsOnError(String filename, String content, Branch branch) {
> 
> writeFileContentsOnError?(with Capital 'C')

Looking at this again, having a separate method is unnecessary. I was a bit too quick refactoring this yesterday. Just creating a local instance of the lambda seems better.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1722#discussion_r2127124682

From zsong at openjdk.org  Wed Jun  4 18:20:17 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 4 Jun 2025 18:20:17 GMT
Subject: RFR: 2497: Mailing list bridge is still failing to send some
 emails [v3]
In-Reply-To: <ZD-K3letcMJk_tgM0qrYJ0hlgVgn7boyGc0QJLXc8T4=.a0900488-5b32-4850-9262-c52eab615506@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
 <ZD-K3letcMJk_tgM0qrYJ0hlgVgn7boyGc0QJLXc8T4=.a0900488-5b32-4850-9262-c52eab615506@github.com>
Message-ID: <uMoL1p9V2bnUP_MbzjN21Ixvzjg5qz9Dt6wI2SThHdw=.0c8e7d4e-67d9-48b9-9223-615ea7f5542c@github.com>

On Wed, 4 Jun 2025 17:46:45 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.
>> 
>> I ran the manual test for this method to verify that it still works for normal operations.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleaner solution

Looks good

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1722#pullrequestreview-2897686923

From erikj at openjdk.org  Thu Jun  5 13:23:21 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 5 Jun 2025 13:23:21 GMT
Subject: Integrated: 2497: Mailing list bridge is still failing to send some
 emails
In-Reply-To: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
References: <QzHTSW-sbZyirzOZF0m15xAX9ZmTBQ9xFjTdenyb5zI=.804da865-dc7b-4abe-871a-2eb9308dbeae@github.com>
Message-ID: <5Yxw0nWCF3RlJYdyNL6H9yylye9eXjPMkGGg4EnFk34=.0b04bd2e-2446-45b7-bb39-d858be482b42@github.com>

On Tue, 3 Jun 2025 22:44:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The fix in [SKARA-2470](https://bugs.openjdk.org/browse/SKARA-2470) seems to have been successful. However, the fix was only applied to the PUT operation, which is used when updating the archive with additional emails, not the POST which is used for the initial email.
> 
> I ran the manual test for this method to verify that it still works for normal operations.

This pull request has now been integrated.

Changeset: d27f01f9
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/d27f01f9cdf0a06a0d1a20b05165a6ded8e48dbb
Stats:     35 lines in 2 files changed: 18 ins; 15 del; 2 mod

2497: Mailing list bridge is still failing to send some emails

Reviewed-by: zsong

-------------

PR: https://git.openjdk.org/skara/pull/1722