RFR: 2512: Update windows version in github runner [v5]

Erik Joelsson erikj at openjdk.org
Mon Jun 2 22:48:50 UTC 2025


On Mon, 2 Jun 2025 22:04:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Update windows-2019 to windows-2022 in .github/ci.yml
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update
>  - update

Would be nice to have a test utils or something module to put this in to not have to repeat the same code 5 times, but that can wait for another time.

jcheck/src/test/java/org/openjdk/skara/jcheck/JCheckTests.java line 283:

> 281:     void checksForCommit(VCS vcs) throws Exception {
> 282:         try (var dir = new TemporaryDirectory()) {
> 283:             assumeTrue(!(vcs == VCS.HG && !hgAvailable));

Suggestion:

            assumeFalse(vcs == VCS.HG && !hgAvailable);

-------------

PR Review: https://git.openjdk.org/skara/pull/1721#pullrequestreview-2890130975
PR Review Comment: https://git.openjdk.org/skara/pull/1721#discussion_r2122286936


More information about the skara-dev mailing list