RFR: 2497: Mailing list bridge is still failing to send some emails [v3]

Erik Joelsson erikj at openjdk.org
Wed Jun 4 17:46:45 UTC 2025


On Wed, 4 Jun 2025 16:57:52 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleaner solution
>
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 357:
> 
>> 355:     }
>> 356: 
>> 357:     private RestRequest.ErrorTransform writeFilecontentsOnError(String filename, String content, Branch branch) {
> 
> writeFileContentsOnError?(with Capital 'C')

Looking at this again, having a separate method is unnecessary. I was a bit too quick refactoring this yesterday. Just creating a local instance of the lambda seems better.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1722#discussion_r2127124682


More information about the skara-dev mailing list