RFR: 2451: Skara bot fails to transition bug to Resolved due to empty response from api [v2]

[Erik Joelsson]

On Mon, 3 Mar 2025 18:56:35 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that one backport issue was not automatically resolved by the Skara bot. From the logs, Erik found that the bot didn't actually send the request to transition the bug to resolved and he noticed that around that time, the bot was renewing the access token for jbs.
>> 
>> When updating the state of an issue, the Skara bot first attempts to fetch the available transitions for that issue by calling this API:
>> https://bugs.openjdk.org/rest/api/2/issue/issue_id/transitions.
>> 
>> I called the API without authentication, I was expecting a 401 Unauthorized response. However, I received an empty response:
>> `{"expand":"transitions","transitions":[]}.`
>> 
>> Due to this empty response, the Skara bot did not attempt to transition the bug to any state.
>> 
>> In my opinion, availableTransitions would be empty only when requesting the API without authentication,  so skara bot would throw an exception in this case.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
>   
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1706#pullrequestreview-2655259401