RFR: 2454: Skara mistakenly marked a non-clean backport as clean [v4]
Zhao Song
zsong at openjdk.org
Thu Mar 13 17:20:35 UTC 2025
> A user reported that Skara bot mistakenly marked a non-clean backport as clean. After investigation, I found that the PR was too large for the remote host to return the entire diff. The PR contained 8082 changed files, but when Skara bot requested the diff, only 3000 files were returned. Therefore, Skara bot was unable to compare some patches, so mistakenly mark the pr as clean.
>
> In this patch, Skara bot will now check if the PR is too large to evaluate. If it is, Skara bot will not evaluate if this PR is clean and will add a warning comment to the PR instead.
Zhao Song has updated the pull request incrementally with three additional commits since the last revision:
- Update forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update vcs/src/main/java/org/openjdk/skara/vcs/Diff.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1708/files
- new: https://git.openjdk.org/skara/pull/1708/files/775e2944..e71b6bd2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1708&range=03
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1708&range=02-03
Stats: 14 lines in 3 files changed: 0 ins; 9 del; 5 mod
Patch: https://git.openjdk.org/skara/pull/1708.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1708/head:pull/1708
PR: https://git.openjdk.org/skara/pull/1708
More information about the skara-dev
mailing list