RFR: 2454: Skara mistakenly marked a non-clean backport as clean [v5]

Zhao Song zsong at openjdk.org
Thu Mar 13 17:53:27 UTC 2025


> A user reported that Skara bot mistakenly marked a non-clean backport as clean. After investigation, I found that the PR was too large for the remote host to return the entire diff. The PR contained 8082 changed files, but when Skara bot requested the diff, only 3000 files were returned. Therefore, Skara bot was unable to compare some patches, so mistakenly mark the pr as clean.
> 
> In this patch, Skara bot will now check if the PR is too large to evaluate. If it is, Skara bot will not evaluate if this PR is clean and will add a warning comment to the PR instead.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  fix a typo

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1708/files
  - new: https://git.openjdk.org/skara/pull/1708/files/e71b6bd2..00a69dc2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1708&range=04
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1708&range=03-04

  Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/skara/pull/1708.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1708/head:pull/1708

PR: https://git.openjdk.org/skara/pull/1708


More information about the skara-dev mailing list