RFR: 2454: Skara mistakenly marked a non-clean backport as clean [v5]
Erik Joelsson
erikj at openjdk.org
Thu Mar 13 21:04:20 UTC 2025
On Thu, 13 Mar 2025 17:53:27 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> A user reported that Skara bot mistakenly marked a non-clean backport as clean. After investigation, I found that the PR was too large for the remote host to return the entire diff. The PR contained 8082 changed files, but when Skara bot requested the diff, only 3000 files were returned. Therefore, Skara bot was unable to compare some patches, so mistakenly mark the pr as clean.
>>
>> In this patch, Skara bot will now check if the PR is too large to evaluate. If it is, Skara bot will not evaluate if this PR is clean and will add a warning comment to the PR instead.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> fix a typo
Marked as reviewed by erikj (Lead).
-------------
PR Review: https://git.openjdk.org/skara/pull/1708#pullrequestreview-2683353590
More information about the skara-dev
mailing list