RFR: 2466: Cut down list of other commits from 10 to 3
Erik Joelsson
erikj at openjdk.org
Tue Mar 25 17:32:43 UTC 2025
On Tue, 25 Mar 2025 16:29:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Skara prints a list of other commits that has been integrated before a PR is automatically rebased. I think the idea was to put transparency to the rebasing process, but in actuality it only adds noise.
>
> I think it could be removed entirely (in general, I think the Skara bot messages are *waaaay* to chatty), but as a start, it the list could be shortened radically. I chose 3 as the lowest number that is still a "crowd".
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 52:
> 50: class CheckRun {
> 51: public static final String MSG_EMPTY_BODY = "The pull request body must not be empty.";
> 52: private static final int COMMIT_LIST_LIMIT = 3;
I think we should share this constant between these two classes.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1710#discussion_r2012595837
More information about the skara-dev
mailing list