RFR: 2466: Cut down list of other commits from 10 to 3

[Magnus Ihse Bursie]

On Tue, 25 Mar 2025 17:29:59 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Skara prints a list of other commits that has been integrated before a PR is automatically rebased. I think the idea was to put transparency to the rebasing process, but in actuality it only adds noise.
>> 
>> I think it could be removed entirely (in general, I think the Skara bot messages are *waaaay* to chatty), but as a start, it the list could be shortened radically. I chose 3 as the lowest number that is still a "crowd".
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 52:
> 
>> 50: class CheckRun {
>> 51:     public static final String MSG_EMPTY_BODY = "The pull request body must not be empty.";
>> 52:     private static final int COMMIT_LIST_LIMIT = 3;
> 
> I think we should share this constant between these two classes.

That sounds good. Where should I place it? I did not want to introduce a dependency between the two classes since I did not know how they relate.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1710#discussion_r2013815778