RFR: 2480: Add new PR command /ping [v3]

[Magnus Ihse Bursie]

On Wed, 30 Apr 2025 22:44:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This PR is trying to add a new pull request command "ping".
>> 
>> The reported wants to have a pull request command that can refresh the timeouts of the pr so that the pr wouldn't be closed by pullRequestPrunerBot.
>>  
>> The reported proposed to name the command "keep-alive" with alias "/ping", however, we store command names in an Enum class, so "keep-alive" is invalid. I think we just use "ping" as the command name.
>> 
>> Besides, I would like to let the command trigger a force update of the pr. Currently, there are some cases that skara bot won't re-evaluate the pr automatically and users need to do something to poke it(like editing the pr title), so I think it's better to have a pull request command to trigger the update.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

I agree with Erik that `/touch` would be a better name. The name `ping` to me indicates that you want to ask for reviewers or re-reviews, not that you want to silence the bot. If anything, that would have been a "pong" to the bot's ping. Or `/keepalive`, if dashes are problematic.

Can you also please update the comment the bot writes to indicate that the recommended action is to write `/touch` (or `/keepalive`)? Also, if it is possible to create a link such that clicking it will start writing this as a comment for you, that would be even better. Or, at least, make it easy to copy/paste the needed command.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1716#issuecomment-2850517624
PR Comment: https://git.openjdk.org/skara/pull/1716#issuecomment-2850522348