RFR: 2491: GitLabRepository::recentCommitComments can miss commits

[Zhao Song]

On Mon, 5 May 2025 17:47:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 647:
>> 
>>> 645:             Set<Branch> branchSet = Set.copyOf(branches);
>>> 646:             if (!branchSet.equals(commitMapBranchSet)) {
>>> 647:                 log.info("Invalidating commitTitleToCommits map for branch set: " + branchSet + " old set: " + commitMapBranchSet);
>> 
>> Since commitMapBranchSet doesn't have an initial value, this log will also be printed during the initial run. Is this intentional?
>
> Yes, kind of. I did note that it would happen and figured it was fine. I don't think it's worth complicating the code further to try to handle the first call differently.

I'm also ok with it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1717#discussion_r2073905841