From zsong at openjdk.org  Tue Nov 25 17:42:10 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 25 Nov 2025 17:42:10 GMT
Subject: RFR: 2628: jdk mailinglist configuration is missing some hotspot
 directories
Message-ID: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>

Suggestions from Kim Barrett

precompiled - add to hotspot component
sanitizers - add to runtime component
cppstdlib - add to hotspot component
metaprogramming - add to hotspot component

-------------

Commit messages:
 - SKARA-2628

Changes: https://git.openjdk.org/skara/pull/1744/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1744&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2628
  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/skara/pull/1744.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1744/head:pull/1744

PR: https://git.openjdk.org/skara/pull/1744

From erikj at openjdk.org  Tue Nov 25 18:48:09 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 25 Nov 2025 18:48:09 GMT
Subject: RFR: 2628: jdk mailinglist configuration is missing some hotspot
 directories
In-Reply-To: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
References: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
Message-ID: <z8im8_jC37Nsod7CRqtVPxfmd4m7wNMoE5pWe1rZwRY=.82b64933-04e3-4ffe-90ab-67ff153da892@github.com>

On Tue, 25 Nov 2025 17:17:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Suggestions from Kim Barrett
> 
> precompiled - add to hotspot component
> sanitizers - add to runtime component
> cppstdlib - add to hotspot component
> metaprogramming - add to hotspot component

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1744#pullrequestreview-3506388850

From iris at openjdk.org  Tue Nov 25 18:53:17 2025
From: iris at openjdk.org (Iris Clark)
Date: Tue, 25 Nov 2025 18:53:17 GMT
Subject: RFR: 2628: jdk mailinglist configuration is missing some hotspot
 directories
In-Reply-To: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
References: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
Message-ID: <eMCCF6CtsQpif4WhsbwfmgymK-uZacVIyfF5Mpkyivk=.93f6817b-00e6-456f-b7af-fa4ca35f0353@github.com>

On Tue, 25 Nov 2025 17:17:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Suggestions from Kim Barrett
> 
> precompiled - add to hotspot component
> sanitizers - add to runtime component
> cppstdlib - add to hotspot component
> metaprogramming - add to hotspot component

Marked as reviewed by iris (no project role).

-------------

PR Review: https://git.openjdk.org/skara/pull/1744#pullrequestreview-3506405357

From zsong at openjdk.org  Tue Nov 25 18:57:29 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 25 Nov 2025 18:57:29 GMT
Subject: RFR: 2628: jdk mailinglist configuration is missing some hotspot
 directories
In-Reply-To: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
References: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
Message-ID: <QAReyZVXtsudFlgTSIaLd7sdWv3jem8mA9WYX4fYq2k=.747f8570-2647-4f77-b465-1139f9ce2a22@github.com>

On Tue, 25 Nov 2025 17:17:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Suggestions from Kim Barrett
> 
> precompiled - add to hotspot component
> sanitizers - add to runtime component
> cppstdlib - add to hotspot component
> metaprogramming - add to hotspot component

Thank you for the reviews!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1744#issuecomment-3577105221

From zsong at openjdk.org  Tue Nov 25 18:57:29 2025
From: zsong at openjdk.org (Zhao Song)
Date: Tue, 25 Nov 2025 18:57:29 GMT
Subject: Integrated: 2628: jdk mailinglist configuration is missing some
 hotspot directories
In-Reply-To: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
References: <nWmezn1EmOhm6pdXAFglU1sBwmDiXEF-Ha3G5fcFcUA=.fbe058c4-bec5-446d-a669-f92e9374dcf4@github.com>
Message-ID: <IuT4G0sHVcwOQBdS5UV2q6yM4QIO75WXxTI4zohRy1s=.d8e11d83-5d44-4e29-a12e-8b438ff7b7ad@github.com>

On Tue, 25 Nov 2025 17:17:23 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Suggestions from Kim Barrett
> 
> precompiled - add to hotspot component
> sanitizers - add to runtime component
> cppstdlib - add to hotspot component
> metaprogramming - add to hotspot component

This pull request has now been integrated.

Changeset: f40ab45c
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/f40ab45c9587485f4e776e2ba430eb5b9ada65a5
Stats:     4 lines in 1 file changed: 4 ins; 0 del; 0 mod

2628: jdk mailinglist configuration is missing some hotspot directories

Reviewed-by: erikj, iris

-------------

PR: https://git.openjdk.org/skara/pull/1744

From erikj at openjdk.org  Tue Nov 25 19:14:54 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 25 Nov 2025 19:14:54 GMT
Subject: RFR: 2610: Mailman 3 support
Message-ID: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>

The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes

### 1. REST API
The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 

The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 

### 2. Mbox format
The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.

Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 

An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.

This is a big patch, so sorry in advance.

-------------

Commit messages:
 - Fix whitespace
 - Better query strategy for mailman3
 - cleanup
 - Decode emails bodies
 - Parse new mbox format
 - MailingListNotifier config does not need archive
 - Bot factory support for different archive types
 - Tests are passing
 - Refactored TestMailmanServer to prepare for V3 variant

Changes: https://git.openjdk.org/skara/pull/1743/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1743&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2610
  Stats: 1449 lines in 23 files changed: 1059 ins; 233 del; 157 mod
  Patch: https://git.openjdk.org/skara/pull/1743.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1743/head:pull/1743

PR: https://git.openjdk.org/skara/pull/1743

From zsong at openjdk.org  Wed Nov 26 21:11:39 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 26 Nov 2025 21:11:39 GMT
Subject: RFR: 2610: Mailman 3 support
In-Reply-To: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
Message-ID: <w9fwUwTxOK8raHqNdUOsPG_rsLbs3pa2sFape6seVjY=.3aff540c-dda0-4925-bc5d-5086a01abff6@github.com>

On Fri, 21 Nov 2025 23:14:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
> 
> ### 1. REST API
> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 
> 
> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 
> 
> ### 2. Mbox format
> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
> 
> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 
> 
> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
> 
> This is a big patch, so sorry in advance.

Looks good.
Just have 2 minor questions.

bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java line 199:

> 197:         MailingListServer mailmanServer;
> 198:         if (archiveType == null || archiveType.equals("mailman2")) {
> 199:             mailmanServer = MailingListServerFactory.createMailman2Server(listArchive, listSmtp, Duration.ZERO, useEtag);

Previously, we set the interval in configuration file and the value is not 0, why do we set it to 0 by default now?

mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanListReader.java line 223:

> 221:                 var mboxUri = URIBuilder.base(server.getArchiveUri()).appendPath("list/").appendPath(name)
> 222:                         .appendPath("@").appendPath(server.getArchiveUri().getHost())
> 223:                         .appendPath("/export/foo.mbox.gz").setQuery(query).build();

This looks a bit weird, seems like we are downloading it instead of reading it, is it because if we just read it, the files are not in mbox format?

-------------

PR Review: https://git.openjdk.org/skara/pull/1743#pullrequestreview-3507550420
PR Review Comment: https://git.openjdk.org/skara/pull/1743#discussion_r2562105795
PR Review Comment: https://git.openjdk.org/skara/pull/1743#discussion_r2566490377

From erikj at openjdk.org  Wed Nov 26 22:07:20 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 26 Nov 2025 22:07:20 GMT
Subject: RFR: 2610: Mailman 3 support
In-Reply-To: <w9fwUwTxOK8raHqNdUOsPG_rsLbs3pa2sFape6seVjY=.3aff540c-dda0-4925-bc5d-5086a01abff6@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <w9fwUwTxOK8raHqNdUOsPG_rsLbs3pa2sFape6seVjY=.3aff540c-dda0-4925-bc5d-5086a01abff6@github.com>
Message-ID: <o9rbKwgx0XW_qSiF6FsqjTGegl2Ut96kE05Nr7yic2o=.e3398748-719f-438d-8efd-0bc222d03045@github.com>

On Wed, 26 Nov 2025 00:23:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
>> 
>> ### 1. REST API
>> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 
>> 
>> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 
>> 
>> ### 2. Mbox format
>> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
>> 
>> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 
>> 
>> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
>> 
>> This is a big patch, so sorry in advance.
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java line 199:
> 
>> 197:         MailingListServer mailmanServer;
>> 198:         if (archiveType == null || archiveType.equals("mailman2")) {
>> 199:             mailmanServer = MailingListServerFactory.createMailman2Server(listArchive, listSmtp, Duration.ZERO, useEtag);
> 
> Previously, we set the interval in configuration file and the value is not 0, why do we set it to 0 by default now?

You are right, this was a mistake. In the old code, the MailmanServer created in this class still got Duration.ZERO, see line 104, but the bot itself received a `sendInterval` parameter from the configuration. That parameter was in turn used in ArchiveWorkItem to create a new MailmanServer instance which was used to send email. I got rid of that instance creation in ArchiveWorkItem, but that also means we should pick up the configured interval and set that here. Good catch!

> mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanListReader.java line 223:
> 
>> 221:                 var mboxUri = URIBuilder.base(server.getArchiveUri()).appendPath("list/").appendPath(name)
>> 222:                         .appendPath("@").appendPath(server.getArchiveUri().getHost())
>> 223:                         .appendPath("/export/foo.mbox.gz").setQuery(query).build();
> 
> This looks a bit weird, seems like we are downloading it instead of reading it, is it because if we just read it, the files are not in mbox format?

This is the URL I found in the test server we have running internally. There are download links in the UI which I modified to our needs. Not sure what you mean with downloading vs reading. The "foo" part can be anything you like as it will translate to a filename when using the URL in a browser.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1743#discussion_r2566591810
PR Review Comment: https://git.openjdk.org/skara/pull/1743#discussion_r2566596724

From erikj at openjdk.org  Wed Nov 26 22:25:26 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 26 Nov 2025 22:25:26 GMT
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
Message-ID: <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>

> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
> 
> ### 1. REST API
> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 
> 
> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 
> 
> ### 2. Mbox format
> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
> 
> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 
> 
> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
> 
> This is a big patch, so sorry in advance.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Restored send interval

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1743/files
  - new: https://git.openjdk.org/skara/pull/1743/files/e301943b..6e5f6cae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1743&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1743&range=00-01

  Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1743.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1743/head:pull/1743

PR: https://git.openjdk.org/skara/pull/1743

From zsong at openjdk.org  Wed Nov 26 22:25:26 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 26 Nov 2025 22:25:26 GMT
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <o9rbKwgx0XW_qSiF6FsqjTGegl2Ut96kE05Nr7yic2o=.e3398748-719f-438d-8efd-0bc222d03045@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <w9fwUwTxOK8raHqNdUOsPG_rsLbs3pa2sFape6seVjY=.3aff540c-dda0-4925-bc5d-5086a01abff6@github.com>
 <o9rbKwgx0XW_qSiF6FsqjTGegl2Ut96kE05Nr7yic2o=.e3398748-719f-438d-8efd-0bc222d03045@github.com>
Message-ID: <_WPs7WKHdxOJPUjHoQoRNVrbkK3Ca_GvZapf6lv0bQo=.54dd2366-d84d-494b-81f6-233729e5cb33@github.com>

On Wed, 26 Nov 2025 22:04:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> mailinglist/src/main/java/org/openjdk/skara/mailinglist/mailman/MailmanListReader.java line 223:
>> 
>>> 221:                 var mboxUri = URIBuilder.base(server.getArchiveUri()).appendPath("list/").appendPath(name)
>>> 222:                         .appendPath("@").appendPath(server.getArchiveUri().getHost())
>>> 223:                         .appendPath("/export/foo.mbox.gz").setQuery(query).build();
>> 
>> This looks a bit weird, seems like we are downloading it instead of reading it, is it because if we just read it, the files are not in mbox format?
>
> This is the URL I found in the test server we have running internally. There are download links in the UI which I modified to our needs. Not sure what you mean with downloading vs reading. The "foo" part can be anything you like as it will translate to a filename when using the URL in a browser.

NVM, I am ok with this.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1743#discussion_r2566608455

From zsong at openjdk.org  Wed Nov 26 22:39:57 2025
From: zsong at openjdk.org (Zhao Song)
Date: Wed, 26 Nov 2025 22:39:57 GMT
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
Message-ID: <ytrZBkU40M1e1jVJSkGLTwWU3_2fR9PcEf3dGMg1QrU=.c7b1992d-f4a4-4097-a38d-4d2fc5f15d17@github.com>

On Wed, 26 Nov 2025 22:25:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
>> 
>> ### 1. REST API
>> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 
>> 
>> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 
>> 
>> ### 2. Mbox format
>> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
>> 
>> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 
>> 
>> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
>> 
>> This is a big patch, so sorry in advance.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restored send interval

Marked as reviewed by zsong (Reviewer).

-------------

PR Review: https://git.openjdk.org/skara/pull/1743#pullrequestreview-3512957466

From erikj at openjdk.org  Wed Nov 26 22:53:00 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 26 Nov 2025 22:53:00 GMT
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
Message-ID: <mnclaQBjDU_JSqCujBrbDCsQAap37ZuXa8BrLqJ7xEA=.0ab37e35-4a4b-4d11-aeb7-185493b259c1@github.com>

On Wed, 26 Nov 2025 22:25:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
>> 
>> ### 1. REST API
>> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more. 
>> 
>> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates. 
>> 
>> ### 2. Mbox format
>> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
>> 
>> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details. 
>> 
>> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
>> 
>> This is a big patch, so sorry in advance.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restored send interval

Thanks! I will wait until next week before integrating this.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1743#issuecomment-3583469355

From erik.joelsson at oracle.com  Wed Nov 26 23:10:46 2025
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Wed, 26 Nov 2025 15:10:46 -0800
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <mnclaQBjDU_JSqCujBrbDCsQAap37ZuXa8BrLqJ7xEA=.0ab37e35-4a4b-4d11-aeb7-185493b259c1@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
 <mnclaQBjDU_JSqCujBrbDCsQAap37ZuXa8BrLqJ7xEA=.0ab37e35-4a4b-4d11-aeb7-185493b259c1@github.com>
Message-ID: <b2988597-f2f2-4ba0-808f-4f225e4aa6d3@oracle.com>

Test email response with this patch running against the Skara repository.

/Erik

On 11/26/25 14:53, Erik Joelsson wrote:
> On Wed, 26 Nov 2025 22:25:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>
>>> The OpenJDK mail archive will move to Mailman 3 at some point in the future. To prepare for that, Skara needs to be made Mailman 3 compatible, specifically for reading emails from the archive to be able to publish them as comments in PRs. There are two major changes
>>>
>>> ### 1. REST API
>>> The REST API for reading mbox archives is different. It's a lot better in Mailman3. Instead of having to read in fixed monthly chunks, we can request a custom date interval. The data is also returned gzipped instead of in plain text. To retain backwards compatibility, I chose to implement the Mailman 2 and 3 support as subclasses with some shared implementation. This caused a lot of mechanical changes in tests, just updating method names or signatures since the API for creating a Mailman server object changes. It also forced some cleanup in bots where MailmanServer objects were created unnecessarily. I updated some tests to use the Mailman3 implementation where possible to exercise the new code more.
>>>
>>> The new implementation is somewhat taking advantage of the new capabilities in the API, but it could maybe be done more efficiently when polling for updates.
>>>
>>> ### 2. Mbox format
>>> The format of the mail bodies in the returned mbox format is quite different. It's now MIME encoded and can be encoded in a few different ways ("7bit", "8bit" and "quoted-printable" have been observed so far). I've tried to implement support for decoding all the ways I've so far observed.
>>>
>>> Some examples of this patch in action can be found in https://github.com/openjdk/playground/pull/246. Note that the earlier comments have problems that eventually got resolved as I ironed out the details.
>>>
>>> An observation I've made is that the new server introduces hard line breaks in emails as they are archived. Those are visible already when browsing the archive. I'm not sure if this is a setting in Mailman itself or not. Those line breaks are not part of the email I received when subscribing to a list, just in the archive, and so also in any comments posted by Skara.
>>>
>>> This is a big patch, so sorry in advance.
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>>    Restored send interval
> Thanks! I will wait until next week before integrating this.
>
> -------------
>
> PR Comment: https://git.openjdk.org/skara/pull/1743#issuecomment-3583469355

From erikj at openjdk.org  Wed Nov 26 23:14:53 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Wed, 26 Nov 2025 23:14:53 GMT
Subject: RFR: 2610: Mailman 3 support [v2]
In-Reply-To: <mnclaQBjDU_JSqCujBrbDCsQAap37ZuXa8BrLqJ7xEA=.0ab37e35-4a4b-4d11-aeb7-185493b259c1@github.com>
References: <0_8bnwSGe0yaGssu8cS2faqUa9AkpHodGzFf57sG71Y=.ac496be8-f6ed-473d-9dea-a4e40855069b@github.com>
 <unki4xWeC9aGrzZRkL8pBIZiwRz8nJ0AIozdMGAUCDc=.4769b361-86c7-4d16-a789-db0581931aae@github.com>
 <mnclaQBjDU_JSqCujBrbDCsQAap37ZuXa8BrLqJ7xEA=.0ab37e35-4a4b-4d11-aeb7-185493b259c1@github.com>
Message-ID: <d1CA7AujRiMYjbNqNXg5RR2F6KgLR2_-i92lDXjVSDA=.1f2a0ea3-643e-4911-a138-b22bf55bce52@github.com>

On Wed, 26 Nov 2025 22:50:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Thanks! I will wait until next week before integrating this.

Test response on Github with this patch running on the Skara repo.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1743#issuecomment-3583507588