From zsong at openjdk.org  Thu Sep  4 20:24:01 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 4 Sep 2025 20:24:01 GMT
Subject: RFR: 2544: SKARA bot ignores GitHub comments in some cases
Message-ID: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>

When querying pull requests in GitHub, we should query all the pull requests instead of the first page, otherwise, in some cases, some prs will be ignored.

-------------

Commit messages:
 - SKARA-2544

Changes: https://git.openjdk.org/skara/pull/1736/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1736&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2544
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/skara/pull/1736.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1736/head:pull/1736

PR: https://git.openjdk.org/skara/pull/1736

From erikj at openjdk.org  Thu Sep  4 20:33:07 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 4 Sep 2025 20:33:07 GMT
Subject: RFR: 2544: SKARA bot ignores GitHub comments in some cases
In-Reply-To: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
References: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
Message-ID: <irKjDu1bddwIyk35MqXzuGEFU4EFEucY8HEzE7kUyZs=.d2283764-ca12-4e70-b9b4-eede44367a04@github.com>

On Thu, 4 Sep 2025 20:18:00 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When querying pull requests in GitHub, we should query all the pull requests instead of the first page, otherwise, in some cases, some prs will be ignored.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1736#pullrequestreview-3187150414

From zsong at openjdk.org  Thu Sep  4 20:37:35 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 4 Sep 2025 20:37:35 GMT
Subject: RFR: 2544: SKARA bot ignores GitHub comments in some cases
In-Reply-To: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
References: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
Message-ID: <OUBgBgkXmhx6KUtsse_gUmvO1adGVn01QPOi40umHqY=.dc09c665-a0c3-4b46-b28d-6754c9b0c1b6@github.com>

On Thu, 4 Sep 2025 20:18:00 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When querying pull requests in GitHub, we should query all the pull requests instead of the first page, otherwise, in some cases, some prs will be ignored.

Thank you for the quick review!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1736#issuecomment-3255546458

From zsong at openjdk.org  Thu Sep  4 20:37:35 2025
From: zsong at openjdk.org (Zhao Song)
Date: Thu, 4 Sep 2025 20:37:35 GMT
Subject: Integrated: 2544: SKARA bot ignores GitHub comments in some cases
In-Reply-To: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
References: <4CGEygx0feV7nJrM8GZJ16dQ6DbDL1JnScu1v41OB34=.7a39a3b2-8d75-4e03-bfcf-912a522566a1@github.com>
Message-ID: <7i8LYYBP-Yohhg0NAHZ5CRzK1midDY3NQLOcxZP9dKI=.e3710a2c-cbfa-431a-bfd9-7258db602ec6@github.com>

On Thu, 4 Sep 2025 20:18:00 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When querying pull requests in GitHub, we should query all the pull requests instead of the first page, otherwise, in some cases, some prs will be ignored.

This pull request has now been integrated.

Changeset: 3d24e1aa
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/3d24e1aad2e7f392134cf368765534ebb49ba60a
Stats:     2 lines in 1 file changed: 0 ins; 2 del; 0 mod

2544: SKARA bot ignores GitHub comments in some cases

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1736

From erikj at openjdk.org  Fri Sep  5 20:10:58 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 5 Sep 2025 20:10:58 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments
Message-ID: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>

The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.

I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.

-------------

Commit messages:
 - New attempt
 - SKARA-2576

Changes: https://git.openjdk.org/skara/pull/1737/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1737&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2576
  Stats: 24 lines in 1 file changed: 16 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/skara/pull/1737.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1737/head:pull/1737

PR: https://git.openjdk.org/skara/pull/1737

From zsong at openjdk.org  Fri Sep  5 20:14:58 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 5 Sep 2025 20:14:58 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments
In-Reply-To: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
Message-ID: <MEKyS-yd_lUXn1WRTMibYwW9lZig71E_uI9f7bNCQtM=.edd5464b-e335-4761-806a-691560fe289c@github.com>

On Fri, 5 Sep 2025 14:27:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
> 
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.

Looks good!

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1737#pullrequestreview-3190657167

From erikj at openjdk.org  Fri Sep  5 21:10:58 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 5 Sep 2025 21:10:58 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments [v2]
In-Reply-To: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
Message-ID: <rUByyvzte7tCvfuhGnnsB6_cPatW2rPahIe5ks7KypA=.7b53d281-41b4-4ab6-8823-99c8f581327c@github.com>

> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
> 
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.

Erik Joelsson has updated the pull request incrementally with two additional commits since the last revision:

 - More adjustment
 - Adjusted logging

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1737/files
  - new: https://git.openjdk.org/skara/pull/1737/files/82f1cd53..315f40b8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1737&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1737&range=00-01

  Stats: 7 lines in 1 file changed: 2 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1737.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1737/head:pull/1737

PR: https://git.openjdk.org/skara/pull/1737

From erikj at openjdk.org  Fri Sep  5 21:10:58 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 5 Sep 2025 21:10:58 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments
In-Reply-To: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
Message-ID: <izqzf-2sdlXLErmJ5aOSU6CNzUPs3mxxhZK_TJTSpew=.7802346e-7074-4ce0-8464-dfd579726610@github.com>

On Fri, 5 Sep 2025 14:27:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
> 
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.

Updated the logging a bit after trying this in staging. It looks like it's working correctly now.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1737#issuecomment-3259747013

From zsong at openjdk.org  Fri Sep  5 21:12:23 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 5 Sep 2025 21:12:23 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments
In-Reply-To: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
Message-ID: <nrlU11W-xY60WEGiKSIx--ziX1q9QCll3eaXzPJpwdo=.50cd779b-931d-47a7-b139-1f95e22f12a8@github.com>

On Fri, 5 Sep 2025 14:27:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
> 
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.

So what was the issue with the previous commit?

-------------

PR Comment: https://git.openjdk.org/skara/pull/1737#issuecomment-3259757374

From zsong at openjdk.org  Fri Sep  5 21:20:05 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 5 Sep 2025 21:20:05 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments
In-Reply-To: <nrlU11W-xY60WEGiKSIx--ziX1q9QCll3eaXzPJpwdo=.50cd779b-931d-47a7-b139-1f95e22f12a8@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
 <nrlU11W-xY60WEGiKSIx--ziX1q9QCll3eaXzPJpwdo=.50cd779b-931d-47a7-b139-1f95e22f12a8@github.com>
Message-ID: <r4x3XGmQ8J6wVeinKvMzUwRSMT7H9_8YKwIMvRHrpMo=.11de69cb-d6c6-4243-b372-b6ac4624686c@github.com>

On Fri, 5 Sep 2025 21:10:16 GMT, Zhao Song <zsong at openjdk.org> wrote:

> So what was the issue with the previous commit?

I see, previous one always update previousUpdatedAt

-------------

PR Comment: https://git.openjdk.org/skara/pull/1737#issuecomment-3259774551

From zsong at openjdk.org  Fri Sep  5 21:25:07 2025
From: zsong at openjdk.org (Zhao Song)
Date: Fri, 5 Sep 2025 21:25:07 GMT
Subject: RFR: 2576: Bots still ignore GitHub comments [v2]
In-Reply-To: <rUByyvzte7tCvfuhGnnsB6_cPatW2rPahIe5ks7KypA=.7b53d281-41b4-4ab6-8823-99c8f581327c@github.com>
References: <ybRZm3oeiZ3MLw_cyXKD-TRW32gZLmb6mOWFZy0h0P4=.861c9d4a-fcc7-4c0d-8e2b-8282eee44287@github.com>
 <rUByyvzte7tCvfuhGnnsB6_cPatW2rPahIe5ks7KypA=.7b53d281-41b4-4ab6-8823-99c8f581327c@github.com>
Message-ID: <gP9zU1vFVq7sCV8hKedEBrfELXkOOg9o7xYMiNHE6DU=.b904e483-bfd8-4112-9fcf-ed8cc396b670@github.com>

On Fri, 5 Sep 2025 21:10:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
>> 
>> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.
>
> Erik Joelsson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - More adjustment
>  - Adjusted logging

Marked as reviewed by zsong (Reviewer).

-------------

PR Review: https://git.openjdk.org/skara/pull/1737#pullrequestreview-3190827116