RFR: 2576: Bots still ignore GitHub comments [v2]
Erik Joelsson
erikj at openjdk.org
Fri Sep 5 21:10:58 UTC 2025
> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
>
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.
Erik Joelsson has updated the pull request incrementally with two additional commits since the last revision:
- More adjustment
- Adjusted logging
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1737/files
- new: https://git.openjdk.org/skara/pull/1737/files/82f1cd53..315f40b8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1737&range=01
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1737&range=00-01
Stats: 7 lines in 1 file changed: 2 ins; 1 del; 4 mod
Patch: https://git.openjdk.org/skara/pull/1737.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1737/head:pull/1737
PR: https://git.openjdk.org/skara/pull/1737
More information about the skara-dev
mailing list