Integrated: 2576: Bots still ignore GitHub comments
Erik Joelsson
erikj at openjdk.org
Mon Sep 8 20:28:11 UTC 2025
On Fri, 5 Sep 2025 14:27:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> The fix in [SKARA-2544](https://bugs.openjdk.org/browse/SKARA-2544) wasn't right and needs to be backed out. Getting all PRs for a repository is just way too much. My assumption was that the main reason this happened was that we sometimes had users touch more than 30 PRs within one query cycle, but that doesn't seem to be the case. As Zhao showed in the other issue, GitHub sometimes doesn't update the sort order for "updated" when a PR is touched. The "updated_at" field gets updated, but when listing PRs and sorting on "updated" it's stuck in its old sorting position. This makes us miss it in the PullRequestPoller. The only reasonable way I can see us fixing this is to increase the default page size of 30 to 100 (which is max) and potentially add a couple of pages. We need to be careful though as getting more PRs will put more load on the system.
>
> I'm also adding detection and logging of out of order PRs so that we can observe a change in behavior from GitHub. If we stop getting such log messages in the future we may assume that the issue is resolved on the GitHub side and remove the workaround.
This pull request has now been integrated.
Changeset: 27d36119
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.org/skara/commit/27d36119d7215af5ce5d4f96dd9b46136f8d9d96
Stats: 25 lines in 1 file changed: 17 ins; 0 del; 8 mod
2576: Bots still ignore GitHub comments
Reviewed-by: zsong
-------------
PR: https://git.openjdk.org/skara/pull/1737
More information about the skara-dev
mailing list