RFR: 2065: Update PR labels when new files are touched [v6]

Zhao Song zsong at openjdk.org
Mon Sep 15 18:03:19 UTC 2025


On Mon, 15 Sep 2025 17:25:24 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - update
>>  - update
>>  - review comment
>>  - fix an issue
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelCommand.java line 153:
> 
>> 151:     }
>> 152: 
>> 153:     private void addLabels(List<String> labelsToAdd, Set<String> currentLabels, PullRequest pr, PrintWriter reply, PullRequestBot bot) {
> 
> If this method is updating the argument set of `currentLabels`, then this should be documented as it's likely not what a caller would expect. Same goes for `removeLabels`. 
> 
> If we are maintaining a local copy of the current set of labels, shouldn't we reuse that when calling `upgradeLabelsToGroups` as well?

Yes, will add some documentations.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1735#discussion_r2349733327


More information about the skara-dev mailing list