RFR: 2591: Improve auto labeler [v2]
Erik Joelsson
erikj at openjdk.org
Wed Sep 24 17:46:31 UTC 2025
On Tue, 23 Sep 2025 18:07:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Yes, you're right. I need to add the check for initial run as well.
>>
>>> I also think we are missing the case when an existing label would pair up with a new label to match a group. Then the new label should be upgraded to the group.
>>
>> In this case, do you mean we just add the group label and keep the old labels?
>
> Yes, I'm referring to 2 in the examples.
I just realized that we may have misunderstood each other on 2.
> The user pushes three commits that touch “hotspot-gc” and “hotspot-jfr”. The auto labeler upgrades these to the group label “hotspot” and adds it to the PR.
I think that even if only "hotspot-gc" was found in the new commits, then it should be upgraded to "hotspot" due to "hotspot-runtime" already being present, so new list of labels should still be “hotspot-runtime”, “hotspot”.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1741#discussion_r2373123866
More information about the skara-dev
mailing list