From dholmes at openjdk.org Sun Feb 1 20:29:24 2026 From: dholmes at openjdk.org (David Holmes) Date: Sun, 1 Feb 2026 20:29:24 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files Message-ID: Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. Thanks ------------- Commit messages: - SKARA-2662 Changes: https://git.openjdk.org/skara/pull/1750/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1750&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2662 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1750.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1750/head:pull/1750 PR: https://git.openjdk.org/skara/pull/1750 From kbarrett at openjdk.org Sun Feb 1 20:36:48 2026 From: kbarrett at openjdk.org (Kim Barrett) Date: Sun, 1 Feb 2026 20:36:48 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks Looks good. ------------- Marked as reviewed by kbarrett (no project role). PR Review: https://git.openjdk.org/skara/pull/1750#pullrequestreview-3736614935 From kbarrett at openjdk.org Sun Feb 1 20:42:23 2026 From: kbarrett at openjdk.org (Kim Barrett) Date: Sun, 1 Feb 2026 20:42:23 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks [pre-existing] This configuration seems misplaced to me. Seems like it should be in a configuration file in the openjdk (or whatever) repo that skara is being used to manage. Not something for this change though. ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3831972045 From iris at openjdk.org Sun Feb 1 21:53:26 2026 From: iris at openjdk.org (Iris Clark) Date: Sun, 1 Feb 2026 21:53:26 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks Similar changes may also be needed in https://openjdk.org/guide/#directory-to-area-mapping. ------------- Marked as reviewed by iris (no project role). PR Review: https://git.openjdk.org/skara/pull/1750#pullrequestreview-3736710907 From dholmes at openjdk.org Mon Feb 2 01:32:10 2026 From: dholmes at openjdk.org (David Holmes) Date: Mon, 2 Feb 2026 01:32:10 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 21:51:13 GMT, Iris Clark wrote: > Similar changes may also be needed in https://openjdk.org/guide/#directory-to-area-mapping. Thanks for the review @irisclark . The directory-to-area mapping is already correct: [hotspot](https://github.com/openjdk/jdk/tree/master/src/hotspot) [cpu](https://github.com/openjdk/jdk/tree/master/src/hotspot/cpu) - Compiler, Runtime this just changed the set of runtime files. ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3832466848 From dholmes at openjdk.org Mon Feb 2 01:32:11 2026 From: dholmes at openjdk.org (David Holmes) Date: Mon, 2 Feb 2026 01:32:11 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:40:07 GMT, Kim Barrett wrote: >> Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. >> >> Thanks > > [pre-existing] This configuration seems misplaced to me. Seems like it should be in a configuration file in the > openjdk (or whatever) repo that skara is being used to manage. Not something for this change though. Thanks for the review @kimbarrett ! ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3832468338 From erikj at openjdk.org Mon Feb 2 14:20:05 2026 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 2 Feb 2026 14:20:05 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1750#pullrequestreview-3739682368 From duke at openjdk.org Mon Feb 2 14:20:05 2026 From: duke at openjdk.org (duke) Date: Mon, 2 Feb 2026 14:20:05 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks @openjdk[bot] Your change (at version 8ae97fe74939fad70a7e5adcef5fadec1340bfdb) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3835397119 From erikj at openjdk.org Mon Feb 2 14:20:05 2026 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 2 Feb 2026 14:20:05 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: <7SNUxpEVISmAfxnO8O1bd2mtnaNgB9sWcSH2hZrUSV0=.49ae79b9-5ebb-44a9-b7ca-04d5862943e6@github.com> On Sun, 1 Feb 2026 20:40:07 GMT, Kim Barrett wrote: > [pre-existing] This configuration seems misplaced to me. Seems like it should be in a configuration file in the openjdk (or whatever) repo that skara is being used to manage. Not something for this change though. I agree. I'm guessing the original Skara team started out with the file here to avoid controversy and potentially difficult discussions at the time. If you would like to initiate a move to the JDK repo, I would certainly support it. The first step would be to find a suitable location. ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3835407626 From dholmes at openjdk.org Mon Feb 2 14:27:59 2026 From: dholmes at openjdk.org (David Holmes) Date: Mon, 2 Feb 2026 14:27:59 GMT Subject: Integrated: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: References: Message-ID: <97U_oda4THB0rswjOa2U7zbLOQIx6ElA1NGIQjyDTkE=.0b9c8bf2-fde4-4ded-ae6f-d467762c2d5e@github.com> On Sun, 1 Feb 2026 20:19:07 GMT, David Holmes wrote: > Please review this update to the src/hotspot/cpu mailing list rules for hotspot-runtime files. > > Thanks This pull request has now been integrated. Changeset: d4b4048c Author: David Holmes Committer: Erik Joelsson URL: https://git.openjdk.org/skara/commit/d4b4048c9084815f949046721405e5c714ae8364 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files Reviewed-by: kbarrett, iris, erikj ------------- PR: https://git.openjdk.org/skara/pull/1750 From dholmes at openjdk.org Tue Feb 3 05:55:40 2026 From: dholmes at openjdk.org (David Holmes) Date: Tue, 3 Feb 2026 05:55:40 GMT Subject: RFR: 2662: Update the src/hotspot/cpu mailing list rules for hotspot-runtime files In-Reply-To: <7SNUxpEVISmAfxnO8O1bd2mtnaNgB9sWcSH2hZrUSV0=.49ae79b9-5ebb-44a9-b7ca-04d5862943e6@github.com> References: <7SNUxpEVISmAfxnO8O1bd2mtnaNgB9sWcSH2hZrUSV0=.49ae79b9-5ebb-44a9-b7ca-04d5862943e6@github.com> Message-ID: On Mon, 2 Feb 2026 14:17:41 GMT, Erik Joelsson wrote: >> [pre-existing] This configuration seems misplaced to me. Seems like it should be in a configuration file in the >> openjdk (or whatever) repo that skara is being used to manage. Not something for this change though. > >> [pre-existing] This configuration seems misplaced to me. Seems like it should be in a configuration file in the openjdk (or whatever) repo that skara is being used to manage. Not something for this change though. > > I agree. I'm guessing the original Skara team started out with the file here to avoid controversy and potentially difficult discussions at the time. If you would like to initiate a move to the JDK repo, I would certainly support it. The first step would be to find a suitable location. Thanks @erikj79 ! ------------- PR Comment: https://git.openjdk.org/skara/pull/1750#issuecomment-3839214368