<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Please file a SKARA admin task for this. <br>
</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 9/21/22 00:46, Guoxiong Li wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAPSsVqhSqHpYWP6x5Pa_-7ROMV-=AHh7+ezmh+8_Mon8GZ0TWA@mail.gmail.com">
<div dir="ltr">
<div id="m_7152703114190022030gmail-:1ef">
<div id="m_7152703114190022030gmail-:1eb" aria-label="Message
Body" role="textbox" aria-multiline="true" style="direction:ltr;min-height:376px" aria-controls=":1h5">Hi
all,
<div><br>
</div>
<div>Recently, I submitted a commit to the JMH [1][2] and </div>
<div>found there is no commit comment (like below) in the
issue [2].</div>
<div><br>
</div>
<div>```</div>
<div>Changeset: <br>
Author: <br>
Date: <br>
URL:<br>
</div>
<div>```</div>
<div><br>
</div>
<div>It often works well because a commit link has been
added</div>
<div>when the bot handles the pull request integrated event.</div>
<div><br>
</div>
<div>But many pull requests [5] in JMH haven't been
integrated by using the</div>
<div>command `/integrate`. The authors which have the commit
permission</div>
<div>merge the pull request by using the GitHub UI. It is
because there are</div>
<div>only few reviewers to review the code, the authors
sometimes need to</div>
<div>merge the pull request by themselves manually without
formal review.</div>
<div><br>
</div>
<div>In this situation, the problem occurs. Because the
command `/integrate`</div>
<div>has not been used, the pull request integrated event is
not triggered.</div>
<div>Then the commit link is not added and the status of the
issue </div>
<div>is not marked as `Resolved` or `Fixed`. So the authors
need to add the</div>
<div>comment or link about the commit to the issue and mark
the issue</div>
<div>as `Resolved` manually. Please see [3][4] for an
example.</div>
<div><br>
</div>
<div>Considering such manual merging will happen in the
future, I suggest</div>
<div>changing the configuration of the SKARA bot of the JMH
project so that</div>
<div>the commit comment can be added and the issue can be
solved automatically.</div>
<div>The related configuration may be `pronly` in the class
`IssueNotifierFactory`.</div>
<div>If I don't make a mistake, to meet my suggestion, the
`pronly` should be `false`.</div>
<div><br>
</div>
<div>What do you think about it? Any ideas are appreciated.</div>
<div><br>
</div>
<div>[1] <a href="https://github.com/openjdk/jmh/pull/78" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jmh/pull/78</a></div>
<div>[2] <a href="https://bugs.openjdk.org/browse/CODETOOLS-7903319" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/CODETOOLS-7903319</a></div>
<div>[3] <a href="https://github.com/openjdk/jmh/pull/75" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jmh/pull/75</a></div>
<div>[4] <a href="https://bugs.openjdk.org/browse/CODETOOLS-7903234" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/CODETOOLS-7903234</a></div>
<div>[5] <a href="https://github.com/openjdk/jmh/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jmh/pulls?q=is%3Apr+is%3Aclosed+is%3Amerged</a></div>
<div><br>
</div>
<div>Best Regards,</div>
<div>-- Guoxiong</div>
</div>
</div>
</div>
</blockquote>
</body>
</html>