<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello Goetz,</p>
<p>I think this suggestion makes sense. Before support for the
approval process, then the "ready" label more or less corresponded
to a reviewed PR, but since we now have multiple steps to pass
before a PR is ready, there isn't a clear label indication for
each step. Perhaps we should adopt a general pattern of adding a
label for each progress step as they get fulfilled (e.g.
"reviewed", "approved")? Changing color of a label probably won't
work. I think the colors are configured on a repo level. Also you
can't filter on a label color.<br>
</p>
<p>Could you file this request as an enhancement?</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 9/19/23 00:56, Lindenmaier, Goetz
wrote:<br>
</div>
<blockquote type="cite" cite="mid:PAXPR02MB8245B155F9DB612591CC29C0ECFAA@PAXPR02MB8245.eurprd02.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="DE">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="DE"><o:p> </o:p></span></p>
<p class="MsoNormal">I have a proposal for a small improvement
of <o:p></o:p></p>
<p class="MsoNormal">productivity:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I am using github.com/pulls as worklist for
my daily todos.<o:p></o:p></p>
<p class="MsoNormal">With the new added “approval” label I now
can see <o:p></o:p></p>
<p class="MsoNormal">in this list for which pull requests I
requested approval, and, with
<o:p></o:p></p>
<p class="MsoNormal">the “ready” label, whether I got the
approval.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">What I can not distinguish are changes that
require <o:p></o:p></p>
<p class="MsoNormal">a review and those that got a review. In
both cases<o:p></o:p></p>
<p class="MsoNormal">there is the red “rfr” label. Thus, I
daily open all the <o:p>
</o:p></p>
<p class="MsoNormal">pull requests and check whether they got a
review.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Is it possible to add a label that
indicates that a pull<o:p></o:p></p>
<p class="MsoNormal">request has been reviewed as required? <o:p></o:p></p>
<p class="MsoNormal">Maybe the “rfr” label could be changed in
colour<o:p></o:p></p>
<p class="MsoNormal">(grey?) once there is a sufficient amount
of reviews?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Then I can see in the list which pull
request are<o:p></o:p></p>
<p class="MsoNormal">ready for the approval request.<o:p></o:p></p>
<p class="MsoNormal">Or did a miss something and this is already
possible?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
</body>
</html>