<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I opened an issue: <a href="https://bugs.openjdk.org/browse/SKARA-2032">
[SKARA-2032] Distinguish changes that require review in personal pull request overview - Java Bug System (openjdk.org)</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks for considering this!<o:p></o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> erik.joelsson@oracle.com <erik.joelsson@oracle.com>
<br>
<b>Sent:</b> Tuesday, September 19, 2023 3:27 PM<br>
<b>To:</b> Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; skara-dev@openjdk.org<br>
<b>Subject:</b> Re: Distinguish changes that require review in personal pull request overview<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hello Goetz,<o:p></o:p></p>
<p>I think this suggestion makes sense. Before support for the approval process, then the "ready" label more or less corresponded to a reviewed PR, but since we now have multiple steps to pass before a PR is ready, there isn't a clear label indication for each
step. Perhaps we should adopt a general pattern of adding a label for each progress step as they get fulfilled (e.g. "reviewed", "approved")? Changing color of a label probably won't work. I think the colors are configured on a repo level. Also you can't filter
on a label color.<o:p></o:p></p>
<p>Could you file this request as an enhancement?<o:p></o:p></p>
<p>/Erik<o:p></o:p></p>
<div>
<p class="MsoNormal">On 9/19/23 00:56, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="DE">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="DE"> </span><o:p></o:p></p>
<p class="MsoNormal">I have a proposal for a small improvement of <o:p></o:p></p>
<p class="MsoNormal">productivity:<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I am using github.com/pulls as worklist for my daily todos.<o:p></o:p></p>
<p class="MsoNormal">With the new added “approval” label I now can see <o:p></o:p></p>
<p class="MsoNormal">in this list for which pull requests I requested approval, and, with
<o:p></o:p></p>
<p class="MsoNormal">the “ready” label, whether I got the approval.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">What I can not distinguish are changes that require <o:p></o:p></p>
<p class="MsoNormal">a review and those that got a review. In both cases<o:p></o:p></p>
<p class="MsoNormal">there is the red “rfr” label. Thus, I daily open all the <o:p>
</o:p></p>
<p class="MsoNormal">pull requests and check whether they got a review.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Is it possible to add a label that indicates that a pull<o:p></o:p></p>
<p class="MsoNormal">request has been reviewed as required? <o:p></o:p></p>
<p class="MsoNormal">Maybe the “rfr” label could be changed in colour<o:p></o:p></p>
<p class="MsoNormal">(grey?) once there is a sufficient amount of reviews?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Then I can see in the list which pull request are<o:p></o:p></p>
<p class="MsoNormal">ready for the approval request.<o:p></o:p></p>
<p class="MsoNormal">Or did a miss something and this is already possible?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>