<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello,</p>
<p>If you as maintainers would prefer it that way, we can certainly
change it. I wasn't sure which way to go with that. My assumption
was that it would encourage people to be lazy and just add the
same text to multiple bugs, when each of them were likely to
require individual motivations.</p>
<p>Note that for the maintainer, the /approve command already
approves all associated bugs if no bugid is given.</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 9/22/23 05:13, Kevin Rushforth
wrote:<br>
</div>
<blockquote type="cite" cite="mid:3624649a-946b-694a-451d-7276a85797b3@oracle.com">
+1 for this suggestion.<br>
<br>
-- Kevin<br>
<br>
<div class="moz-cite-prefix">On 9/22/2023 1:01 AM, Lindenmaier,
Goetz wrote:<br>
</div>
<blockquote type="cite" cite="mid:PAXPR02MB82457B78C771147C735551EEECFFA@PAXPR02MB8245.eurprd02.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">I
had thought about the same issue.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">/approval
all request <o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">would
be another nice solution to this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">And
similarly /approve all yes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">Best
regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">
Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue
1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="mso-fareast-language:ZH-CN">From:</span></b><span style="mso-fareast-language:ZH-CN"> skara-dev <a class="moz-txt-link-rfc2396E" href="mailto:skara-dev-retn@openjdk.org" moz-do-not-send="true"><skara-dev-retn@openjdk.org></a>
<b>On Behalf Of </b>Langer, Christoph<br>
<b>Sent:</b> Friday, September 22, 2023 9:58 AM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated
moz-txt-link-freetext" href="mailto:skara-dev@openjdk.org" moz-do-not-send="true">skara-dev@openjdk.org</a><br>
<b>Subject:</b> Suggestion regarding Skara /approval
command<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I have a small suggestion for the great
new approval feature in Skara.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Currently, when a PR refers to multiple
JBS issues, I have to request approval for each of them
with a distinct “/approval request JDK-<nnn>”
command. However, since the approval text that I’d add to
each of the items in such a case would often be the same,
I’d like to suggest that in such cases an “/approval
request” without bug ids adds the label and text to all of
the referred bugs. Do you think this makes sense? If yes,
I can create an issue for that.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</blockquote>
<br>
</blockquote>
</body>
</html>