<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">RFE created: <a href="https://bugs.openjdk.org/browse/SKARA-2042">
https://bugs.openjdk.org/browse/SKARA-2042</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:#1000">From:</span></b><span lang="EN-US" style="mso-fareast-language:#1000"> Langer, Christoph <christoph.langer@sap.com>
<br>
<b>Sent:</b> Freitag, 22. September 2023 15:13<br>
<b>To:</b> erik.joelsson@oracle.com; Kevin Rushforth <kevin.rushforth@oracle.com>; Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; skara-dev@openjdk.org<br>
<b>Subject:</b> RE: Suggestion regarding Skara /approval command<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi Erik,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">thanks for these insights. Regarding the laziness of requestors, I think we can handle it. If a comment is too short of content we’ll anyway ask the submitter for more info. But in most cases of multiple issues, I guess
it’s possible/ok/desirable to have one text to explain them all.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">So I’ll open a ticket for this.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Cheers<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:#1000">From:</span></b><span lang="EN-US" style="mso-fareast-language:#1000">
<a href="mailto:erik.joelsson@oracle.com">erik.joelsson@oracle.com</a> <<a href="mailto:erik.joelsson@oracle.com">erik.joelsson@oracle.com</a>>
<br>
<b>Sent:</b> Freitag, 22. September 2023 15:09<br>
<b>To:</b> Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com">kevin.rushforth@oracle.com</a>>; Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com">goetz.lindenmaier@sap.com</a>>; Langer, Christoph <<a href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>>;
<a href="mailto:skara-dev@openjdk.org">skara-dev@openjdk.org</a><br>
<b>Subject:</b> Re: Suggestion regarding Skara /approval command<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hello,<o:p></o:p></p>
<p>If you as maintainers would prefer it that way, we can certainly change it. I wasn't sure which way to go with that. My assumption was that it would encourage people to be lazy and just add the same text to multiple bugs, when each of them were likely to
require individual motivations.<o:p></o:p></p>
<p>Note that for the maintainer, the /approve command already approves all associated bugs if no bugid is given.<o:p></o:p></p>
<p>/Erik<o:p></o:p></p>
<div>
<p class="MsoNormal">On 9/22/23 05:13, Kevin Rushforth wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">+1 for this suggestion.<br>
<br>
-- Kevin<o:p></o:p></p>
<div>
<p class="MsoNormal">On 9/22/2023 1:01 AM, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">I had thought about the same issue.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">/approval all request
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">would be another nice solution to this.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">And similarly /approve all yes.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN">Best regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"> Goetz.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="mso-fareast-language:ZH-CN">From:</span></b><span style="mso-fareast-language:ZH-CN"> skara-dev
<a href="mailto:skara-dev-retn@openjdk.org"><skara-dev-retn@openjdk.org></a> <b>On Behalf Of
</b>Langer, Christoph<br>
<b>Sent:</b> Friday, September 22, 2023 9:58 AM<br>
<b>To:</b> <a href="mailto:skara-dev@openjdk.org">skara-dev@openjdk.org</a><br>
<b>Subject:</b> Suggestion regarding Skara /approval command</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I have a small suggestion for the great new approval feature in Skara.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Currently, when a PR refers to multiple JBS issues, I have to request approval for each of them with a distinct “/approval request JDK-<nnn>” command. However, since the approval text that I’d add to each of the items in such a case would
often be the same, I’d like to suggest that in such cases an “/approval request” without bug ids adds the label and text to all of the referred bugs. Do you think this makes sense? If yes, I can create an issue for that.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</blockquote>
<p class="MsoNormal"><span style="mso-fareast-language:#1000"><o:p> </o:p></span></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>