<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello,</p>
<p>Dependent pull requests weren't considered with this feature. The
way it works now, the approval logic won't be triggered until the
PR targets a branch that is configured for approval. A quick and
dirty workaround would be to configure 'pr/.*' as a set of
branches that need approval for the repo. A more correct solution
would be to implement proper support for pr/X branches by haing
the bot extract the PR from the target branch name and follow that
dependency chain until we find a non pr/X branch, and if that
branch requires approval, activate the approval logic.</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 9/27/23 09:44, Zhao Song wrote:<br>
</div>
<blockquote type="cite" cite="mid:DS7PR10MB49732453FEC349034C438A9484C2A@DS7PR10MB4973.namprd10.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Goetz,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Maybe it’s a
bug in the maintainer approval feature.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The skara
bot would determine whether this pr needs maintainer
approval by checking whether merging into the target branch
needs maintainer approval.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">In this
case, we only configured that merging into master branch of
jdk21u needs maintainer approval, however, for dependent
pull requests, the target branch is pr/XXX.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I will try
to fix it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thank you,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Zhao<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">skara-dev
<a class="moz-txt-link-rfc2396E" href="mailto:skara-dev-retn@openjdk.org"><skara-dev-retn@openjdk.org></a> on behalf of
Lindenmaier, Goetz <a class="moz-txt-link-rfc2396E" href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a><br>
<b>Date: </b>Wednesday, September 27, 2023 at 08:21<br>
<b>To: </b><a class="moz-txt-link-abbreviated" href="mailto:skara-dev@openjdk.org">skara-dev@openjdk.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:skara-dev@openjdk.org"><skara-dev@openjdk.org></a>, Erik Joelsson
<a class="moz-txt-link-rfc2396E" href="mailto:erik.joelsson@oracle.com"><erik.joelsson@oracle.com></a>, Kevin Rushforth
<a class="moz-txt-link-rfc2396E" href="mailto:kevin.rushforth@oracle.com"><kevin.rushforth@oracle.com></a><br>
<b>Subject: </b>SKARA-2019 and dependent pull
requests<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="DE">Hi Erik and Kevin,</span><span style="font-size:11.0pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="DE"> </span><span style="font-size:11.0pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">How does
SKARA-2019/21 handle dependent pull requests?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><a href="https://github.com/openjdk/jdk21u/pull/200" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk21u/pull/200</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The
change is not marked for approval.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Is this
on purpose or just not yet implemented?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">If there
is a needed follow up fix, I as a maintainer only
approve the<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">underlying
change after approving the follow up to make<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">sure
they can both be pushed at the same time.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">So I
would have expected the above PR to be marked
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">as ready
for approval.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Best
regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> <o:p></o:p></span></p>
</div>
</div>
</div>
</blockquote>
</body>
</html>