From jeannette.hung at oracle.com Tue Sep 6 21:44:20 2011 From: jeannette.hung at oracle.com (Jeannette Hung) Date: Tue, 6 Sep 2011 21:44:20 -0700 Subject: code review request: 7087428: move client tests out of jdk_misc In-Reply-To: <4E66D686.2050008@oracle.com> References: <4E663868.8040606@oracle.com> <4E66D686.2050008@oracle.com> Message-ID: Including 2d-dev, since javax/imageio, javax/print, sun/pisces, is 2d code. On Sep 6, 2011, at 7:27 PM, Weijun Wang wrote: > Updated: > > root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/ > jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/ > > I also update Makefile to put jdk_sound to its correct alphabetical position. > > Thanks > Max > > > On 09/07/2011 02:30 AM, Kelly O'Hair wrote: >> Looks fine. >> >> But the files make/jprt.properties in both the root repository and the jdk repository >> will minor changes to add jdk_sound as a new test for JPRT. >> You can place it in the jprt.make.rule.all.test.targets list. >> >> -kto >> >> On Sep 6, 2011, at 8:12 AM, Weijun Wang wrote: >> >>> Hi Kelly >>> >>> Webrev at http://cr.openjdk.java.net/~weijun/7087428/webrev.00/ >>> >>> Basically I'd like jdk_misc batch to contain only "headless" tests and move all the others into their own batch. >>> >>> Changes: >>> >>> 1. Move javax/imageio, javax/print, sun/pisces to jdk_awt >>> 2. Move com/sun/java/swing to jdk_swing >>> 3. Move com/sun/org/apache/xml/internal/security to jdk_security3 >>> 4. Create a separate batch jdk_sound for javax/sound >>> 5. Divide demo to different parts and move demo/jfc to jdk_swing. If the demo dir is moved to some other directory later, more updates will be needed. >>> >>> Please note that I change com/sun/java to com/sun/java/swing, and com/sun/org to com/sun/org/apache/xml/internal/security, since those are the only sub-dir there. There might be other sub-dirs later. >>> >>> Thanks >>> Max >>> >>> -------- Original Message -------- >>> 7087428: move client tests out of jdk_misc >>> >>> === *Description* ============================================================ >>> The jdk_misc batch in test/Makefile contains tests for swing, sound etc, They should be moved to their own batches. >>> >> From kelly.ohair at oracle.com Wed Sep 7 08:39:02 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 7 Sep 2011 08:39:02 -0700 Subject: code review request: 7087428: move client tests out of jdk_misc In-Reply-To: <4E66D686.2050008@oracle.com> References: <4E663868.8040606@oracle.com> <4E66D686.2050008@oracle.com> Message-ID: <3F6822F6-A433-4268-A3C8-6EFE2D1548D7@oracle.com> Looks great. Thanks for taking care of this. -kto On Sep 6, 2011, at 7:27 PM, Weijun Wang wrote: > Updated: > > root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/ > jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/ > > I also update Makefile to put jdk_sound to its correct alphabetical position. > > Thanks > Max > > > On 09/07/2011 02:30 AM, Kelly O'Hair wrote: >> Looks fine. >> >> But the files make/jprt.properties in both the root repository and the jdk repository >> will minor changes to add jdk_sound as a new test for JPRT. >> You can place it in the jprt.make.rule.all.test.targets list. >> >> -kto >> >> On Sep 6, 2011, at 8:12 AM, Weijun Wang wrote: >> >>> Hi Kelly >>> >>> Webrev at http://cr.openjdk.java.net/~weijun/7087428/webrev.00/ >>> >>> Basically I'd like jdk_misc batch to contain only "headless" tests and move all the others into their own batch. >>> >>> Changes: >>> >>> 1. Move javax/imageio, javax/print, sun/pisces to jdk_awt >>> 2. Move com/sun/java/swing to jdk_swing >>> 3. Move com/sun/org/apache/xml/internal/security to jdk_security3 >>> 4. Create a separate batch jdk_sound for javax/sound >>> 5. Divide demo to different parts and move demo/jfc to jdk_swing. If the demo dir is moved to some other directory later, more updates will be needed. >>> >>> Please note that I change com/sun/java to com/sun/java/swing, and com/sun/org to com/sun/org/apache/xml/internal/security, since those are the only sub-dir there. There might be other sub-dirs later. >>> >>> Thanks >>> Max >>> >>> -------- Original Message -------- >>> 7087428: move client tests out of jdk_misc >>> >>> === *Description* ============================================================ >>> The jdk_misc batch in test/Makefile contains tests for swing, sound etc, They should be moved to their own batches. >>> >> From kelly.ohair at oracle.com Wed Sep 7 08:43:44 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 7 Sep 2011 08:43:44 -0700 Subject: code review request: 7087428: move client tests out of jdk_misc In-Reply-To: <4E675066.5040005@oracle.com> References: <4E663868.8040606@oracle.com> <4E66D686.2050008@oracle.com> <4E675066.5040005@oracle.com> Message-ID: <4546D8D0-0135-476A-A340-878547762C3C@oracle.com> On Sep 7, 2011, at 4:07 AM, Alan Bateman wrote: > Weijun Wang wrote: >> Updated: >> >> root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/ >> jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/ >> >> I also update Makefile to put jdk_sound to its correct alphabetical position. > The changes look okay to me. The jdk_misc batch is still an odd mix of tests but clearly fine grain splitting will lead to too many tiny batches. > > I don't know what to say about the jdk_swing and jdk_awt batches. It does seem a bit strange to have some 2d tests in the jdk_swing batch and others in the jdk_awt batch. I haven't seen any change-sets from folks in those areas adding or removing tests from the problem list so it's possible that they aren't using the make file to run the tests. Not sure they run these tests much from the Makefile. Originally I had to corral them off because they belonged to a set of tests that only worked with a DISPLAY setup on Solaris/Linux, and they seemed to poison the DISPLAY with strange settings. That's when I created a unique VNC display on the JPRT driver machine for each user job in JPRT, starting the DISPLAY fresh each time and killing it off when the job was done, so the poisoning was contained and didn't impact other user jobs. Last time I ran them, they seemed to run ok. (and jdk_misc has some tests that need a DISPLAY too I think). We should probably warn Amy (QE) about these tests. :^( -kto