From Sergey.Bylokhov at oracle.com Tue Oct 1 05:09:18 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 01 Oct 2013 16:09:18 +0400 Subject: [8] Request for review: 7058662 7058666 7058672 In-Reply-To: <5249E510.3000402@bome.com> References: <523C6207.3090509@oracle.com> <52458054.3070604@oracle.com> <5249E510.3000402@bome.com> Message-ID: <524ABB6E.4030603@oracle.com> Hello, Florian! Thanks for review! Here is updated version of the fix. http://cr.openjdk.java.net/~serb/7058672/webrev.01/ On 01.10.2013 0:57, Florian Bomers wrote: > Hi Sergey, > > I ("$$fb") took the liberty to review :) > > in AiffFileReader.java, you've changed >> int channels = dis.readShort(); > to >> short channels = dis.readShort(); > As these fields are unsigned, you should rather use this: > int channels = dis.readUnsignedShort(); > > same for "short sampleSizeInBits". > > The rest looks fine to me. > > Regards, > Florian > > > On 27.09.2013 14:55, Sergey Bylokhov wrote: >> Hello, >> Does anybody have a time for review? >> Thanks. >> >> On 20.09.2013 18:56, Sergey Bylokhov wrote: >>> Hello, >>> Please review the fix for jdk 8. >>> Input validation was added to the numbers of channels and >>> sampleSizeInBits. So now we throw UnsupportedAudioFileException >>> instead of ArithmeticException. >>> Hangs will be fixed as part of 7058700. >>> >>> Bugs: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662 >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666 >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672 >>> >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/7058672/webrev.00 >>> >> -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Mon Oct 7 10:16:40 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 07 Oct 2013 21:16:40 +0400 Subject: [8] Review Request: 8022119 test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails Message-ID: <5252EC78.5010009@oracle.com> Hello. Please review the fix for jdk 8. ServiceLoader usage was changed according to the change in JDK-8019622 Bug: https://bugs.openjdk.java.net/browse/JDK-8022119 Webrev can be found at: http://cr.openjdk.java.net/~serb/8022119/webrev.00 -- Best regards, Sergey. From philip.race at oracle.com Wed Oct 9 11:44:52 2013 From: philip.race at oracle.com (Phil Race) Date: Wed, 09 Oct 2013 11:44:52 -0700 Subject: [8] Request for review: 7058662 7058666 7058672 In-Reply-To: <524AE221.5060101@bome.com> References: <523C6207.3090509@oracle.com> <52458054.3070604@oracle.com> <5249E510.3000402@bome.com> <524ABB6E.4030603@oracle.com> <524AE221.5060101@bome.com> Message-ID: <5255A424.2010805@oracle.com> Looks OK to me too. -phil. On 10/1/2013 7:57 AM, Florian Bomers wrote: > looks good to me, thanks! > Florian > > > On 01.10.2013 14:09, Sergey Bylokhov wrote: >> Hello, Florian! >> Thanks for review! >> Here is updated version of the fix. >> http://cr.openjdk.java.net/~serb/7058672/webrev.01/ >> >> On 01.10.2013 0:57, Florian Bomers wrote: >>> Hi Sergey, >>> >>> I ("$$fb") took the liberty to review :) >>> >>> in AiffFileReader.java, you've changed >>>> int channels = dis.readShort(); >>> to >>>> short channels = dis.readShort(); >>> As these fields are unsigned, you should rather use this: >>> int channels = dis.readUnsignedShort(); >>> >>> same for "short sampleSizeInBits". >>> >>> The rest looks fine to me. >>> >>> Regards, >>> Florian >>> >>> >>> On 27.09.2013 14:55, Sergey Bylokhov wrote: >>>> Hello, >>>> Does anybody have a time for review? >>>> Thanks. >>>> >>>> On 20.09.2013 18:56, Sergey Bylokhov wrote: >>>>> Hello, >>>>> Please review the fix for jdk 8. >>>>> Input validation was added to the numbers of channels and >>>>> sampleSizeInBits. So now we throw UnsupportedAudioFileException >>>>> instead of ArithmeticException. >>>>> Hangs will be fixed as part of 7058700. >>>>> >>>>> Bugs: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662 >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666 >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672 >>>>> >>>>> Webrev can be found at: >>>>> http://cr.openjdk.java.net/~serb/7058672/webrev.00 >>>>> >> From Florian.Bomers at bome.com Tue Oct 1 07:57:50 2013 From: Florian.Bomers at bome.com (Florian Bomers) Date: Tue, 01 Oct 2013 14:57:50 -0000 Subject: [8] Request for review: 7058662 7058666 7058672 In-Reply-To: <524ABB6E.4030603@oracle.com> References: <523C6207.3090509@oracle.com> <52458054.3070604@oracle.com> <5249E510.3000402@bome.com> <524ABB6E.4030603@oracle.com> Message-ID: <524AE221.5060101@bome.com> looks good to me, thanks! Florian On 01.10.2013 14:09, Sergey Bylokhov wrote: > Hello, Florian! > Thanks for review! > Here is updated version of the fix. > http://cr.openjdk.java.net/~serb/7058672/webrev.01/ > > On 01.10.2013 0:57, Florian Bomers wrote: >> Hi Sergey, >> >> I ("$$fb") took the liberty to review :) >> >> in AiffFileReader.java, you've changed >>> int channels = dis.readShort(); >> to >>> short channels = dis.readShort(); >> As these fields are unsigned, you should rather use this: >> int channels = dis.readUnsignedShort(); >> >> same for "short sampleSizeInBits". >> >> The rest looks fine to me. >> >> Regards, >> Florian >> >> >> On 27.09.2013 14:55, Sergey Bylokhov wrote: >>> Hello, >>> Does anybody have a time for review? >>> Thanks. >>> >>> On 20.09.2013 18:56, Sergey Bylokhov wrote: >>>> Hello, >>>> Please review the fix for jdk 8. >>>> Input validation was added to the numbers of channels and >>>> sampleSizeInBits. So now we throw UnsupportedAudioFileException >>>> instead of ArithmeticException. >>>> Hangs will be fixed as part of 7058700. >>>> >>>> Bugs: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662 >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666 >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672 >>>> >>>> Webrev can be found at: >>>> http://cr.openjdk.java.net/~serb/7058672/webrev.00 >>>> >>> > > -- Florian Bomers Bome Software everything sounds. http://www.bome.com __________________________________________________________________ Bome Software GmbH & Co KG Gesellschafterin: Dachauer Str.187 Bome Komplement?r GmbH 80637 M?nchen, Germany Gesch?ftsf?hrung: Florian B?mers Amtsgericht M?nchen HRA95502 Amtsgericht M?nchen HRB185574 From anthony.petrov at oracle.com Tue Oct 8 05:33:20 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 08 Oct 2013 12:33:20 -0000 Subject: [8] Review Request: 8022119 test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails In-Reply-To: <5252EC78.5010009@oracle.com> References: <5252EC78.5010009@oracle.com> Message-ID: <5253FB89.9060705@oracle.com> Hi Sergey, The fix looks fine to me. A minor typo in the comment: > 192 // creates the ServiceLoader instance, so it require do be called from Should read "requires to". No need for a new webrev with this change. -- best regards, Anthony On 10/07/2013 09:16 PM, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk 8. > ServiceLoader usage was changed according to the change in JDK-8019622 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8022119 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8022119/webrev.00 >