<Sound Dev> [8] Request for review: 7058662 7058666 7058672

[Florian Bomers]

looks good to me, thanks!
Florian


On 01.10.2013 14:09, Sergey Bylokhov wrote:
> Hello, Florian!
> Thanks for review!
> Here is updated version of the fix.
> http://cr.openjdk.java.net/~serb/7058672/webrev.01/
> 
> On 01.10.2013 0:57, Florian Bomers wrote:
>> Hi Sergey,
>>
>> I ("$$fb") took the liberty to review :)
>>
>> in AiffFileReader.java, you've changed
>>> int channels = dis.readShort();
>> to
>>> short channels = dis.readShort();
>> As these fields are unsigned, you should rather use this:
>>     int channels = dis.readUnsignedShort();
>>
>> same for "short sampleSizeInBits".
>>
>> The rest looks fine to me.
>>
>> Regards,
>> Florian
>>
>>
>> On 27.09.2013 14:55, Sergey Bylokhov wrote:
>>> Hello,
>>> Does anybody have a time for review?
>>> Thanks.
>>>
>>> On 20.09.2013 18:56, Sergey Bylokhov wrote:
>>>> Hello,
>>>> Please review the fix for jdk 8.
>>>> Input validation was added to the numbers of channels and
>>>> sampleSizeInBits. So now we throw UnsupportedAudioFileException
>>>> instead of ArithmeticException.
>>>> Hangs will be fixed as part of 7058700.
>>>>
>>>> Bugs:
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672
>>>>
>>>> Webrev can be found at:
>>>> http://cr.openjdk.java.net/~serb/7058672/webrev.00
>>>>
>>>
> 
> 

-- 
Florian Bomers
Bome Software

everything sounds.
http://www.bome.com
__________________________________________________________________
Bome Software GmbH & Co KG        Gesellschafterin:
Dachauer Str.187                  Bome Komplementär GmbH
80637 München, Germany            Geschäftsführung: Florian Bömers
Amtsgericht München HRA95502      Amtsgericht München HRB185574