<Sound Dev> [8] Review Request: 8022119 test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails

Anthony Petrov anthony.petrov at oracle.com
Tue Oct 8 05:33:20 PDT 2013


Hi Sergey,

The fix looks fine to me. A minor typo in the comment:

>  192         // creates the ServiceLoader instance, so it require do be called from

Should read "requires to". No need for a new webrev with this change.

--
best regards,
Anthony

On 10/07/2013 09:16 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
> ServiceLoader usage was changed according to the change in JDK-8019622
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8022119
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8022119/webrev.00
>


More information about the sound-dev mailing list