From Sergey.Bylokhov at oracle.com  Fri Sep 20 07:56:07 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 20 Sep 2013 18:56:07 +0400
Subject: <Sound Dev> [8] Request for review: 7058662 7058666 7058672
Message-ID: <523C6207.3090509@oracle.com>

Hello,
Please review the fix for jdk 8.
Input validation was added to the numbers of channels and 
sampleSizeInBits. So now we throw UnsupportedAudioFileException instead 
of ArithmeticException.
Hangs will be fixed as part of 7058700.

Bugs:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672

Webrev can be found at: http://cr.openjdk.java.net/~serb/7058672/webrev.00

-- 
Best regards, Sergey.


From Sergey.Bylokhov at oracle.com  Fri Sep 27 05:55:48 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 27 Sep 2013 16:55:48 +0400
Subject: <Sound Dev> [8] Request for review: 7058662 7058666 7058672
In-Reply-To: <523C6207.3090509@oracle.com>
References: <523C6207.3090509@oracle.com>
Message-ID: <52458054.3070604@oracle.com>

Hello,
Does anybody have a time for review?
Thanks.

On 20.09.2013 18:56, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk 8.
> Input validation was added to the numbers of channels and 
> sampleSizeInBits. So now we throw UnsupportedAudioFileException 
> instead of ArithmeticException.
> Hangs will be fixed as part of 7058700.
>
> Bugs:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672
>
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/7058672/webrev.00
>


-- 
Best regards, Sergey.


From javasound-dev at bome.com  Mon Sep 30 13:57:58 2013
From: javasound-dev at bome.com (Florian Bomers)
Date: Mon, 30 Sep 2013 22:57:58 +0200
Subject: <Sound Dev> [8] Request for review: 7058662 7058666 7058672
In-Reply-To: <52458054.3070604@oracle.com>
References: <523C6207.3090509@oracle.com> <52458054.3070604@oracle.com>
Message-ID: <5249E510.3000402@bome.com>

Hi Sergey,

I ("$$fb") took the liberty to review :)

in AiffFileReader.java, you've changed
> int channels = dis.readShort();
to
> short channels = dis.readShort();

As these fields are unsigned, you should rather use this:
	int channels = dis.readUnsignedShort();

same for "short sampleSizeInBits".

The rest looks fine to me.

Regards,
Florian


On 27.09.2013 14:55, Sergey Bylokhov wrote:
> Hello,
> Does anybody have a time for review?
> Thanks.
> 
> On 20.09.2013 18:56, Sergey Bylokhov wrote:
>> Hello,
>> Please review the fix for jdk 8.
>> Input validation was added to the numbers of channels and
>> sampleSizeInBits. So now we throw UnsupportedAudioFileException
>> instead of ArithmeticException.
>> Hangs will be fixed as part of 7058700.
>>
>> Bugs:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058662
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058666
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058672
>>
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/7058672/webrev.00
>>
> 
> 

-- 
Florian Bomers
Bome Software

everything sounds.
http://www.bome.com
__________________________________________________________________
Bome Software GmbH & Co KG        Gesellschafterin:
Dachauer Str.187                  Bome Komplement?r GmbH
80637 M?nchen, Germany            Gesch?ftsf?hrung: Florian B?mers
Amtsgericht M?nchen HRA95502      Amtsgericht M?nchen HRB185574