<Sound Dev> [8] Review Request: 8040116 Tidy warnings cleanup for javax.sound

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Apr 17 10:13:52 UTC 2014


Hi, Alexander.
The fix looks good.

On 15.04.2014 19:13, alexander stepanov wrote:
> Hello Sergey,
>
> Yes, thanks, that's better; please see the review updated:
> http://cr.openjdk.java.net/~yan/8040116/webrev.01/
>
> Regards,
> Alexander
>
> On 14.04.2014 16:48, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> It is unclear why we use this notation:
>> * @see Mixer#getLine <code>Mixer.getLine(Line.Info)</code>
>> instead of:
>> * @see Mixer#getLine(Line.Info)
>> Result is equivalent, but the second version is shorter.
>>
>> On 14.04.2014 16:33, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8040116
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/8040116/webrev.00/
>>>
>>> Just a very minor cleanup of javadoc to avoid tidy warnings; no 
>>> other code affected.
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander
>>
>>
>


-- 
Best regards, Sergey.



More information about the sound-dev mailing list