From anthony.petrov at oracle.com  Tue Jul 15 12:13:25 2014
From: anthony.petrov at oracle.com (Anthony Petrov)
Date: Tue, 15 Jul 2014 16:13:25 +0400
Subject: <Sound Dev> [9] Review request: 8050465 Remove sun.audio package
In-Reply-To: <88FC3515-EE2A-4A43-96E3-B3632C4A799F@oracle.com>
References: <88FC3515-EE2A-4A43-96E3-B3632C4A799F@oracle.com>
Message-ID: <53C51AE5.90402@oracle.com>

Looks fine.

--
best regards,
Anthony

On 7/15/2014 11:41 AM, Petr Pchelko wrote:
> Hello,
>
> Please review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8050465
> The fix is available here:
> http://cr.openjdk.java.net/~pchelko/9/8050465/webrev/
>
> Simple clean-up. The package is not used any more and can be removed.
>
> With best regards. Petr.
>

From Sergey.Bylokhov at oracle.com  Wed Jul 16 11:31:47 2014
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 16 Jul 2014 15:31:47 +0400
Subject: <Sound Dev> [9] Review request: 8050465 Remove sun.audio package
In-Reply-To: <88FC3515-EE2A-4A43-96E3-B3632C4A799F@oracle.com>
References: <88FC3515-EE2A-4A43-96E3-B3632C4A799F@oracle.com>
Message-ID: <53C662A3.6020100@oracle.com>

Hi, Petr.
The fix looks good.

On 7/15/14 11:41 AM, Petr Pchelko wrote:
> Hello,
>
> Please review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8050465
> The fix is available here:
> http://cr.openjdk.java.net/~pchelko/9/8050465/webrev/
>
> Simple clean-up. The package is not used any more and can be removed.
>
> With best regards. Petr.


-- 
Best regards, Sergey.


From petr.pchelko at oracle.com  Tue Jul 15 07:41:48 2014
From: petr.pchelko at oracle.com (Petr Pchelko)
Date: Tue, 15 Jul 2014 11:41:48 +0400
Subject: <Sound Dev> [9] Review request: 8050465 Remove sun.audio package
Message-ID: <88FC3515-EE2A-4A43-96E3-B3632C4A799F@oracle.com>

Hello, 

Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8050465
The fix is available here:
http://cr.openjdk.java.net/~pchelko/9/8050465/webrev/

Simple clean-up. The package is not used any more and can be removed.

With best regards. Petr.

From Sergey.Bylokhov at oracle.com  Wed Jul 16 16:56:38 2014
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 16 Jul 2014 20:56:38 +0400
Subject: <Sound Dev> [9] Review Request: 8050852 Javadoc cleanup of
	javax.sound.midi package
Message-ID: <53C6AEC6.7050303@oracle.com>

Hello.
Please review another one javadoc cleanup in jdk 9 in sound area:
  - @param, @return should not end with a dot, except a case when more 
than one sentences are used.
  - @param, @throws, @return now align, to be more readable.
  - @see tags simplified in some places.
  - Description of the class/method/field should be followed by dot.
  - Broken links/typos fixed
  - 80 column limit.
  - sets of spaces in the middle of text were deleted.
  - <tag> replaced by {@tag }.
  - unnecessary imports were removed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
See the full specdiff: 
http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02

-- 
Best regards, Sergey.


From petr.pchelko at oracle.com  Thu Jul 17 08:18:42 2014
From: petr.pchelko at oracle.com (Petr Pchelko)
Date: Thu, 17 Jul 2014 12:18:42 +0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
	cleanup of javax.sound.midi package
In-Reply-To: <53C6AEC6.7050303@oracle.com>
References: <53C6AEC6.7050303@oracle.com>
Message-ID: <9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>

Hello, Sergey.

The fix looks good to me.

With best regards. Petr.

On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> Hello.
> Please review another one javadoc cleanup in jdk 9 in sound area:
> - @param, @return should not end with a dot, except a case when more than one sentences are used.
> - @param, @throws, @return now align, to be more readable.
> - @see tags simplified in some places.
> - Description of the class/method/field should be followed by dot.
> - Broken links/typos fixed
> - 80 column limit.
> - sets of spaces in the middle of text were deleted.
> - <tag> replaced by {@tag }.
> - unnecessary imports were removed.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
> See the full specdiff: http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02
> 
> -- 
> Best regards, Sergey.
> 


From Sergey.Bylokhov at oracle.com  Wed Jul 23 09:44:11 2014
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 23 Jul 2014 13:44:11 +0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
 cleanup of javax.sound.midi package
In-Reply-To: <9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
References: <53C6AEC6.7050303@oracle.com>
	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
Message-ID: <53CF83EB.9010607@oracle.com>

Hello,
Any volunteers to be a second reviewer?

On 17.07.2014 12:18, Petr Pchelko wrote:
> Hello, Sergey.
>
> The fix looks good to me.
>
> With best regards. Petr.
>
> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>
>> Hello.
>> Please review another one javadoc cleanup in jdk 9 in sound area:
>> - @param, @return should not end with a dot, except a case when more than one sentences are used.
>> - @param, @throws, @return now align, to be more readable.
>> - @see tags simplified in some places.
>> - Description of the class/method/field should be followed by dot.
>> - Broken links/typos fixed
>> - 80 column limit.
>> - sets of spaces in the middle of text were deleted.
>> - <tag> replaced by {@tag }.
>> - unnecessary imports were removed.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>> See the full specdiff: http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>
>> -- 
>> Best regards, Sergey.
>>


-- 
Best regards, Sergey.


From danrollo at gmail.com  Wed Jul 23 16:51:35 2014
From: danrollo at gmail.com (Dan Rollo)
Date: Wed, 23 Jul 2014 12:51:35 -0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
	cleanup of javax.sound.midi package
In-Reply-To: <53CF83EB.9010607@oracle.com>
References: <53C6AEC6.7050303@oracle.com>
	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com>
Message-ID: <19BCBC70-2930-43A8-9FAD-387BAF0D26D7@gmail.com>

Hello Sergey,

Looks good to me. One comment below:

Is it considered good practice to ?import? a class that is only referenced in javadoc? For example, your changes to src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java add an import that is only used in javadoc. The prior version used a fully qualified reference in the javadoc, and avoided the import. 

{@link javax.sound.sampled.AudioSystem#NOT_SPECIFIED? 
instead of:
{@link AudioSystem#NOT_SPECIFIED

I typically avoid such ?unused imports? in order to avoid unintended coupling between classes and/or compilation issues. 

I saw this sort of ?javadoc only import/unused import? in the following files:

src/share/classes/javax/sound/midi/MidiSystem.java
src/share/classes/javax/sound/midi/SoundbankResource.java
src/share/classes/javax/sound/midi/spi/SoundbankReader.java
src/share/classes/javax/sound/sampled/AudioSystem.java
src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java


Best Regards,
Dan Rollo

On Jul 23, 2014, at 5:44 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> Hello,
> Any volunteers to be a second reviewer?
> 
> On 17.07.2014 12:18, Petr Pchelko wrote:
>> Hello, Sergey.
>> 
>> The fix looks good to me.
>> 
>> With best regards. Petr.
>> 
>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>> 
>>> Hello.
>>> Please review another one javadoc cleanup in jdk 9 in sound area:
>>> - @param, @return should not end with a dot, except a case when more than one sentences are used.
>>> - @param, @throws, @return now align, to be more readable.
>>> - @see tags simplified in some places.
>>> - Description of the class/method/field should be followed by dot.
>>> - Broken links/typos fixed
>>> - 80 column limit.
>>> - sets of spaces in the middle of text were deleted.
>>> - <tag> replaced by {@tag }.
>>> - unnecessary imports were removed.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>>> See the full specdiff: http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>> 
>>> -- 
>>> Best regards, Sergey.
>>> 
> 
> 
> -- 
> Best regards, Sergey.
> 


From Sergey.Bylokhov at oracle.com  Wed Jul 23 19:01:28 2014
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 23 Jul 2014 23:01:28 +0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
 cleanup of javax.sound.midi package
In-Reply-To: <19BCBC70-2930-43A8-9FAD-387BAF0D26D7@gmail.com>
References: <53C6AEC6.7050303@oracle.com>
	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com>
	<19BCBC70-2930-43A8-9FAD-387BAF0D26D7@gmail.com>
Message-ID: <53D00688.9010104@oracle.com>

Hi, Dan.
Yes, the links were changed intentionally to make readability of javadoc 
better, split of links across a few lines looks bad.

On 23.07.2014 20:51, Dan Rollo wrote:
> Hello Sergey,
>
> Looks good to me. One comment below:
>
> Is it considered good practice to ?import? a class that is only referenced in javadoc? For example, your changes to src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java add an import that is only used in javadoc. The prior version used a fully qualified reference in the javadoc, and avoided the import.
>
> {@link javax.sound.sampled.AudioSystem#NOT_SPECIFIED?
> instead of:
> {@link AudioSystem#NOT_SPECIFIED
>
> I typically avoid such ?unused imports? in order to avoid unintended coupling between classes and/or compilation issues.
>
> I saw this sort of ?javadoc only import/unused import? in the following files:
>
> src/share/classes/javax/sound/midi/MidiSystem.java
> src/share/classes/javax/sound/midi/SoundbankResource.java
> src/share/classes/javax/sound/midi/spi/SoundbankReader.java
> src/share/classes/javax/sound/sampled/AudioSystem.java
> src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java
>
>
> Best Regards,
> Dan Rollo
>
> On Jul 23, 2014, at 5:44 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>
>> Hello,
>> Any volunteers to be a second reviewer?
>>
>> On 17.07.2014 12:18, Petr Pchelko wrote:
>>> Hello, Sergey.
>>>
>>> The fix looks good to me.
>>>
>>> With best regards. Petr.
>>>
>>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>>
>>>> Hello.
>>>> Please review another one javadoc cleanup in jdk 9 in sound area:
>>>> - @param, @return should not end with a dot, except a case when more than one sentences are used.
>>>> - @param, @throws, @return now align, to be more readable.
>>>> - @see tags simplified in some places.
>>>> - Description of the class/method/field should be followed by dot.
>>>> - Broken links/typos fixed
>>>> - 80 column limit.
>>>> - sets of spaces in the middle of text were deleted.
>>>> - <tag> replaced by {@tag }.
>>>> - unnecessary imports were removed.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>>>> See the full specdiff: http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
>>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>>>
>>>> -- 
>>>> Best regards, Sergey.
>>>>
>>
>> -- 
>> Best regards, Sergey.
>>


-- 
Best regards, Sergey.


From philip.race at oracle.com  Wed Jul 23 19:27:57 2014
From: philip.race at oracle.com (Phil Race)
Date: Wed, 23 Jul 2014 12:27:57 -0700
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
 cleanup of javax.sound.midi package
In-Reply-To: <53CF83EB.9010607@oracle.com>
References: <53C6AEC6.7050303@oracle.com>	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com>
Message-ID: <53D00CBD.90603@oracle.com>

I had started on this but there was a lot to wade through

Here 
http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html

you changed 'public static class Info' -> 'class Info'

This made me think. I presume the point is that a class nested within an 
interface
is implicitly static even if not declared so, so you removed it.
However I have no idea  if JCK signature tests will need to be updated.
I suggest you inquire.

You may want to correct the (pre-existing) spelling mistake
here before you push :-
http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html

48  * {@code MidiSystem.getTransmitter} is implementation-dependant unless the

dependant->dependent


Changes (like) this one surprised me too :-

http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html

So we add an import statement just to keep some javadoc tool happy ?
Was this from doclint ? Did you question whether that was really something
doclint should enforce rather than just allowing the fully qualified name ?

It wouldn't surprise me if some other tool were to consider this an 
un-used import
and delete it.

-phil

On 7/23/14 2:44 AM, Sergey Bylokhov wrote:
> Hello,
> Any volunteers to be a second reviewer?
>
> On 17.07.2014 12:18, Petr Pchelko wrote:
>> Hello, Sergey.
>>
>> The fix looks good to me.
>>
>> With best regards. Petr.
>>
>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov 
>> <Sergey.Bylokhov at oracle.com> wrote:
>>
>>> Hello.
>>> Please review another one javadoc cleanup in jdk 9 in sound area:
>>> - @param, @return should not end with a dot, except a case when more 
>>> than one sentences are used.
>>> - @param, @throws, @return now align, to be more readable.
>>> - @see tags simplified in some places.
>>> - Description of the class/method/field should be followed by dot.
>>> - Broken links/typos fixed
>>> - 80 column limit.
>>> - sets of spaces in the middle of text were deleted.
>>> - <tag> replaced by {@tag }.
>>> - unnecessary imports were removed.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>>> See the full specdiff: 
>>> http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>>
>>> -- 
>>> Best regards, Sergey.
>>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20140723/fef69c00/attachment.html>

From Sergey.Bylokhov at oracle.com  Wed Jul 23 19:45:51 2014
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 23 Jul 2014 23:45:51 +0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
 cleanup of javax.sound.midi package
In-Reply-To: <53D00CBD.90603@oracle.com>
References: <53C6AEC6.7050303@oracle.com>	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com> <53D00CBD.90603@oracle.com>
Message-ID: <53D010EF.4020100@oracle.com>

On 23.07.2014 23:27, Phil Race wrote:
> I had started on this but there was a lot to wade through
>
> Here 
> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
>
> you changed 'public static class Info' -> 'class Info'
>
> This made me think. I presume the point is that a class nested within 
> an interface
> is implicitly static even if not declared so, so you removed it.
Right.
> However I have no idea  if JCK signature tests will need to be updated.
> I suggest you inquire.
At least class file is not changed.
>
> You may want to correct the (pre-existing) spelling mistake
> here before you push :-
> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
> 48  * {@code MidiSystem.getTransmitter} is implementation-dependant unless the
>
> dependant->dependent
>
> Changes (like) this one surprised me too :-
>
> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html
>
> So we add an import statement just to keep some javadoc tool happy ?
No, it just to make a reader of this javadoc happy.
> Was this from doclint ? Did you question whether that was really something
> doclint should enforce rather than just allowing the fully qualified 
> name ?
>
> It wouldn't surprise me if some other tool were to consider this an 
> un-used import
> and delete it.
We had a bunch of unused imports in the past in these files, and now all 
of them are removed/used.  I guess, if some tool recognize this as 
unused import, it will be a bad tool.
>
> -phil
>
> On 7/23/14 2:44 AM, Sergey Bylokhov wrote:
>> Hello,
>> Any volunteers to be a second reviewer?
>>
>> On 17.07.2014 12:18, Petr Pchelko wrote:
>>> Hello, Sergey.
>>>
>>> The fix looks good to me.
>>>
>>> With best regards. Petr.
>>>
>>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov 
>>> <Sergey.Bylokhov at oracle.com> wrote:
>>>
>>>> Hello.
>>>> Please review another one javadoc cleanup in jdk 9 in sound area:
>>>> - @param, @return should not end with a dot, except a case when 
>>>> more than one sentences are used.
>>>> - @param, @throws, @return now align, to be more readable.
>>>> - @see tags simplified in some places.
>>>> - Description of the class/method/field should be followed by dot.
>>>> - Broken links/typos fixed
>>>> - 80 column limit.
>>>> - sets of spaces in the middle of text were deleted.
>>>> - <tag> replaced by {@tag }.
>>>> - unnecessary imports were removed.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>>>> See the full specdiff: 
>>>> http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
>>>> Webrev can be found at: 
>>>> http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>>>
>>>> -- 
>>>> Best regards, Sergey.
>>>>
>>
>>
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20140723/0b19f221/attachment.html>

From philip.race at oracle.com  Wed Jul 23 20:12:46 2014
From: philip.race at oracle.com (Phil Race)
Date: Wed, 23 Jul 2014 13:12:46 -0700
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
 cleanup of javax.sound.midi package
In-Reply-To: <53D010EF.4020100@oracle.com>
References: <53C6AEC6.7050303@oracle.com>	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com> <53D00CBD.90603@oracle.com>
	<53D010EF.4020100@oracle.com>
Message-ID: <53D0173E.2060801@oracle.com>

OK. Approved

-phil.

On 07/23/2014 12:45 PM, Sergey Bylokhov wrote:
> On 23.07.2014 23:27, Phil Race wrote:
>> I had started on this but there was a lot to wade through
>>
>> Here 
>> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
>>
>> you changed 'public static class Info' -> 'class Info'
>>
>> This made me think. I presume the point is that a class nested within 
>> an interface
>> is implicitly static even if not declared so, so you removed it.
> Right.
>> However I have no idea  if JCK signature tests will need to be updated.
>> I suggest you inquire.
> At least class file is not changed.
>>
>> You may want to correct the (pre-existing) spelling mistake
>> here before you push :-
>> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
>> 48  * {@code MidiSystem.getTransmitter} is implementation-dependant unless the
>>
>> dependant->dependent
>>
>> Changes (like) this one surprised me too :-
>>
>> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html
>>
>> So we add an import statement just to keep some javadoc tool happy ?
> No, it just to make a reader of this javadoc happy.
>> Was this from doclint ? Did you question whether that was really 
>> something
>> doclint should enforce rather than just allowing the fully qualified 
>> name ?
>>
>> It wouldn't surprise me if some other tool were to consider this an 
>> un-used import
>> and delete it.
> We had a bunch of unused imports in the past in these files, and now 
> all of them are removed/used.  I guess, if some tool recognize this as 
> unused import, it will be a bad tool.
>>
>> -phil
>>
>> On 7/23/14 2:44 AM, Sergey Bylokhov wrote:
>>> Hello,
>>> Any volunteers to be a second reviewer?
>>>
>>> On 17.07.2014 12:18, Petr Pchelko wrote:
>>>> Hello, Sergey.
>>>>
>>>> The fix looks good to me.
>>>>
>>>> With best regards. Petr.
>>>>
>>>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov 
>>>> <Sergey.Bylokhov at oracle.com> wrote:
>>>>
>>>>> Hello.
>>>>> Please review another one javadoc cleanup in jdk 9 in sound area:
>>>>> - @param, @return should not end with a dot, except a case when 
>>>>> more than one sentences are used.
>>>>> - @param, @throws, @return now align, to be more readable.
>>>>> - @see tags simplified in some places.
>>>>> - Description of the class/method/field should be followed by dot.
>>>>> - Broken links/typos fixed
>>>>> - 80 column limit.
>>>>> - sets of spaces in the middle of text were deleted.
>>>>> - <tag> replaced by {@tag }.
>>>>> - unnecessary imports were removed.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
>>>>> See the full specdiff: 
>>>>> http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html 
>>>>>
>>>>> Webrev can be found at: 
>>>>> http://cr.openjdk.java.net/~serb/8050852/webrev.02
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>>
>>>
>>>
>>
>
>
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20140723/110fc57c/attachment-0001.html>

From danrollo at gmail.com  Thu Jul 24 00:43:58 2014
From: danrollo at gmail.com (Dan Rollo)
Date: Wed, 23 Jul 2014 20:43:58 -0400
Subject: <Sound Dev> <AWT Dev> [9] Review Request: 8050852 Javadoc
	cleanup of javax.sound.midi package
In-Reply-To: <53D010EF.4020100@oracle.com>
References: <53C6AEC6.7050303@oracle.com>	<9D050722-1DF5-4A9A-BF5A-A1C847061D29@oracle.com>
	<53CF83EB.9010607@oracle.com> <53D00CBD.90603@oracle.com>
	<53D010EF.4020100@oracle.com>
Message-ID: <97091753-4135-43CC-8C8B-29FF5C09D26E@gmail.com>

It will likely not be an issue for these JDK classes, but I have seen compile errors for such imports in the past. The problem occurs when the ?javadoc only import? class is not available on the compile classpath (and it should not be, because it is not actually used).

Dan

On Jul 23, 2014, at 3:45 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> On 23.07.2014 23:27, Phil Race wrote:
>> I had started on this but there was a lot to wade through
>> 
>> Herehttp://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
>> 
>> you changed 'public static class Info' -> 'class Info'
>> 
>> This made me think. I presume the point is that a class nested within an interface
>> is implicitly static even if not declared so, so you removed it.
> Right.
>> However I have no idea  if JCK signature tests will need to be updated.
>> I suggest you inquire.
> At least class file is not changed.
>> 
>> You may want to correct the (pre-existing) spelling mistake
>> here before you push :-
>> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/midi/MidiDevice.java.sdiff.html
>> 48  * {@code MidiSystem.getTransmitter} is implementation-dependant unless the
>> 
>> dependant->dependent
>> 
>> Changes (like) this one surprised me too :-
>> 
>> http://cr.openjdk.java.net/~serb/8050852/webrev.02/src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java.sdiff.html
>> 
>> So we add an import statement just to keep some javadoc tool happy ?
> No, it just to make a reader of this javadoc happy.
>> Was this from doclint ? Did you question whether that was really something
>> doclint should enforce rather than just allowing the fully qualified name ?
>> 
>> It wouldn't surprise me if some other tool were to consider this an un-used import
>> and delete it.
> We had a bunch of unused imports in the past in these files, and now all of them are removed/used.  I guess, if some tool recognize this as unused import, it will be a bad tool.
>> 
>> -phil
>> 
>> On 7/23/14 2:44 AM, Sergey Bylokhov wrote:
>>> Hello, 
>>> Any volunteers to be a second reviewer? 
>>> 
>>> On 17.07.2014 12:18, Petr Pchelko wrote: 
>>>> Hello, Sergey. 
>>>> 
>>>> The fix looks good to me. 
>>>> 
>>>> With best regards. Petr. 
>>>> 
>>>> On 16 ???? 2014 ?., at 20:56, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote: 
>>>> 
>>>>> Hello. 
>>>>> Please review another one javadoc cleanup in jdk 9 in sound area: 
>>>>> - @param, @return should not end with a dot, except a case when more than one sentences are used. 
>>>>> - @param, @throws, @return now align, to be more readable. 
>>>>> - @see tags simplified in some places. 
>>>>> - Description of the class/method/field should be followed by dot. 
>>>>> - Broken links/typos fixed 
>>>>> - 80 column limit. 
>>>>> - sets of spaces in the middle of text were deleted. 
>>>>> - <tag> replaced by {@tag }. 
>>>>> - unnecessary imports were removed. 
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050852 
>>>>> See the full specdiff: http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html 
>>>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8050852/webrev.02 
>>>>> 
>>>>> -- 
>>>>> Best regards, Sergey. 
>>>>> 
>>> 
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey. 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20140723/f2e44861/attachment.html>