<Sound Dev> [9] Review Request: 8059743 Incorrect assumption in javax\sound\midi\Gervill\SoftProvider\GetDevice.java

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Aug 18 08:10:13 UTC 2015


  The fix looks good to me.

  Thanks,
  Alexandr.

On 8/17/2015 6:44 PM, alexey menkov wrote:
> Looks good.
>
> regards
> Alex
>
> On 17.08.2015 18:30, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk9.
>>
>> This test assume that null should be returned in case of unsupported
>> Info, but exception should be thrown instead[1].
>> In the fix I remove this assumption from this test and create a new one
>> which checks that in case of FakeInfo all our MidiDeviceProviders throw
>> a correct exception.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8059743
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8059743/webrev.00
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8058115
>>



More information about the sound-dev mailing list