<Sound Dev> [9] Review Request: Find and load default.sf2 as the default soundbank on Linux
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Tue Oct 27 09:51:58 UTC 2015
On 27.10.15 1:08, Omair Majid wrote:
> The updated webrev now uses `exists()` in the new code:
> http://cr.openjdk.java.net/~omajid/webrevs/linux-default-sf2/01/
>
> (FWIW, some existing code already uses isFile() in that class/method).
>
> I agree, but I would like to work on this as a separate patch. Most of
> the code that calls `exists()` then proceeds to use `new
> FileInputStream()` on the result, which will probably fail if it is a
> directory. But it needs to be handled as an exception correctly.
ok, this version looks fine.
--
Best regards, Sergey.
More information about the sound-dev
mailing list