<Sound Dev> [9] Review Request: 8160217 JavaSound should clean up resources better

Phil Race philip.race at oracle.com
Mon Aug 22 17:49:02 UTC 2016


+1 .. seems like this file "leakage" has been there since this code was 
introduced.

-phil.

On 08/22/2016 09:16 AM, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> This is a fix for a bug which was found by mach5. A number of tests 
> and one place in jdk, incorrectly releases the files streams for the 
> temporary files, which caused thousands of files in the tmp folder.
>
>  - The tests are updated, now when the temporary files are created the 
> fileoutput streams will be correctly closed. 
> File.delete()/File.deleteOnExit() were replaced by Files.delete() 
> which will throw an exception if file cannot be removed.
>  - The code in ModelByteBuffer.java was updated to close the stream 
> from which we read the data.
>
> No regressions were found by jtreg/jck tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8160217
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8160217/webrev.03/
>



More information about the sound-dev mailing list