<Sound Dev> [9] Review Request: 8131974 AudioFileReader incorrectly handle EOFException

Alex Menkov alexey.menkov at oracle.com
Tue Jan 12 11:45:03 UTC 2016


Looks good to me.

--alex

On 01.01.2016 18:26, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the fix for jdk9.
>
>      Our audio files readers widely use EOFException directly or
> indirectly via DataInputStream. This causes a problems when the file is
> small but some of our reader expect the big header, in this case we
> should check the next reader, but we fail with EOFException.
>
> +cleanup of the related methods in AudioSystem.java.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8131974
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8131974/webrev.00
>


More information about the sound-dev mailing list