<Sound Dev> [9] Review Request: 8168998 Incorrect implementation of equals in Encoding and Type in JavaSound

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Nov 1 17:03:26 UTC 2016


Hello, Audio Guru.

Please review the fix for jdk9.

AudioFormat.Encoding(null) and AudioFIleFormat.Type(null) equal to any 
objects which return null from toString().
Note that behavior of null in these constructors is not specified and 
can throw an exception.
I wonder why the null is accepted in the constructors, and returns from 
the toString() method, but not sure can we change that or not, any thoughts?

Bug: https://bugs.openjdk.java.net/browse/JDK-8168998
Webrev can be found at: http://cr.openjdk.java.net/~serb/8168998/webrev.00

-- 
Best regards, Sergey.


More information about the sound-dev mailing list