<Sound Dev> [9] Review Request: 8168998 Incorrect implementation of equals in Encoding and Type in JavaSound

[Alex Menkov]

+1

On 01.11.2016 22:25, Phil Race wrote:
> +1
>
> -phil
>
> On 11/01/2016 10:03 AM, Sergey Bylokhov wrote:
>> Hello, Audio Guru.
>>
>> Please review the fix for jdk9.
>>
>> AudioFormat.Encoding(null) and AudioFIleFormat.Type(null) equal to any
>> objects which return null from toString().
>> Note that behavior of null in these constructors is not specified and
>> can throw an exception.
>> I wonder why the null is accepted in the constructors, and returns
>> from the toString() method, but not sure can we change that or not,
>> any thoughts?

I don't have an idea what was the reason to implement if this way.
This is very old code.

--alex


>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8168998
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8168998/webrev.00
>>
>