<Sound Dev> [9] Review Request: 8167028 SunCodec.java can be removed
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Mon Oct 3 14:45:00 UTC 2016
Hello, Audio Guru.
This is a request to small cleanup of the classes related to
FormatConversionProvider.
- SunCodec.java is removed. It was used as a parent class for other
providers, but it contained only the methods to clone the array of
supported formats. But we can have the same functionality if instead of
cloning the array just create the new one each time it will be requested.
- All our providers supports the same encodings as input and output.
So getTargetEncodings() can be implemented via getSourceEncodings();
- FormatConversionProvider contains a few methods to filter, search
the data in arrays, and this functionality can be simplified by Stream API.
No regressions were found by jtreg/jck tests.
Bug: https://bugs.openjdk.java.net/browse/JDK-8167028
Webrev can be found at: http://cr.openjdk.java.net/~serb/8167028/webrev.00
--
Best regards, Sergey.
More information about the sound-dev
mailing list