<Sound Dev> [9] Review Request: 8167435 IllegalArgumentException is not thrown by Clip.open(AudioFormat, byte[], int, int)

[Sergey Bylokhov]

Thanks everyone!

On 13.10.16 1:16, Florian Bomers wrote:
> +1
> Best, Florian
>
> On 11.10.2016 13:36, Alex Menkov wrote:
>> Looks good.
>>
>> --alex
>>
>> On 10.10.2016 20:35, Sergey Bylokhov wrote:
>>> Hello, Audio Guru.
>>>
>>> Please review the fix for jdk9.
>>>
>>> According the specification of Clip.open(AudioFormat,byte[], int, int):
>>>      * @throws IllegalArgumentException if the buffer size does not
>>> represent an
>>>      * integral number of sample frames
>>>      */
>>>     void open(AudioFormat format, byte[] data, int offset, int
>>> bufferSize)
>>>
>>> We have two implementations of the Clip.
>>>  - In SoftMixingClip  exception is thrown
>>>  - In DirectAudioDevice  exception is not thrown
>>>
>>> DirectAudioDevice was fixed, the check was moved to the utility method.
>>>
>>> No regressions were found by jtreg/jck tests.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8167435/webrev.00
>>>
>>
>


-- 
Best regards, Sergey.