<Sound Dev> [9] Review Request: 6574989 TEST_BUG: javax/sound/sampled/Clip/bug5070081.java fails sometimes

Sergey Bylokhov sergey.bylokhov at oracle.com
Wed Mar 22 12:48:39 UTC 2017


It was added during debugging and unused in final version.
Fixed:
http://cr.openjdk.java.net/~serb/6574989/webrev.02/

> 21 марта 2017 г., в 23:36, Dan Rollo <danrollo at gmail.com> написал(а):
> 
> Hi Sergey,
> 
> Minor: Why the import of CountDownLatch? I don’t see where it is used.
> 
> import java.util.concurrent.CountDownLatch;
> 
> -Dan
> 
>> On Mar 21, 2017, at 9:38 AM, Sergey Bylokhov <sergey.bylokhov at oracle.com> wrote:
>> 
>> Hello, Audio Guru.
>> 
>> Please review the fix for the test in jdk9
>> 
>> The test tries to check that the Clip.close() method does not lose some audio data(position).
>> It assumes that the time spent in the Clip.close() should be: realtime + 50 ms > time in the close();
>> 
>> But time in the close methods is calculated incorrectly because position is 22050 frames per second(22.05 per ms). So the test should convert frames to ms first.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6574989
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/6574989/webrev.01
> 



More information about the sound-dev mailing list