From sergey.bylokhov at oracle.com  Fri May  5 01:15:25 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 4 May 2017 18:15:25 -0700 (PDT)
Subject: <Sound Dev> [9] Review Request: 8179596 Update java.desktop to be
	HTML-5 friendly
Message-ID: <5d4c5a0d-04dd-4a1f-aabe-3e3c85fa3be8@default>

Hello,
Please review the fix for jdk9-dev.
This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5.

In the fix the most common issues are fixed.
The issues related to tables will be fixed later, because it is depends from the new html styles which are under review[1].

After the fix the number of errors reported during the build in java.desktop module decreased from 300+ to 110.

Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
Webrev can be found at: http://cr.openjdk.java.net/~serb/8179596/webrev.00
Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00

[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html

From philip.race at oracle.com  Fri May  5 17:07:59 2017
From: philip.race at oracle.com (Phil Race)
Date: Fri, 5 May 2017 10:07:59 -0700
Subject: <Sound Dev> [9] Review Request: 8178383 Validation of FileIO in
 the tests for JavaSound should be stricter
In-Reply-To: <F8D49D7C-B34F-4115-B92D-8E42E1FA7F49@oracle.com>
References: <F8D49D7C-B34F-4115-B92D-8E42E1FA7F49@oracle.com>
Message-ID: <c65802b6-d26a-0db0-21ed-be1a8cb1d223@oracle.com>

+1

-phil.

On 04/11/2017 04:30 AM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8178383
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8178383/webrev.01 
> <http://cr.openjdk.java.net/%7Eserb/8178383/webrev.01>
>
> This fix make our tests striker when the files input/output is used.
> All temporary files now will be removed by Files.delete() which throws 
> an exception if the file is locked (instead of File.deleteOnExit() and 
> File.delete())
>
> The updated tests found a new bug on Windows JDK-8178401[1], it was 
> added to ProblemList.txt.
> One more test were added to ProblemList.txt because I found bug [2] 
> which is unrelated to this one, but since I updates ProblemList.txt I 
> added it also.
>
> Both new bugs will be fixed in jdk10 since we have RDP2 [3] in jdk9.
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8178401
> [2] https://bugs.openjdk.java.net/browse/JDK-8178403
> [3] http://openjdk.java.net/projects/jdk9/rdp-2

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20170505/fcd3ff4d/attachment.html>

From alexey.menkov at oracle.com  Fri May  5 17:43:58 2017
From: alexey.menkov at oracle.com (Alex Menkov)
Date: Fri, 5 May 2017 10:43:58 -0700
Subject: <Sound Dev> [9] Review Request: 8179596 Update java.desktop to
 be HTML-5 friendly
In-Reply-To: <5d4c5a0d-04dd-4a1f-aabe-3e3c85fa3be8@default>
References: <5d4c5a0d-04dd-4a1f-aabe-3e3c85fa3be8@default>
Message-ID: <e0795dbe-5529-89be-43fa-ffd0b55156d2@oracle.com>

Overall looks good.
One minor point - there are several places when you replace <center> 
with <p> without end </p>.
Usually absent </p> doesn't cause any problem, but it would be better to 
have end tags for all elements.

I see this in
src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
src/java.desktop/share/classes/javax/swing/SizeSequence.java

--alex

On 05/04/2017 18:15, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9-dev.
> This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5.
>
> In the fix the most common issues are fixed.
> The issues related to tables will be fixed later, because it is depends from the new html styles which are under review[1].
>
> After the fix the number of errors reported during the build in java.desktop module decreased from 300+ to 110.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8179596/webrev.00
> Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
>
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html
>

From sergey.bylokhov at oracle.com  Fri May  5 19:37:17 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 5 May 2017 12:37:17 -0700 (PDT)
Subject: <Sound Dev> [9] Review Request: 8179596 Update java.desktop to
 be HTML-5 friendly
Message-ID: <e2e40bf4-9f2f-46f2-86a8-1ceca25e23e6@default>

Hi, Alexey.
Yes it is possible to add </p> to this changes, but actually </p> tag is not used in JavaSound docs. The last one were removed a few years ago. The <p> tag is used in assumption that it affect the text till the next <p> or till the end of the doc.
So for example in the MidiMessage.java/SizeSequence.java there are a few <p> tags which affects the text till the next <p>, and in this fix just one more <p> was added in the middle.

----- alexey.menkov at oracle.com wrote:

> Overall looks good.
> One minor point - there are several places when you replace <center> 
> with <p> without end </p>.
> Usually absent </p> doesn't cause any problem, but it would be better
> to 
> have end tags for all elements.
> 
> I see this in
> src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
> src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
> src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
> src/java.desktop/share/classes/javax/swing/SizeSequence.java
> 
> --alex
> 
> On 05/04/2017 18:15, Sergey Bylokhov wrote:
> > Hello,
> > Please review the fix for jdk9-dev.
> > This fix is a part of the effort to make all javadoc in jdk9 be
> compatible to HTML5.
> >
> > In the fix the most common issues are fixed.
> > The issues related to tables will be fixed later, because it is
> depends from the new html styles which are under review[1].
> >
> > After the fix the number of errors reported during the build in
> java.desktop module decreased from 300+ to 110.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
> > Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8179596/webrev.00
> > Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
> >
> > [1]
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html
> >

From philip.race at oracle.com  Fri May  5 20:02:16 2017
From: philip.race at oracle.com (Phil Race)
Date: Fri, 5 May 2017 13:02:16 -0700
Subject: <Sound Dev> [9] Review Request: 8179596 Update java.desktop to
 be HTML-5 friendly
In-Reply-To: <5d4c5a0d-04dd-4a1f-aabe-3e3c85fa3be8@default>
References: <5d4c5a0d-04dd-4a1f-aabe-3e3c85fa3be8@default>
Message-ID: <ac772f7e-e131-9811-b67f-f3ebe54b7f15@oracle.com>

This all looks OK to me.

-phil.

On 05/04/2017 06:15 PM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9-dev.
> This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5.
>
> In the fix the most common issues are fixed.
> The issues related to tables will be fixed later, because it is depends from the new html styles which are under review[1].
>
> After the fix the number of errors reported during the build in java.desktop module decreased from 300+ to 110.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8179596/webrev.00
> Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
>
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html


From alexey.menkov at oracle.com  Fri May  5 21:21:33 2017
From: alexey.menkov at oracle.com (Alex Menkov)
Date: Fri, 5 May 2017 14:21:33 -0700
Subject: <Sound Dev> [9] Review Request: 8179596 Update java.desktop to
 be HTML-5 friendly
In-Reply-To: <e2e40bf4-9f2f-46f2-86a8-1ceca25e23e6@default>
References: <e2e40bf4-9f2f-46f2-86a8-1ceca25e23e6@default>
Message-ID: <33a88ff4-de38-90ff-576e-d073ec360ab7@oracle.com>

Okay,

Then +1 to Phil's approval

--alex

On 05/05/2017 12:37, Sergey Bylokhov wrote:
> Hi, Alexey.
> Yes it is possible to add </p> to this changes, but actually </p> tag is not used in JavaSound docs. The last one were removed a few years ago. The <p> tag is used in assumption that it affect the text till the next <p> or till the end of the doc.
> So for example in the MidiMessage.java/SizeSequence.java there are a few <p> tags which affects the text till the next <p>, and in this fix just one more <p> was added in the middle.
>
> ----- alexey.menkov at oracle.com wrote:
>
>> Overall looks good.
>> One minor point - there are several places when you replace <center>
>> with <p> without end </p>.
>> Usually absent </p> doesn't cause any problem, but it would be better
>> to
>> have end tags for all elements.
>>
>> I see this in
>> src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
>> src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
>> src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
>> src/java.desktop/share/classes/javax/swing/SizeSequence.java
>>
>> --alex
>>
>> On 05/04/2017 18:15, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk9-dev.
>>> This fix is a part of the effort to make all javadoc in jdk9 be
>> compatible to HTML5.
>>>
>>> In the fix the most common issues are fixed.
>>> The issues related to tables will be fixed later, because it is
>> depends from the new html styles which are under review[1].
>>>
>>> After the fix the number of errors reported during the build in
>> java.desktop module decreased from 300+ to 110.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
>>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8179596/webrev.00
>>> Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
>>>
>>> [1]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html
>>>

From sergey.bylokhov at oracle.com  Fri May 12 23:25:08 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 12 May 2017 16:25:08 -0700 (PDT)
Subject: <Sound Dev> [9] Review Request: 8180326 Update the tables in
 java.desktop to be HTML-5 friendly
Message-ID: <d542b7bf-08e9-44ea-befb-329956eab69a@default>

Hello,
Please review the fix for jdk9-dev.

This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5.
It covers all errors which are reported by the javadoc tool during the build of jdk for java.desktop module.

Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
Webrev can be found at: http://cr.openjdk.java.net/~serb/8180326/webrev.01

Note that an appearance of some tables were changed after the fix:

Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
After: http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html

Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
After : http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html

Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
After: http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html

From philip.race at oracle.com  Fri May 12 23:36:39 2017
From: philip.race at oracle.com (Philip Race)
Date: Fri, 12 May 2017 16:36:39 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <d542b7bf-08e9-44ea-befb-329956eab69a@default>
References: <d542b7bf-08e9-44ea-befb-329956eab69a@default>
Message-ID: <59164707.7040605@oracle.com>

Adding 2d-dev because a number of the files are 2D.

What is the general reason for changing the appearance of the tables?

-phil.

On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9-dev.
>
> This fix is a part of the effort to make all javadoc in jdk9 be compatible to HTML5.
> It covers all errors which are reported by the javadoc tool during the build of jdk for java.desktop module.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8180326/webrev.01
>
> Note that an appearance of some tables were changed after the fix:
>
> Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> After: http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
>
> Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
> After : http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
>
> Before: http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
> After: http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html

From sergey.bylokhov at oracle.com  Fri May 12 23:52:06 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 12 May 2017 16:52:06 -0700 (PDT)
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
Message-ID: <f42480bd-df84-48d4-a062-da030d9a4fb7@default>

This is because I use the same style for most of the tables 'class="striped"', which apply the same/unified style for all(most) of our tables.
Also this is because I removed 'inlined' styles, like here:
http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html

----- philip.race at oracle.com wrote:

> Adding 2d-dev because a number of the files are 2D.
> 
> What is the general reason for changing the appearance of the tables?
> 
> -phil.
> 
> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> > Hello,
> > Please review the fix for jdk9-dev.
> >
> > This fix is a part of the effort to make all javadoc in jdk9 be
> compatible to HTML5.
> > It covers all errors which are reported by the javadoc tool during
> the build of jdk for java.desktop module.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
> > Webrev can be found at:
> http://cr.openjdk.java.net/~serb/8180326/webrev.01
> >
> > Note that an appearance of some tables were changed after the fix:
> >
> > Before:
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> > After:
> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
> >
> > Before:
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
> > After :
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
> >
> > Before:
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
> > After:
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html

From philip.race at oracle.com  Fri May 12 23:54:09 2017
From: philip.race at oracle.com (Philip Race)
Date: Fri, 12 May 2017 16:54:09 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <f42480bd-df84-48d4-a062-da030d9a4fb7@default>
References: <f42480bd-df84-48d4-a062-da030d9a4fb7@default>
Message-ID: <59164B21.3050803@oracle.com>

Does this in any way match the rest of the docs ? Or is everyone left to 
style things how they want.
I thought (?) maybe there is to be some javadoc tool support for CSS styles.

Also why are all the table summaries removed ?

-phil.

On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
> This is because I use the same style for most of the tables 'class="striped"', which apply the same/unified style for all(most) of our tables.
> Also this is because I removed 'inlined' styles, like here:
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
>
> ----- philip.race at oracle.com wrote:
>
>> Adding 2d-dev because a number of the files are 2D.
>>
>> What is the general reason for changing the appearance of the tables?
>>
>> -phil.
>>
>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk9-dev.
>>>
>>> This fix is a part of the effort to make all javadoc in jdk9 be
>> compatible to HTML5.
>>> It covers all errors which are reported by the javadoc tool during
>> the build of jdk for java.desktop module.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>> Note that an appearance of some tables were changed after the fix:
>>>
>>> Before:
>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
>>> After:
>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
>>> Before:
>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
>>> After :
>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
>>> Before:
>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
>>> After:
>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html

From sergey.bylokhov at oracle.com  Sat May 13 00:00:30 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 12 May 2017 17:00:30 -0700 (PDT)
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
Message-ID: <cc06639b-5267-4b26-a487-e05aaf40879c@default>

The "summary" is unsupported by the HTML5 and we replace it by invisible caption.
These new styles are located in the stylesheet.css in the root of the JavaDoc api folder, so I assume these styles should be used by others as well.
They were added by this fix:
https://bugs.openjdk.java.net/browse/JDK-8179479

----- philip.race at oracle.com wrote:

> Does this in any way match the rest of the docs ? Or is everyone left
> to 
> style things how they want.
> I thought (?) maybe there is to be some javadoc tool support for CSS
> styles.
> 
> Also why are all the table summaries removed ?
> 
> -phil.
> 
> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
> > This is because I use the same style for most of the tables
> 'class="striped"', which apply the same/unified style for all(most) of
> our tables.
> > Also this is because I removed 'inlined' styles, like here:
> >
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> >
> > ----- philip.race at oracle.com wrote:
> >
> >> Adding 2d-dev because a number of the files are 2D.
> >>
> >> What is the general reason for changing the appearance of the
> tables?
> >>
> >> -phil.
> >>
> >> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> >>> Hello,
> >>> Please review the fix for jdk9-dev.
> >>>
> >>> This fix is a part of the effort to make all javadoc in jdk9 be
> >> compatible to HTML5.
> >>> It covers all errors which are reported by the javadoc tool
> during
> >> the build of jdk for java.desktop module.
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
> >>> Webrev can be found at:
> >> http://cr.openjdk.java.net/~serb/8180326/webrev.01
> >>> Note that an appearance of some tables were changed after the
> fix:
> >>>
> >>> Before:
> >>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> >>> After:
> >>
> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
> >>> Before:
> >>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
> >>> After :
> >>
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
> >>> Before:
> >>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
> >>> After:
> >>
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html

From philip.race at oracle.com  Sat May 13 00:03:38 2017
From: philip.race at oracle.com (Philip Race)
Date: Fri, 12 May 2017 17:03:38 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <59164C3F.8070606@oracle.com>
References: <f42480bd-df84-48d4-a062-da030d9a4fb7@default>
 <59164B21.3050803@oracle.com> <59164C3F.8070606@oracle.com>
Message-ID: <59164D5A.60200@oracle.com>



On 5/12/17, 4:58 PM, Jonathan Gibbons wrote:
> Phil,
>
> 1. javadoc now provides support for 3 named styles in the default 
> stylesheet:
>         borderless:  no borders
>         plain:  simple 1px borders around tables and cells
>         striped: reduced borders; rows have alternating white and 
> light grey backgrounds
>
OK .. I see these being used.
>
> 2. summary attributes are not legal in HTML 5.
>     For accessibility reasons, you should consider having a table 
> caption instead.

OK. I saw these but I wasn't clear it was a direct replacement. HTML 5 
sometimes
seems to be different just to be different ..

-phil.
>
> -- Jon
>
>
> On 05/12/2017 04:54 PM, Philip Race wrote:
>> Does this in any way match the rest of the docs ? Or is everyone left 
>> to style things how they want.
>> I thought (?) maybe there is to be some javadoc tool support for CSS 
>> styles.
>>
>> Also why are all the table summaries removed ?
>>
>> -phil.
>>
>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>> This is because I use the same style for most of the tables 
>>> 'class="striped"', which apply the same/unified style for all(most) 
>>> of our tables.
>>> Also this is because I removed 'inlined' styles, like here:
>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>
>>>
>>> ----- philip.race at oracle.com wrote:
>>>
>>>> Adding 2d-dev because a number of the files are 2D.
>>>>
>>>> What is the general reason for changing the appearance of the tables?
>>>>
>>>> -phil.
>>>>
>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>> Hello,
>>>>> Please review the fix for jdk9-dev.
>>>>>
>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>> compatible to HTML5.
>>>>> It covers all errors which are reported by the javadoc tool during
>>>> the build of jdk for java.desktop module.
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>> Webrev can be found at:
>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>> Note that an appearance of some tables were changed after the fix:
>>>>>
>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>
>>>>> After:
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>>
>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>>
>>>>> After :
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>>
>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>>
>>>>> After:
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>>
>

From joe.darcy at oracle.com  Tue May 16 23:17:30 2017
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Tue, 16 May 2017 16:17:30 -0700
Subject: <Sound Dev> JDK 9 RFR of JDK-8180452: Mark ClipCloseLoss.java as
	failing intermittently
Message-ID: <591B888A.3020207@oracle.com>

Hello,

The test

javax/sound/sampled/Clip/ClipCloseLoss.java

has been seen to fail intermittently (JDK-8178403) and should be marked 
accordingly.

Please review the patch below which does this.

Thanks,

-Joe

diff -r ef9954f6896b test/javax/sound/sampled/Clip/ClipCloseLoss.java
--- a/test/javax/sound/sampled/Clip/ClipCloseLoss.java    Tue May 16 
09:42:38 2017 -0400
+++ b/test/javax/sound/sampled/Clip/ClipCloseLoss.java    Tue May 16 
16:15:06 2017 -0700
@@ -36,6 +36,7 @@
   * @bug 4946913
   * @summary DirectClip doesn't kill the thread correctly, sometimes
   * @run main/othervm ClipCloseLoss
+ * @key intermittent
   */
  public class ClipCloseLoss {
      static int frameCount = 441000; // lets say 10 seconds

From sergey.bylokhov at oracle.com  Tue May 16 23:40:17 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 16 May 2017 16:40:17 -0700 (PDT)
Subject: <Sound Dev> JDK 9 RFR of JDK-8180452: Mark ClipCloseLoss.java
 as failing intermittently
Message-ID: <40832c21-4e59-46ba-97f3-c5cca19c50d8@default>

Hi, Joe.
Is that correct that this test will be marked in problemList and via "@key intermittent" tag?

----- joe.darcy at oracle.com wrote:

> Hello,
> 
> The test
> 
> javax/sound/sampled/Clip/ClipCloseLoss.java
> 
> has been seen to fail intermittently (JDK-8178403) and should be
> marked 
> accordingly.
> 
> Please review the patch below which does this.
> 
> Thanks,
> 
> -Joe
> 
> diff -r ef9954f6896b test/javax/sound/sampled/Clip/ClipCloseLoss.java
> --- a/test/javax/sound/sampled/Clip/ClipCloseLoss.java    Tue May 16 
> 09:42:38 2017 -0400
> +++ b/test/javax/sound/sampled/Clip/ClipCloseLoss.java    Tue May 16 
> 16:15:06 2017 -0700
> @@ -36,6 +36,7 @@
>    * @bug 4946913
>    * @summary DirectClip doesn't kill the thread correctly, sometimes
>    * @run main/othervm ClipCloseLoss
> + * @key intermittent
>    */
>   public class ClipCloseLoss {
>       static int frameCount = 441000; // lets say 10 seconds

From joe.darcy at oracle.com  Tue May 16 23:48:57 2017
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Tue, 16 May 2017 16:48:57 -0700
Subject: <Sound Dev> JDK 9 RFR of JDK-8180452: Mark ClipCloseLoss.java
 as failing intermittently
In-Reply-To: <40832c21-4e59-46ba-97f3-c5cca19c50d8@default>
References: <40832c21-4e59-46ba-97f3-c5cca19c50d8@default>
Message-ID: <591B8FE9.1050700@oracle.com>

Hi Sergey,

On 5/16/2017 4:40 PM, Sergey Bylokhov wrote:
> Hi, Joe.
> Is that correct that this test will be marked in problemList and via "@key intermittent" tag?
>
>

I wasn't proposing to problem list the test, but that is a possible 
approach too.

If the test is labeled as "@key intermittent", that is following the 
tiered testing policy:

     "Proposed new policies for JDK 9 regression tests: tiered testing, 
intermittent failures, and randomness,"
http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html

     "Proposed new policies for JDK 9 regression tests: tiered testing, 
intermittent failures, and randomness,"
http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-April/002164.html

and assists some of the automated analysis of test failures.

HTH,

-Joe

From sergey.bylokhov at oracle.com  Tue May 16 23:51:54 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 16 May 2017 16:51:54 -0700 (PDT)
Subject: <Sound Dev> JDK 9 RFR of JDK-8180452: Mark ClipCloseLoss.java
 as failing intermittently
Message-ID: <d75720da-19bb-47ca-add3-850f0031859b@default>

> I wasn't proposing to problem list the test, but that is a possible 
> approach too.

Actually it is already there:
http://hg.openjdk.java.net/jdk9/client/jdk/file/828d3f3728a2/test/ProblemList.txt

But I do not see a problem to mark it as intermittent, so +1.

From joe.darcy at oracle.com  Tue May 16 23:56:43 2017
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Tue, 16 May 2017 16:56:43 -0700
Subject: <Sound Dev> JDK 9 RFR of JDK-8180452: Mark ClipCloseLoss.java
 as failing intermittently
In-Reply-To: <d75720da-19bb-47ca-add3-850f0031859b@default>
References: <d75720da-19bb-47ca-add3-850f0031859b@default>
Message-ID: <591B91BB.9050900@oracle.com>

On 5/16/2017 4:51 PM, Sergey Bylokhov wrote:
>> I wasn't proposing to problem list the test, but that is a possible
>> approach too.
> Actually it is already there:
> http://hg.openjdk.java.net/jdk9/client/jdk/file/828d3f3728a2/test/ProblemList.txt
>
> But I do not see a problem to mark it as intermittent, so +1.

Ah, I was looking in jdk9/dev rather than the jdk9/client. The change to 
add the intermittent keyword complimentary to having the test on the 
problem list and I think there is some value in marking it as 
intermittent until the next client integration so I'll go ahead with the 
push.

Thanks,

-Joe

From philip.race at oracle.com  Wed May 17 18:19:01 2017
From: philip.race at oracle.com (Phil Race)
Date: Wed, 17 May 2017 11:19:01 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <59164F29.8070300@oracle.com>
References: <cc06639b-5267-4b26-a487-e05aaf40879c@default>
 <59164F29.8070300@oracle.com>
Message-ID: <635d9ffc-bb5d-2a4e-273f-4b477caa7239@oracle.com>

I am not sure we are using the summary in a way that  makes it worthwhile.
As you noted in the other mail
"The summary attribute was used to give a more descriptive value
of the contents of the table.   A caption is more like a title"

The values I see are more like a title and as you say that is not the 
idea. See the example here

https://www.w3.org/TR/WCAG20-TECHS/H73.html

Caption sounds like a title so it might actually be more appropriate 
than summary
for the text we have except that its not clear why we'd want it to be 
visible when we were fine without.

But being there and invisible may be pointless unless screen readers 
look for it even if invisible.

But if its not doing any harm I guess we can leave it as proposed

I still need to look at the rest of the changes.

-phil.

On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
> Sergey,
>
> FWIW, the invisible caption should be regarded as a temporary 
> solution, until content authors can review/update the text of the 
> caption and make it visible.
>
> The general guideline in this conversion work has been to avoid 
> changing the visible text of the specification, and captions fall into 
> a grey area of whether the text is significant/normative or not.  
> Hence the temporary step to make them not displayed for now.
>
> -- Jon
>
> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
>> The "summary" is unsupported by the HTML5 and we replace it by 
>> invisible caption.
>> These new styles are located in the stylesheet.css in the root of the 
>> JavaDoc api folder, so I assume these styles should be used by others 
>> as well.
>> They were added by this fix:
>> https://bugs.openjdk.java.net/browse/JDK-8179479
>>
>> ----- philip.race at oracle.com wrote:
>>
>>> Does this in any way match the rest of the docs ? Or is everyone left
>>> to
>>> style things how they want.
>>> I thought (?) maybe there is to be some javadoc tool support for CSS
>>> styles.
>>>
>>> Also why are all the table summaries removed ?
>>>
>>> -phil.
>>>
>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>>> This is because I use the same style for most of the tables
>>> 'class="striped"', which apply the same/unified style for all(most) of
>>> our tables.
>>>> Also this is because I removed 'inlined' styles, like here:
>>>>
>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>
>>>> ----- philip.race at oracle.com wrote:
>>>>
>>>>> Adding 2d-dev because a number of the files are 2D.
>>>>>
>>>>> What is the general reason for changing the appearance of the
>>> tables?
>>>>> -phil.
>>>>>
>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>>> Hello,
>>>>>> Please review the fix for jdk9-dev.
>>>>>>
>>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>>> compatible to HTML5.
>>>>>> It covers all errors which are reported by the javadoc tool
>>> during
>>>>> the build of jdk for java.desktop module.
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>>> Webrev can be found at:
>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>>> Note that an appearance of some tables were changed after the
>>> fix:
>>>>>> Before:
>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>
>>>>>> After:
>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>
>>>>>> Before:
>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>
>>>>>> After :
>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>
>>>>>> Before:
>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>
>>>>>> After:
>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>
>


From philip.race at oracle.com  Wed May 17 18:52:04 2017
From: philip.race at oracle.com (Phil Race)
Date: Wed, 17 May 2017 11:52:04 -0700
Subject: <Sound Dev> [OpenJDK 2D-Dev] <Swing Dev> [9] Review Request:
 8180326 Update the tables in java.desktop to be HTML-5 friendly
In-Reply-To: <635d9ffc-bb5d-2a4e-273f-4b477caa7239@oracle.com>
References: <cc06639b-5267-4b26-a487-e05aaf40879c@default>
 <59164F29.8070300@oracle.com>
 <635d9ffc-bb5d-2a4e-273f-4b477caa7239@oracle.com>
Message-ID: <5322c0d0-1ce4-10e8-e9e0-df305420274c@oracle.com>

I've looked through all the files now. No other comments. So approved.

-phil.

On 05/17/2017 11:19 AM, Phil Race wrote:
> I am not sure we are using the summary in a way that makes it worthwhile.
> As you noted in the other mail
> "The summary attribute was used to give a more descriptive value
> of the contents of the table.   A caption is more like a title"
>
> The values I see are more like a title and as you say that is not the 
> idea. See the example here
>
> https://www.w3.org/TR/WCAG20-TECHS/H73.html
>
> Caption sounds like a title so it might actually be more appropriate 
> than summary
> for the text we have except that its not clear why we'd want it to be 
> visible when we were fine without.
>
> But being there and invisible may be pointless unless screen readers 
> look for it even if invisible.
>
> But if its not doing any harm I guess we can leave it as proposed
>
> I still need to look at the rest of the changes.
>
> -phil.
>
> On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
>> Sergey,
>>
>> FWIW, the invisible caption should be regarded as a temporary 
>> solution, until content authors can review/update the text of the 
>> caption and make it visible.
>>
>> The general guideline in this conversion work has been to avoid 
>> changing the visible text of the specification, and captions fall 
>> into a grey area of whether the text is significant/normative or 
>> not.  Hence the temporary step to make them not displayed for now.
>>
>> -- Jon
>>
>> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
>>> The "summary" is unsupported by the HTML5 and we replace it by 
>>> invisible caption.
>>> These new styles are located in the stylesheet.css in the root of 
>>> the JavaDoc api folder, so I assume these styles should be used by 
>>> others as well.
>>> They were added by this fix:
>>> https://bugs.openjdk.java.net/browse/JDK-8179479
>>>
>>> ----- philip.race at oracle.com wrote:
>>>
>>>> Does this in any way match the rest of the docs ? Or is everyone left
>>>> to
>>>> style things how they want.
>>>> I thought (?) maybe there is to be some javadoc tool support for CSS
>>>> styles.
>>>>
>>>> Also why are all the table summaries removed ?
>>>>
>>>> -phil.
>>>>
>>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>>>> This is because I use the same style for most of the tables
>>>> 'class="striped"', which apply the same/unified style for all(most) of
>>>> our tables.
>>>>> Also this is because I removed 'inlined' styles, like here:
>>>>>
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>
>>>>> ----- philip.race at oracle.com wrote:
>>>>>
>>>>>> Adding 2d-dev because a number of the files are 2D.
>>>>>>
>>>>>> What is the general reason for changing the appearance of the
>>>> tables?
>>>>>> -phil.
>>>>>>
>>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>>>> Hello,
>>>>>>> Please review the fix for jdk9-dev.
>>>>>>>
>>>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>>>> compatible to HTML5.
>>>>>>> It covers all errors which are reported by the javadoc tool
>>>> during
>>>>>> the build of jdk for java.desktop module.
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>>>> Webrev can be found at:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>>>> Note that an appearance of some tables were changed after the
>>>> fix:
>>>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>
>>>>>>> After:
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>>
>>>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>>
>>>>>>> After :
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>>
>>>>>>> Before:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>>
>>>>>>> After:
>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>>
>>
>


From philip.race at oracle.com  Wed May 17 18:54:42 2017
From: philip.race at oracle.com (Phil Race)
Date: Wed, 17 May 2017 11:54:42 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <591C9BE9.1080905@oracle.com>
References: <cc06639b-5267-4b26-a487-e05aaf40879c@default>
 <59164F29.8070300@oracle.com>
 <635d9ffc-bb5d-2a4e-273f-4b477caa7239@oracle.com>
 <591C9BE9.1080905@oracle.com>
Message-ID: <14e7746f-b3a6-7310-1b3a-e1196acf96d8@oracle.com>

I will leave the decision on whether to do that now up to Sergey although
it seems all he has to do here is remove "invisible".
Many of the "summary" ones had wrong or misleading text but they
seem to have been all fixed.

I'd want to see what the new HTML looks like with a visible title of 
course ..

-phil.

On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
> Phil,
>
> The bottom line is that in the JDK docs, tables should not have a 
> summary attribute and should have a caption. This comes down to 
> accessibility requirements, where we are slowly raising the bar on our 
> docs, to be in accordance with Oracle's guidelines.
>
> Hiding the caption (style="display:none") is an interim measure we 
> have been using during the HTML 5 updates, especially in cases where 
> the person doing the markup changes did not know enough to create an 
> appropriate caption that should be displayed. In time, we should 
> locate and update all table captions (in our standard docs bundle) 
> that are not being displayed such that the text is both appropriate 
> and visible.  If you guys want to do that as part of this update, go 
> ahead.  FWIW, that is what we did for the java.xml module in the jaxp 
> repo ... pretty much all tables there now have a reasonable, visible 
> caption.
>
> -- Jon
>
>
>
> On 05/17/2017 11:19 AM, Phil Race wrote:
>> I am not sure we are using the summary in a way that makes it 
>> worthwhile.
>> As you noted in the other mail
>> "The summary attribute was used to give a more descriptive value
>> of the contents of the table.   A caption is more like a title"
>>
>> The values I see are more like a title and as you say that is not the 
>> idea. See the example here
>>
>> https://www.w3.org/TR/WCAG20-TECHS/H73.html
>>
>> Caption sounds like a title so it might actually be more appropriate 
>> than summary
>> for the text we have except that its not clear why we'd want it to be 
>> visible when we were fine without.
>>
>> But being there and invisible may be pointless unless screen readers 
>> look for it even if invisible.
>>
>> But if its not doing any harm I guess we can leave it as proposed
>>
>> I still need to look at the rest of the changes.
>>
>> -phil.
>>
>> On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
>>> Sergey,
>>>
>>> FWIW, the invisible caption should be regarded as a temporary 
>>> solution, until content authors can review/update the text of the 
>>> caption and make it visible.
>>>
>>> The general guideline in this conversion work has been to avoid 
>>> changing the visible text of the specification, and captions fall 
>>> into a grey area of whether the text is significant/normative or 
>>> not.  Hence the temporary step to make them not displayed for now.
>>>
>>> -- Jon
>>>
>>> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
>>>> The "summary" is unsupported by the HTML5 and we replace it by 
>>>> invisible caption.
>>>> These new styles are located in the stylesheet.css in the root of 
>>>> the JavaDoc api folder, so I assume these styles should be used by 
>>>> others as well.
>>>> They were added by this fix:
>>>> https://bugs.openjdk.java.net/browse/JDK-8179479
>>>>
>>>> ----- philip.race at oracle.com wrote:
>>>>
>>>>> Does this in any way match the rest of the docs ? Or is everyone left
>>>>> to
>>>>> style things how they want.
>>>>> I thought (?) maybe there is to be some javadoc tool support for CSS
>>>>> styles.
>>>>>
>>>>> Also why are all the table summaries removed ?
>>>>>
>>>>> -phil.
>>>>>
>>>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>>>>> This is because I use the same style for most of the tables
>>>>> 'class="striped"', which apply the same/unified style for 
>>>>> all(most) of
>>>>> our tables.
>>>>>> Also this is because I removed 'inlined' styles, like here:
>>>>>>
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>>
>>>>>> ----- philip.race at oracle.com wrote:
>>>>>>
>>>>>>> Adding 2d-dev because a number of the files are 2D.
>>>>>>>
>>>>>>> What is the general reason for changing the appearance of the
>>>>> tables?
>>>>>>> -phil.
>>>>>>>
>>>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>>>>> Hello,
>>>>>>>> Please review the fix for jdk9-dev.
>>>>>>>>
>>>>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>>>>> compatible to HTML5.
>>>>>>>> It covers all errors which are reported by the javadoc tool
>>>>> during
>>>>>>> the build of jdk for java.desktop module.
>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>>>>> Webrev can be found at:
>>>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>>>>> Note that an appearance of some tables were changed after the
>>>>> fix:
>>>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>>
>>>>>>>> After:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>>>
>>>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>>>
>>>>>>>> After :
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>>>
>>>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>>>
>>>>>>>> After:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>>>
>>>
>>
>


From philip.race at oracle.com  Wed May 17 18:58:53 2017
From: philip.race at oracle.com (Phil Race)
Date: Wed, 17 May 2017 11:58:53 -0700
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
In-Reply-To: <14e7746f-b3a6-7310-1b3a-e1196acf96d8@oracle.com>
References: <cc06639b-5267-4b26-a487-e05aaf40879c@default>
 <59164F29.8070300@oracle.com>
 <635d9ffc-bb5d-2a4e-273f-4b477caa7239@oracle.com>
 <591C9BE9.1080905@oracle.com>
 <14e7746f-b3a6-7310-1b3a-e1196acf96d8@oracle.com>
Message-ID: <f1af3ebd-abde-d4e4-1091-e6165612cba6@oracle.com>

And PS I was not saying anything to contradict
 > tables should not have a summary attribute and should have a caption.

However that the docs I read on the web did seem to imply that
summary was very much intended for ATs but it was not at all clear this
is the point of caption. I'm sure they can read it, but I don't get how 
making
it visible matters to them so how it making it visible relates to 
accessibility
requirements is not an obvious connection to me. So why do we have
to make it visible for ATs ?

-phil.

On 05/17/2017 11:54 AM, Phil Race wrote:
> I will leave the decision on whether to do that now up to Sergey although
> it seems all he has to do here is remove "invisible".
> Many of the "summary" ones had wrong or misleading text but they
> seem to have been all fixed.
>
> I'd want to see what the new HTML looks like with a visible title of 
> course ..
>
> -phil.
>
> On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
>> Phil,
>>
>> The bottom line is that in the JDK docs, tables should not have a 
>> summary attribute and should have a caption. This comes down to 
>> accessibility requirements, where we are slowly raising the bar on 
>> our docs, to be in accordance with Oracle's guidelines.
>>
>> Hiding the caption (style="display:none") is an interim measure we 
>> have been using during the HTML 5 updates, especially in cases where 
>> the person doing the markup changes did not know enough to create an 
>> appropriate caption that should be displayed. In time, we should 
>> locate and update all table captions (in our standard docs bundle) 
>> that are not being displayed such that the text is both appropriate 
>> and visible. If you guys want to do that as part of this update, go 
>> ahead. FWIW, that is what we did for the java.xml module in the jaxp 
>> repo ... pretty much all tables there now have a reasonable, visible 
>> caption.
>>
>> -- Jon
>>
>>
>>
>> On 05/17/2017 11:19 AM, Phil Race wrote:
>>> I am not sure we are using the summary in a way that makes it 
>>> worthwhile.
>>> As you noted in the other mail
>>> "The summary attribute was used to give a more descriptive value
>>> of the contents of the table.   A caption is more like a title"
>>>
>>> The values I see are more like a title and as you say that is not 
>>> the idea. See the example here
>>>
>>> https://www.w3.org/TR/WCAG20-TECHS/H73.html
>>>
>>> Caption sounds like a title so it might actually be more appropriate 
>>> than summary
>>> for the text we have except that its not clear why we'd want it to 
>>> be visible when we were fine without.
>>>
>>> But being there and invisible may be pointless unless screen readers 
>>> look for it even if invisible.
>>>
>>> But if its not doing any harm I guess we can leave it as proposed
>>>
>>> I still need to look at the rest of the changes.
>>>
>>> -phil.
>>>
>>> On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
>>>> Sergey,
>>>>
>>>> FWIW, the invisible caption should be regarded as a temporary 
>>>> solution, until content authors can review/update the text of the 
>>>> caption and make it visible.
>>>>
>>>> The general guideline in this conversion work has been to avoid 
>>>> changing the visible text of the specification, and captions fall 
>>>> into a grey area of whether the text is significant/normative or 
>>>> not.  Hence the temporary step to make them not displayed for now.
>>>>
>>>> -- Jon
>>>>
>>>> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
>>>>> The "summary" is unsupported by the HTML5 and we replace it by 
>>>>> invisible caption.
>>>>> These new styles are located in the stylesheet.css in the root of 
>>>>> the JavaDoc api folder, so I assume these styles should be used by 
>>>>> others as well.
>>>>> They were added by this fix:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8179479
>>>>>
>>>>> ----- philip.race at oracle.com wrote:
>>>>>
>>>>>> Does this in any way match the rest of the docs ? Or is everyone 
>>>>>> left
>>>>>> to
>>>>>> style things how they want.
>>>>>> I thought (?) maybe there is to be some javadoc tool support for CSS
>>>>>> styles.
>>>>>>
>>>>>> Also why are all the table summaries removed ?
>>>>>>
>>>>>> -phil.
>>>>>>
>>>>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>>>>>> This is because I use the same style for most of the tables
>>>>>> 'class="striped"', which apply the same/unified style for 
>>>>>> all(most) of
>>>>>> our tables.
>>>>>>> Also this is because I removed 'inlined' styles, like here:
>>>>>>>
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>>>
>>>>>>> ----- philip.race at oracle.com wrote:
>>>>>>>
>>>>>>>> Adding 2d-dev because a number of the files are 2D.
>>>>>>>>
>>>>>>>> What is the general reason for changing the appearance of the
>>>>>> tables?
>>>>>>>> -phil.
>>>>>>>>
>>>>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>>>>>> Hello,
>>>>>>>>> Please review the fix for jdk9-dev.
>>>>>>>>>
>>>>>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>>>>>> compatible to HTML5.
>>>>>>>>> It covers all errors which are reported by the javadoc tool
>>>>>> during
>>>>>>>> the build of jdk for java.desktop module.
>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>>>>>> Webrev can be found at:
>>>>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>>>>>> Note that an appearance of some tables were changed after the
>>>>>> fix:
>>>>>>>>> Before:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>>>
>>>>>>>>> After:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>>>>
>>>>>>>>> Before:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>>>>
>>>>>>>>> After :
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>>>>
>>>>>>>>> Before:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>>>>
>>>>>>>>> After:
>>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>>>>
>>>>
>>>
>>
>


From sergey.bylokhov at oracle.com  Thu May 18 21:48:39 2017
From: sergey.bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 18 May 2017 14:48:39 -0700 (PDT)
Subject: <Sound Dev> <Swing Dev> [9] Review Request: 8180326 Update the
 tables in java.desktop to be HTML-5 friendly
Message-ID: <541766fe-bd76-487f-9d4d-946cd87906c5@default>

Hello.
Here is an updated version where most of the caption are visible.
Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
Webrev can be found at: http://cr.openjdk.java.net/~serb/8180326/webrev.02/
Specdiff: http://cr.openjdk.java.net/~serb/8180326/specdiff.02/overview-summary.html

You can use search to check the changes in some specific class:
Old docs: http://cr.openjdk.java.net/~serb/8180326/api_old.02/overview-summary.html
New docs: http://cr.openjdk.java.net/~serb/8180326/api.02/overview-summary.html


----- jonathan.gibbons at oracle.com wrote:

> Phil,
> 
> I have no evidence one way or the other whether screen readers pay 
> attention
> to undisplayed or invisible captions. It seemed safest to assume that
> 
> they would
> read a visible caption, and that we should head in that general
> direction.
> 
> -- Jon
> 
> 
> On 05/17/2017 11:58 AM, Phil Race wrote:
> > And PS I was not saying anything to contradict
> > > tables should not have a summary attribute and should have a
> caption.
> >
> > However that the docs I read on the web did seem to imply that
> > summary was very much intended for ATs but it was not at all clear
> this
> > is the point of caption. I'm sure they can read it, but I don't get
> 
> > how making
> > it visible matters to them so how it making it visible relates to 
> > accessibility
> > requirements is not an obvious connection to me. So why do we have
> > to make it visible for ATs ?
> >
> > -phil.
> >
> > On 05/17/2017 11:54 AM, Phil Race wrote:
> >> I will leave the decision on whether to do that now up to Sergey 
> >> although
> >> it seems all he has to do here is remove "invisible".
> >> Many of the "summary" ones had wrong or misleading text but they
> >> seem to have been all fixed.
> >>
> >> I'd want to see what the new HTML looks like with a visible title
> of 
> >> course ..
> >>
> >> -phil.
> >>
> >> On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
> >>> Phil,
> >>>
> >>> The bottom line is that in the JDK docs, tables should not have a
> 
> >>> summary attribute and should have a caption. This comes down to 
> >>> accessibility requirements, where we are slowly raising the bar on
> 
> >>> our docs, to be in accordance with Oracle's guidelines.
> >>>
> >>> Hiding the caption (style="display:none") is an interim measure we
> 
> >>> have been using during the HTML 5 updates, especially in cases
> where 
> >>> the person doing the markup changes did not know enough to create
> an 
> >>> appropriate caption that should be displayed. In time, we should 
> >>> locate and update all table captions (in our standard docs bundle)
> 
> >>> that are not being displayed such that the text is both
> appropriate 
> >>> and visible. If you guys want to do that as part of this update,
> go 
> >>> ahead. FWIW, that is what we did for the java.xml module in the
> jaxp 
> >>> repo ... pretty much all tables there now have a reasonable,
> visible 
> >>> caption.
> >>>
> >>> -- Jon
> >>>
> >>>
> >>>
> >>> On 05/17/2017 11:19 AM, Phil Race wrote:
> >>>> I am not sure we are using the summary in a way that makes it 
> >>>> worthwhile.
> >>>> As you noted in the other mail
> >>>> "The summary attribute was used to give a more descriptive value
> >>>> of the contents of the table.   A caption is more like a title"
> >>>>
> >>>> The values I see are more like a title and as you say that is not
> 
> >>>> the idea. See the example here
> >>>>
> >>>> https://www.w3.org/TR/WCAG20-TECHS/H73.html
> >>>>
> >>>> Caption sounds like a title so it might actually be more 
> >>>> appropriate than summary
> >>>> for the text we have except that its not clear why we'd want it
> to 
> >>>> be visible when we were fine without.
> >>>>
> >>>> But being there and invisible may be pointless unless screen 
> >>>> readers look for it even if invisible.
> >>>>
> >>>> But if its not doing any harm I guess we can leave it as
> proposed
> >>>>
> >>>> I still need to look at the rest of the changes.
> >>>>
> >>>> -phil.
> >>>>
> >>>> On 05/12/2017 05:11 PM, Jonathan Gibbons wrote:
> >>>>> Sergey,
> >>>>>
> >>>>> FWIW, the invisible caption should be regarded as a temporary 
> >>>>> solution, until content authors can review/update the text of
> the 
> >>>>> caption and make it visible.
> >>>>>
> >>>>> The general guideline in this conversion work has been to avoid
> 
> >>>>> changing the visible text of the specification, and captions
> fall 
> >>>>> into a grey area of whether the text is significant/normative or
> 
> >>>>> not.  Hence the temporary step to make them not displayed for
> now.
> >>>>>
> >>>>> -- Jon
> >>>>>
> >>>>> On 05/12/2017 05:00 PM, Sergey Bylokhov wrote:
> >>>>>> The "summary" is unsupported by the HTML5 and we replace it by
> 
> >>>>>> invisible caption.
> >>>>>> These new styles are located in the stylesheet.css in the root
> of 
> >>>>>> the JavaDoc api folder, so I assume these styles should be used
> 
> >>>>>> by others as well.
> >>>>>> They were added by this fix:
> >>>>>> https://bugs.openjdk.java.net/browse/JDK-8179479
> >>>>>>
> >>>>>> ----- philip.race at oracle.com wrote:
> >>>>>>
> >>>>>>> Does this in any way match the rest of the docs ? Or is
> everyone 
> >>>>>>> left
> >>>>>>> to
> >>>>>>> style things how they want.
> >>>>>>> I thought (?) maybe there is to be some javadoc tool support
> for 
> >>>>>>> CSS
> >>>>>>> styles.
> >>>>>>>
> >>>>>>> Also why are all the table summaries removed ?
> >>>>>>>
> >>>>>>> -phil.
> >>>>>>>
> >>>>>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
> >>>>>>>> This is because I use the same style for most of the tables
> >>>>>>> 'class="striped"', which apply the same/unified style for 
> >>>>>>> all(most) of
> >>>>>>> our tables.
> >>>>>>>> Also this is because I removed 'inlined' styles, like here:
> >>>>>>>>
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> 
> >>>>>>>
> >>>>>>>> ----- philip.race at oracle.com wrote:
> >>>>>>>>
> >>>>>>>>> Adding 2d-dev because a number of the files are 2D.
> >>>>>>>>>
> >>>>>>>>> What is the general reason for changing the appearance of
> the
> >>>>>>> tables?
> >>>>>>>>> -phil.
> >>>>>>>>>
> >>>>>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> >>>>>>>>>> Hello,
> >>>>>>>>>> Please review the fix for jdk9-dev.
> >>>>>>>>>>
> >>>>>>>>>> This fix is a part of the effort to make all javadoc in
> jdk9 be
> >>>>>>>>> compatible to HTML5.
> >>>>>>>>>> It covers all errors which are reported by the javadoc
> tool
> >>>>>>> during
> >>>>>>>>> the build of jdk for java.desktop module.
> >>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
> >>>>>>>>>> Webrev can be found at:
> >>>>>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
> >>>>>>>>>> Note that an appearance of some tables were changed after
> the
> >>>>>>> fix:
> >>>>>>>>>> Before:
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html
> 
> >>>>>>>
> >>>>>>>>>> After:
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html
> 
> >>>>>>>
> >>>>>>>>>> Before:
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html
> 
> >>>>>>>
> >>>>>>>>>> After :
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html
> 
> >>>>>>>
> >>>>>>>>>> Before:
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html
> 
> >>>>>>>
> >>>>>>>>>> After:
> >>>>>>>
> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html
> 
> >>>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >