From Sergey.Bylokhov at oracle.com  Thu Apr 12 21:58:39 2018
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 12 Apr 2018 14:58:39 -0700
Subject: <Sound Dev> [11] Review Request: 8201279 javax.sound tests should
 not set java.home system property
Message-ID: <ac01e8e3-fb74-44aa-69c6-5bfa92714f89@oracle.com>

Hello, Audio Guru.

Please review the fix for jdk11.

This change adds an optional "javax.sound.config.file" system 
property(the similar name is used for logging: 
"java.util.logging.config.file") which specified default location of the 
properties file. Note that all errors which maybe occurs during access 
to this file are ignored in the same way as for default config file 
"jdk/conf/sound.properties"(BTW I am not sure that this is a good idea, 
but follow the current approach).

The CSR will be filed after the technical review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8201279
Webrev can be found at: http://cr.openjdk.java.net/~serb/8201279/webrev.01

-- 
Best regards, Sergey.

From Roger.Riggs at Oracle.com  Fri Apr 13 14:19:07 2018
From: Roger.Riggs at Oracle.com (Roger Riggs)
Date: Fri, 13 Apr 2018 10:19:07 -0400
Subject: <Sound Dev> [11] Review Request: 8201279 javax.sound tests should
 not set java.home system property
Message-ID: <0409b359-1111-5a53-a7a2-48ac6b985ddb@Oracle.com>

Hi,

A few comments:

Should the new system property javax.sound.config.file be an 
implementation specific property
and named "jdk.sound.config.file"?

JSSecurityManager.java:
Lines 99-102:? The code can be simplified by using Paths instead of 
File.? Paths.get() returns a Path;
it can be used directly by java.nio.file.Files.newBufferedReader(Path) 
to get the BufferedInputStream.

Otherwise, looks ok

$.02, Roger

---
Hello, Audio Guru.

Please review the fix for jdk11.

This change adds an optional "javax.sound.config.file" system
property(the similar name is used for logging:
"java.util.logging.config.file") which specified default location of the
properties file. Note that all errors which maybe occurs during access
to this file are ignored in the same way as for default config file
"jdk/conf/sound.properties"(BTW I am not sure that this is a good idea,
but follow the current approach).

The CSR will be filed after the technical review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8201279
Webrev can be found at: http://cr.openjdk.java.net/~serb/8201279/webrev.01

-- 
Best regards, Sergey.

From Sergey.Bylokhov at oracle.com  Fri Apr 20 00:19:05 2018
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 19 Apr 2018 17:19:05 -0700
Subject: <Sound Dev> [11] Review Request: 8202050 Add
 javax/sound/midi/Sequencer/Recording.java to the problemList
Message-ID: <1b6566ad-c528-c881-7fbb-0c64befd8642@oracle.com>

Hello, Audio Guru.

Please review the fix for jdk11.

Bug: https://bugs.openjdk.java.net/browse/JDK-8202050

The "Recording.java" test is added to the ProblemList.
The test will be fixed in: https://bugs.openjdk.java.net/browse/JDK-8167580

Fix is inline below:
diff -r 9070717a16a1 test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt	Wed Apr 18 14:07:41 2018 -0700
+++ b/test/jdk/ProblemList.txt	Thu Apr 19 17:14:52 2018 -0700
@@ -601,6 +601,8 @@

  javax/sound/sampled/Mixers/DisabledAssertionCrash.java 7067310 generic-all

+javax/sound/midi/Sequencer/Recording.java 8167580 linux-all,solaris-all

-- 
Best regards, Sergey.

From joe.darcy at oracle.com  Fri Apr 20 03:48:29 2018
From: joe.darcy at oracle.com (joe darcy)
Date: Thu, 19 Apr 2018 20:48:29 -0700
Subject: <Sound Dev> [11] Review Request: 8202050 Add
 javax/sound/midi/Sequencer/Recording.java to the problemList
In-Reply-To: <1b6566ad-c528-c881-7fbb-0c64befd8642@oracle.com>
References: <1b6566ad-c528-c881-7fbb-0c64befd8642@oracle.com>
Message-ID: <6a5c9822-5f33-56ed-4887-94e442ae1008@oracle.com>

Looks fine Sergey; thanks,

-Joe


On 4/19/2018 5:19 PM, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the fix for jdk11.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202050
>
> The "Recording.java" test is added to the ProblemList.
> The test will be fixed in: 
> https://bugs.openjdk.java.net/browse/JDK-8167580
>
> Fix is inline below:
> diff -r 9070717a16a1 test/jdk/ProblemList.txt
> --- a/test/jdk/ProblemList.txt??? Wed Apr 18 14:07:41 2018 -0700
> +++ b/test/jdk/ProblemList.txt??? Thu Apr 19 17:14:52 2018 -0700
> @@ -601,6 +601,8 @@
>
> ?javax/sound/sampled/Mixers/DisabledAssertionCrash.java 7067310 
> generic-all
>
> +javax/sound/midi/Sequencer/Recording.java 8167580 linux-all,solaris-all
>


From philip.race at oracle.com  Fri Apr 20 15:51:30 2018
From: philip.race at oracle.com (Phil Race)
Date: Fri, 20 Apr 2018 08:51:30 -0700
Subject: <Sound Dev> [11] Review Request: 8202050 Add
 javax/sound/midi/Sequencer/Recording.java to the problemList
In-Reply-To: <6a5c9822-5f33-56ed-4887-94e442ae1008@oracle.com>
References: <1b6566ad-c528-c881-7fbb-0c64befd8642@oracle.com>
 <6a5c9822-5f33-56ed-4887-94e442ae1008@oracle.com>
Message-ID: <6e907c3c-3f77-90ca-1fe6-845aba1fbf34@oracle.com>

+1

-phil.

On 04/19/2018 08:48 PM, joe darcy wrote:
> Looks fine Sergey; thanks,
>
> -Joe
>
>
> On 4/19/2018 5:19 PM, Sergey Bylokhov wrote:
>> Hello, Audio Guru.
>>
>> Please review the fix for jdk11.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202050
>>
>> The "Recording.java" test is added to the ProblemList.
>> The test will be fixed in: 
>> https://bugs.openjdk.java.net/browse/JDK-8167580
>>
>> Fix is inline below:
>> diff -r 9070717a16a1 test/jdk/ProblemList.txt
>> --- a/test/jdk/ProblemList.txt    Wed Apr 18 14:07:41 2018 -0700
>> +++ b/test/jdk/ProblemList.txt    Thu Apr 19 17:14:52 2018 -0700
>> @@ -601,6 +601,8 @@
>>
>>  javax/sound/sampled/Mixers/DisabledAssertionCrash.java 7067310 
>> generic-all
>>
>> +javax/sound/midi/Sequencer/Recording.java 8167580 linux-all,solaris-all
>>
>


From Sergey.Bylokhov at oracle.com  Sun Apr 22 00:55:18 2018
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Sat, 21 Apr 2018 17:55:18 -0700
Subject: <Sound Dev> [11] Review Request: 8201279 javax.sound tests
 should not set java.home system property
In-Reply-To: <0409b359-1111-5a53-a7a2-48ac6b985ddb@Oracle.com>
References: <0409b359-1111-5a53-a7a2-48ac6b985ddb@Oracle.com>
Message-ID: <3c3e2dcb-5645-4cd8-9f13-520810fa9547@oracle.com>

Hi, Roger.
Thank you for the review.

On 13/04/2018 07:19, Roger Riggs wrote:
> Should the new system property javax.sound.config.file be an 
> implementation specific property
> and named "jdk.sound.config.file"?

This new property describe a location of the "sound.properties" file, 
which is mentioned in the public specification already. Based on this 
and on the similar property for logging I selected this name 
"javax.sound.config.file".

> JSSecurityManager.java:
> Lines 99-102:? The code can be simplified by using Paths instead of 
> File.? Paths.get() returns a Path;
> it can be used directly by java.nio.file.Files.newBufferedReader(Path) 
> to get the BufferedInputStream.

The code simplified as suggested:
http://cr.openjdk.java.net/~serb/8201279/webrev.02

> 
> Otherwise, looks ok
> 
> $.02, Roger
> 
> ---
> Hello, Audio Guru.
> 
> Please review the fix for jdk11.
> 
> This change adds an optional "javax.sound.config.file" system
> property(the similar name is used for logging:
> "java.util.logging.config.file") which specified default location of the
> properties file. Note that all errors which maybe occurs during access
> to this file are ignored in the same way as for default config file
> "jdk/conf/sound.properties"(BTW I am not sure that this is a good idea,
> but follow the current approach).
> 
> The CSR will be filed after the technical review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8201279
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8201279/webrev.01
> 


-- 
Best regards, Sergey.