From Sergey.Bylokhov at oracle.com Thu Jan 18 03:55:55 2018 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 17 Jan 2018 19:55:55 -0800 Subject: [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound Message-ID: Hello, Audio Guru. Please review the fix for jdk11. The text for behavior of null arguments is added to the package-info files as suggested in the first step in the bug report. The text is copied from the javax.print package: https://docs.oracle.com/javase/9/docs/api/javax/print/package-summary.html The CSR will be filed after the technical review. Bug: https://bugs.openjdk.java.net/browse/JDK-4912693 Webrev can be found at: http://cr.openjdk.java.net/~serb/4912693/webrev.00 -- Best regards, Sergey. From danrollo at gmail.com Fri Jan 19 00:18:36 2018 From: danrollo at gmail.com (Dan Rollo) Date: Thu, 18 Jan 2018 19:18:36 -0500 Subject: [11] Review Request: 4912693 Behavior of null arguments not specified in Java Sound In-Reply-To: References: Message-ID: <6B4ACDFA-3829-4D9C-A55D-73839589B263@gmail.com> Hi Sergey, Looks good to me. One minor grammar thought: ?an example of a?. Maybe: {@code NullPointerException} is example of typical... Should be: {@code NullPointerException} is an example of a typical? -Dan > On Jan 17, 2018, at 10:55 PM, Sergey Bylokhov wrote: > > Hello, Audio Guru. > > Please review the fix for jdk11. > > The text for behavior of null arguments is added to the package-info files as suggested in the first step in the bug report. The text is copied from the javax.print package: > https://docs.oracle.com/javase/9/docs/api/javax/print/package-summary.html > > The CSR will be filed after the technical review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-4912693 > Webrev can be found at: http://cr.openjdk.java.net/~serb/4912693/webrev.00 > > -- > Best regards, Sergey.