<Sound Dev> [13] Review Request: 8221436 Incorrect check of package in Line.Info.toString()

Philip Race philip.race at oracle.com
Thu Mar 28 20:52:37 UTC 2019


Looks fine.

// this test just defend from the accidental changes.


should be written

// this test just defends against accidental changes.
  


-phil.

On 3/25/19, 7:01 PM, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the small fix for jdk13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8221436
> Fix: http://cr.openjdk.java.net/~serb/8221436/webrev.00
>
> The Line.Info.toString() method tries to cut the package string for 
> the build-in classes.
> But it does not take into account the custom packages like 
> "bug.javax.sound.sampled".
>
> Since this is the toString() method, I made the fixed code as compact 
> and simple as possible.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/sound-dev/attachments/20190328/cc2c3b11/attachment.html>


More information about the sound-dev mailing list