<Sound Dev> [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR)

Andrew Luo andrewluotechnologies at outlook.com
Tue May 14 00:36:49 UTC 2019


I've been trying to get the JDK to compile with the new /permissive- switch in VS2017 (https://devblogs.microsoft.com/cppblog/permissive-switch/) however there have been a few issues in various parts of the code.  There are a few issues in the libjsound code where we attempt to assign string literals to LPSTR variables (instead of LPCSTR).  I took some time to fix some of these and attached a patch.  Let me know if you have any comments/feedback.  I'm assuming that libjsound is owned by sound-dev, but if I'm mistaken, please do let me know the right team/mailing list to send this to.

c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR'

Thanks,

-Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/sound-dev/attachments/20190514/43eda235/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: jdksound.txt
URL: <https://mail.openjdk.java.net/pipermail/sound-dev/attachments/20190514/43eda235/jdksound.txt>


More information about the sound-dev mailing list