<Sound Dev> RFR: 8238567 SoftMainMixer.processAudioBuffers(): Wrong handling of stoppedMixers
Dan Rollo
danrollo at gmail.com
Mon Mar 16 21:07:47 UTC 2020
sorry, meant to reply to the list...
> On Mar 16, 2020, at 5:06 PM, Dan Rollo <danrollo at gmail.com> wrote:
>
> +1. Fix looks good to me.
>
> I wish we had a test that detects the problem, but I can see what that is difficult in this case.
>
> Dan
>
>
>> On Mar 16, 2020, at 8:34 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>
>> Hello.
>> Please review the fix for jdk/client.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238567
>> Fix: http://cr.openjdk.java.net/~serb/8238567/webrev.00
>>
>> The stoppedMixers Set contains the list of ModelChannelMixer, but we
>> tried to call stoppedMixers.contains/remove and pass SoftChannelMixerContainer
>> as a parameter. I was not able to trigger a bug by the test..
>>
>>
>> --
>> Best regards, Sergey.
>
More information about the sound-dev
mailing list