From serb at openjdk.java.net  Thu Oct 15 05:45:15 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Thu, 15 Oct 2020 05:45:15 GMT
Subject: <Sound Dev> RFR: 8254798: Deprecate for removal an empty finalize()
 methods in java.desktop module
Message-ID: <8pMgbLWwSVWixrMJ0E043-FmgaSQiDic-UkDTmFcfY0=.60b52fe4-d4fe-4b30-999a-69f2696f3156@github.com>

The java.desktop module has a few implementations of the finalize() method which do nothing. We can remove such methods
if the class is not public API, and could mark these methods in the public classes as "forRemoval = true"

-------------

Commit messages:
 - @SuppressWarnings("removal")
 - Initial fix

Changes: https://git.openjdk.java.net/jdk/pull/675/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=675&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8254798
  Stats: 49 lines in 6 files changed: 3 ins; 38 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/675.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/675/head:pull/675

PR: https://git.openjdk.java.net/jdk/pull/675

From pbansal at openjdk.java.net  Fri Oct 16 18:38:07 2020
From: pbansal at openjdk.java.net (Pankaj Bansal)
Date: Fri, 16 Oct 2020 18:38:07 GMT
Subject: <Sound Dev> RFR: 8254798: Deprecate for removal an empty
 finalize() methods in java.desktop module
In-Reply-To: <8pMgbLWwSVWixrMJ0E043-FmgaSQiDic-UkDTmFcfY0=.60b52fe4-d4fe-4b30-999a-69f2696f3156@github.com>
References: <8pMgbLWwSVWixrMJ0E043-FmgaSQiDic-UkDTmFcfY0=.60b52fe4-d4fe-4b30-999a-69f2696f3156@github.com>
Message-ID: <avO6fhxvgnEK3TTUxfDdzVvWXkQ6GoaJthq3pOOB_D4=.a7a66cb4-385f-4b07-bae7-f9064e2acbe1@github.com>

On Thu, 15 Oct 2020 05:29:42 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The java.desktop module has a few implementations of the finalize() method which do nothing. We can remove such methods
> if the class is not public API, and could mark these methods in the public classes as "forRemoval = true"

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/675

From serb at openjdk.java.net  Mon Oct 19 03:15:10 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Mon, 19 Oct 2020 03:15:10 GMT
Subject: <Sound Dev> Integrated: 8254798: Deprecate for removal an empty
 finalize() methods in java.desktop module
In-Reply-To: <8pMgbLWwSVWixrMJ0E043-FmgaSQiDic-UkDTmFcfY0=.60b52fe4-d4fe-4b30-999a-69f2696f3156@github.com>
References: <8pMgbLWwSVWixrMJ0E043-FmgaSQiDic-UkDTmFcfY0=.60b52fe4-d4fe-4b30-999a-69f2696f3156@github.com>
Message-ID: <Uujf712i5YQY7N0rPndXEo3f6Ra1iFWzmDwWK_Ti-CU=.4211d5c2-2c58-40b3-ba54-bb7d3e07885c@github.com>

On Thu, 15 Oct 2020 05:29:42 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The java.desktop module has a few implementations of the finalize() method which do nothing. We can remove such methods
> if the class is not public API, and could mark these methods in the public classes as "forRemoval = true"

This pull request has now been integrated.

Changeset: dd032b7f
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/dd032b7f
Stats:     49 lines in 6 files changed: 3 ins; 38 del; 8 mod

8254798: Deprecate for removal an empty finalize() methods in java.desktop module

Reviewed-by: kcr, pbansal

-------------

PR: https://git.openjdk.java.net/jdk/pull/675