From github.com+741251+turbanoff at openjdk.java.net Tue Mar 9 01:40:07 2021 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Tue, 9 Mar 2021 01:40:07 GMT Subject: Integrated: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs In-Reply-To: References: Message-ID: <-jLk_NzWGP-TyHwzQnXyexoqtktQBH3wUO52Fx6XlHc=.9c023cb6-db0f-429c-abbd-d565db439826@github.com> On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy This pull request has now been integrated. Changeset: 39b11138 Author: Andrey Turbanov Committer: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/39b11138 Stats: 134 lines in 11 files changed: 3 ins; 102 del; 29 mod 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs Reviewed-by: serb, prr ------------- PR: https://git.openjdk.java.net/jdk/pull/1856 From herrick at openjdk.java.net Fri Mar 12 16:13:36 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Fri, 12 Mar 2021 16:13:36 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations Message-ID: implementation of JDK-8256145: JEP 398: Deprecate the Applet API for Removal ------------- Commit messages: - 8189198: Add "forRemoval = true" to Applet API deprecations Changes: https://git.openjdk.java.net/jdk/pull/2920/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8189198 Stats: 74 lines in 22 files changed: 14 ins; 0 del; 60 mod Patch: https://git.openjdk.java.net/jdk/pull/2920.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2920/head:pull/2920 PR: https://git.openjdk.java.net/jdk/pull/2920 From iris at openjdk.java.net Fri Mar 12 18:20:06 2021 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 12 Mar 2021 18:20:06 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From almatvee at openjdk.java.net Sat Mar 13 00:46:07 2021 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Sat, 13 Mar 2021 00:46:07 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Marked as reviewed by almatvee (Committer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From alanb at openjdk.java.net Sun Mar 14 12:09:05 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Sun, 14 Mar 2021 12:09:05 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Sat, 13 Mar 2021 00:43:33 GMT, Alexander Matveev wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Marked as reviewed by almatvee (Committer). Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods? ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Wed Mar 17 15:35:49 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Wed, 17 Mar 2021 15:35:49 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: <4WfIqOQTCLxtbCQnD2xn4Doku9I1K5cnZ3FOv_JfeJQ=.09c24289-7e79-4592-9043-36b3b790701f@github.com> On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > the ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Wed Mar 17 15:35:49 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Wed, 17 Mar 2021 15:35:49 GMT Subject: Withdrawn: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Wed Mar 17 16:46:49 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Wed, 17 Mar 2021 16:46:49 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > > > Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods? in all cases either: - the class or method itself is being deprecated - the method takes a deprecated arg . - there is no local variable involved, such as testing if something is an instanceOf a class being deprecated, or calling a deprecated method. I cannot find any instances where the scope can be narrowed ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From alanb at openjdk.java.net Wed Mar 17 19:05:52 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Wed, 17 Mar 2021 19:05:52 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Wed, 17 Mar 2021 16:44:19 GMT, Andy Herrick wrote: > I cannot find any instances where the scope can be narrowed Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Wed Mar 17 20:35:54 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Wed, 17 Mar 2021 20:35:54 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: On Wed, 17 Mar 2021 19:02:39 GMT, Alan Bateman wrote: > > > > I cannot find any instances where the scope can be narrowed > > Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? These have the code pattern such as: } else if (c instanceof JApplet) { putting '@SuppressWarnings("removal")' before the declaration of 'c' does not help, because the code is not an assignment to 'c' ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From kcr at openjdk.java.net Thu Mar 25 20:19:27 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 25 Mar 2021 20:19:27 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: <8Vo0sYp5M4FNk6DKP2URAChl60rTHV-MpMsSUQi0-Nk=.c1f6ac22-cc67-4072-8d75-80032979db2f@github.com> On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal src/java.desktop/share/classes/java/applet/package-info.java line 39: > 37: * applet development environment. > 38: *

> 39: * @deprecated. This package has been deprecated and may be removed in Package declarations cannot have `@deprecated` tags, so `make docs` fails with this change. Also, since there is a tag here, the previous `

` is now empty and causes a warning. Both problems will be fixed by removing the `@deprecated` tag, while leaving the added text. ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Thu Mar 25 22:58:53 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Thu, 25 Mar 2021 22:58:53 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2] In-Reply-To: References: Message-ID: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additional commits since the last revision: - 8189198: Add "forRemoval = true" to Applet API deprecations - Merge branch 'master' into 8189198 - 8260862: JFR: New configure command for the jfr tool Reviewed-by: mgronlun - 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException Reviewed-by: bpb - 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2" Reviewed-by: cjplummer, lmesnik, sspitsyn - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling Reviewed-by: jnimeh - 8253795: Implementation of JEP 391: macOS/AArch64 Port 8253816: Support macOS W^X 8253817: Support macOS Aarch64 ABI in Interpreter 8253818: Support macOS Aarch64 ABI for compiled wrappers 8253819: Implement os/cpu for macOS/AArch64 8253839: Update tests and JDK code for macOS/Aarch64 8254941: Implement Serviceability Agent for macOS/AArch64 8255776: Change build system for macOS/AArch64 8262903: [macos_aarch64] Thread::current() called on detached thread Co-authored-by: Vladimir Kempik Co-authored-by: Bernhard Urban-Forster Co-authored-by: Ludovic Henry Co-authored-by: Monica Beckwith Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced Reviewed-by: adinn - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters Reviewed-by: herrick, dcubed - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan - ... and 291 more: https://git.openjdk.java.net/jdk/compare/ddfe8ec5...026f09c8 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2920/files - new: https://git.openjdk.java.net/jdk/pull/2920/files/1148f208..026f09c8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=00-01 Stats: 64315 lines in 2948 files changed: 41333 ins; 13022 del; 9960 mod Patch: https://git.openjdk.java.net/jdk/pull/2920.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2920/head:pull/2920 PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Thu Mar 25 22:58:53 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Thu, 25 Mar 2021 22:58:53 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2] In-Reply-To: References: Message-ID: On Wed, 17 Mar 2021 20:33:09 GMT, Andy Herrick wrote: >>> I cannot find any instances where the scope can be narrowed >> >> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? > >> >> >> > I cannot find any instances where the scope can be narrowed >> >> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? > > These have the code pattern such as: > } else if (c instanceof JApplet) { > putting '@SuppressWarnings("removal")' before the declaration of 'c' does not help, because the code is not an assignment to 'c' pushed minor change to src/java.desktop/share/classes/java/applet/package-info.java as well as merge with master. ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From kcr at openjdk.java.net Thu Mar 25 23:27:37 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 25 Mar 2021 23:27:37 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2] In-Reply-To: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> References: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> Message-ID: On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additional commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > > Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException > > Reviewed-by: bpb > - 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2" > > Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling > > Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port > 8253816: Support macOS W^X > 8253817: Support macOS Aarch64 ABI in Interpreter > 8253818: Support macOS Aarch64 ABI for compiled wrappers > 8253819: Implement os/cpu for macOS/AArch64 > 8253839: Update tests and JDK code for macOS/Aarch64 > 8254941: Implement Serviceability Agent for macOS/AArch64 > 8255776: Change build system for macOS/AArch64 > 8262903: [macos_aarch64] Thread::current() called on detached thread > > Co-authored-by: Vladimir Kempik > Co-authored-by: Bernhard Urban-Forster > Co-authored-by: Ludovic Henry > Co-authored-by: Monica Beckwith > Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced > > Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters > > Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() > > Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: https://git.openjdk.java.net/jdk/compare/e2285595...026f09c8 Looks good. ------------- Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/2920 From iris at openjdk.java.net Thu Mar 25 23:38:33 2021 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 25 Mar 2021 23:38:33 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2] In-Reply-To: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> References: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> Message-ID: On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additional commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > > Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException > > Reviewed-by: bpb > - 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2" > > Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling > > Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port > 8253816: Support macOS W^X > 8253817: Support macOS Aarch64 ABI in Interpreter > 8253818: Support macOS Aarch64 ABI for compiled wrappers > 8253819: Implement os/cpu for macOS/AArch64 > 8253839: Update tests and JDK code for macOS/Aarch64 > 8254941: Implement Serviceability Agent for macOS/AArch64 > 8255776: Change build system for macOS/AArch64 > 8262903: [macos_aarch64] Thread::current() called on detached thread > > Co-authored-by: Vladimir Kempik > Co-authored-by: Bernhard Urban-Forster > Co-authored-by: Ludovic Henry > Co-authored-by: Monica Beckwith > Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced > > Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters > > Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() > > Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: https://git.openjdk.java.net/jdk/compare/8fcfe0bd...026f09c8 Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From prr at openjdk.java.net Thu Mar 25 23:51:33 2021 From: prr at openjdk.java.net (Phil Race) Date: Thu, 25 Mar 2021 23:51:33 GMT Subject: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2] In-Reply-To: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> References: <-CtgNrXO36S532ldbcltqkgdva_l7Oaam8rBgC7yBQY=.b56cd831-56f3-4573-8a67-e4b835c677c9@github.com> Message-ID: On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additional commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > > Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException > > Reviewed-by: bpb > - 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2" > > Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling > > Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port > 8253816: Support macOS W^X > 8253817: Support macOS Aarch64 ABI in Interpreter > 8253818: Support macOS Aarch64 ABI for compiled wrappers > 8253819: Implement os/cpu for macOS/AArch64 > 8253839: Update tests and JDK code for macOS/Aarch64 > 8254941: Implement Serviceability Agent for macOS/AArch64 > 8255776: Change build system for macOS/AArch64 > 8262903: [macos_aarch64] Thread::current() called on detached thread > > Co-authored-by: Vladimir Kempik > Co-authored-by: Bernhard Urban-Forster > Co-authored-by: Ludovic Henry > Co-authored-by: Monica Beckwith > Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced > > Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters > > Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() > > Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: https://git.openjdk.java.net/jdk/compare/00b7b36f...026f09c8 Marked as reviewed by prr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2920 From herrick at openjdk.java.net Fri Mar 26 14:51:28 2021 From: herrick at openjdk.java.net (Andy Herrick) Date: Fri, 26 Mar 2021 14:51:28 GMT Subject: Integrated: 8189198: Add "forRemoval = true" to Applet API deprecations In-Reply-To: References: Message-ID: <4WWT8Ziy2C8n3V8-SQqJ_SNHpYlyB1uO26I-Szzm29c=.d2041dca-362a-4285-a961-7f71635df559@github.com> On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has now been integrated. Changeset: 57115fa2 Author: Andy Herrick URL: https://git.openjdk.java.net/jdk/commit/57115fa2 Stats: 73 lines in 22 files changed: 14 ins; 0 del; 59 mod 8189198: Add "forRemoval = true" to Applet API deprecations Reviewed-by: iris, almatvee, kcr, prr ------------- PR: https://git.openjdk.java.net/jdk/pull/2920